From: Christoph Hellwig <hch@infradead.org>
To: Ramshankar Venkataraman <ramshankar.venkataraman@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] KVM: Re-export kvm_enable_virtualization() and kvm_disable_virtualization() as normal (global) exports rather than only to KVM's vendor modules
Date: Fri, 24 Oct 2025 08:25:02 -0700 [thread overview]
Message-ID: <aPuaTnIdexx8erS5@infradead.org> (raw)
In-Reply-To: <20251024123838.54976-1-ramshankar.venkataraman@oracle.com>
On Fri, Oct 24, 2025 at 06:08:38PM +0530, Ramshankar Venkataraman wrote:
> Starting with 6.12.0 (3efc57369a0ce8f76bf0804f7e673982384e4ac9) KVM modules
> enabled virtualization in hardware during module init rather than when the
> first VM is started. This meant that VirtualBox users had to manually
> unload/disable KVM modules in-order to use VirtualBox.
>
> Starting with 6.16.0, kvm_enable_virtualization() and
> kvm_disable_virtualization() functions were exported. VirtualBox made use
> of these functions so our users did not need to unload/disable KVM kernel
> modules in-order to use VirtualBox. This made it possible to run KVM and
> VirtualBox side by side.
So? We never export modules for out of tree drivers. This should be
a reminder to the virtualbox project that they really should have
switched to using the kvm kernel code 10 years ago instead of wasting
time on their own buggy version. They managed to get that memo on
other platforms the hard way, and maybe this is the final wink for
Linux for folks to understand.
next prev parent reply other threads:[~2025-10-24 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 0:32 [PATCH v2 0/5] KVM: Export KVM-internal symbols for sub-modules only Sean Christopherson
2025-09-19 0:32 ` [PATCH v2 1/5] KVM: s390/vfio-ap: Use kvm_is_gpa_in_memslot() instead of open coded equivalent Sean Christopherson
2025-09-19 6:31 ` Christian Borntraeger
2025-09-19 0:33 ` [PATCH v2 2/5] KVM: Export KVM-internal symbols for sub-modules only Sean Christopherson
2025-09-23 1:27 ` Nathan Chancellor
2025-09-23 13:40 ` Sean Christopherson
2025-09-19 0:33 ` [PATCH v2 3/5] KVM: x86: Move kvm_intr_is_single_vcpu() to lapic.c Sean Christopherson
2025-09-19 0:33 ` [PATCH v2 4/5] KVM: x86: Drop pointless exports of kvm_arch_xxx() hooks Sean Christopherson
2025-09-19 0:33 ` [PATCH v2 5/5] KVM: x86: Export KVM-internal symbols for sub-modules only Sean Christopherson
2025-10-24 12:38 ` [PATCH] KVM: Re-export kvm_enable_virtualization() and kvm_disable_virtualization() as normal (global) exports rather than only to KVM's vendor modules Ramshankar Venkataraman
2025-10-24 15:25 ` Christoph Hellwig [this message]
2025-09-27 6:02 ` [PATCH v2 0/5] KVM: Export KVM-internal symbols for sub-modules only Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPuaTnIdexx8erS5@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=ramshankar.venkataraman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox