From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D6C526E6F0 for ; Fri, 7 Nov 2025 09:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762507047; cv=none; b=co6o83lSku1Y2LdNno/AUFHxPyZANy7w7IqXvV9PGksQHVIwy1yo6nQ64RQeHd3who49gD62onxImOOOTGdYhxLTmR3Hev6IdnUVEvoaKQlgL3Mdciuf4ia9rE8MBGVQR9CvkPZVFOMFNgGAv1wlP6O3WjnDJ+NNC2M45I94JcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762507047; c=relaxed/simple; bh=9PmcMVZDsHCK4rt0iNzZTEThhWDp09sptHuKBIoFGww=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GbOIC3Jg898ykyLwfs/PwfClYT9pjhPyhkDzUcuj/6tc5XVyWQnV179dLfez1tI/WAuxdWQ6+h7QUPPFBegE+dKdFjX36YUJk7+pcZczokFF/H0a5QEefEYqPoykn4JpRbP0AuLD5tXCrnoMaIK9/D9t+GAV7CuaR6fNqQpp8Ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yMMkEnEm; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yMMkEnEm" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4721b4f3afbso2349175e9.0 for ; Fri, 07 Nov 2025 01:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762507044; x=1763111844; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/Fu/bJv5yl4C82p3zPtmSlFNQMIanK+cOnJiMIeio9k=; b=yMMkEnEmRfbgUgnbjqM0C3iKasKrAVl5dBx3PxOtoDc4DFWyppTrWlyemSKwhSrB6/ XJngTzQ0uL9f+V7UeoKhOVHSOj7hPMxGuynqbbWf3TxHDpNYyjyi5lXoLaLFFARNlCDu wJuGGjamOYzDtiub5nABrsKzm+FvZvbVd4+vpJ/jDMMLxiT4MIxpBQqZuwu1adIcD+MI wvtFjq4bzvjOmXa9fTA0VOgKAZTTQs5DcZAaTJjDPtbAtyDFufeKq2JXkXLOPY/UufnI vHZ/Yhf6XcL5cH3LQzRpghQiDTibTt8EMOMgDdoBW6HXPfQn7hCWiwL7FRgXly4SZfua ifyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762507044; x=1763111844; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Fu/bJv5yl4C82p3zPtmSlFNQMIanK+cOnJiMIeio9k=; b=RC43N7kKqv4Bal72Skz9NYIedWUht9jKibG/mRdmIjSaBxyUOxO2ka43qtOcZtbWx7 23l1i6pqnEwof/m7mQZ822dk5kj+nw01pCBuGqKz3EkJczHSh5bn5O4289/dErZ4u7/v rp+bT+maU2pJpr2xaxCzfofp2N1HPnml84E8S90HaUHkux605hSofn3kAX93UsnHUjCS bQhu9ZjRHG4HPGDt9YkFgW3QU2cGFqaxC/tKkRbugo9HjYMqmv7ICEuxuqzGUrgdf8cL Z/s/4xN62QwSzI/+74ilV5Xshv6laW8w8xks7szGxgc8DpxF5dsPM8jA51PXatAKJedk 0fXQ== X-Forwarded-Encrypted: i=1; AJvYcCV3yIPJnmkzZrlVzq3uixDYPKJ+irL4CoXN2k5EoIyZv0uGbq0ltBfZOisz2stnBVfUAAKx/Yvf2thXgaY=@vger.kernel.org X-Gm-Message-State: AOJu0YzmuT2uuqBS4GETpbSKjg9RyhpbUEYHPxtNPEJNI9IZl7qG2dQf X+5hVq4OGwHicKppdPCrFiw+E6eije2wpkrjGWKzrYwFkkwi6KWVDuuVc+1KCK+61SFYza1a7+Q mIkseSJWSBd8cc75yCQ== X-Google-Smtp-Source: AGHT+IHgbMb0VxmaHAt6pjz/fRqkDWP8S9rkud4tbuPtykItYMZV8DRvEbIRPLT10AkQTXLwi9zhaXdoS9ucMWk= X-Received: from wmoz20.prod.google.com ([2002:a05:600c:794:b0:475:e020:fc28]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3513:b0:477:63b5:6f76 with SMTP id 5b1f17b1804b1-4776bcca2d5mr16265125e9.25.1762507043890; Fri, 07 Nov 2025 01:17:23 -0800 (PST) Date: Fri, 7 Nov 2025 09:17:23 +0000 In-Reply-To: <20251107024720.369067-1-m18080292938@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251107024720.369067-1-m18080292938@163.com> Message-ID: Subject: Re: [PATCH] rust: correct documentation comment for rbtree cursor peek_next method From: Alice Ryhl To: Hang Shu Cc: ojeda@kernel.org, Hang Shu , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Yutaro Ohno , "Onur =?utf-8?B?w5Z6a2Fu?=" , Borys Tyran , Charalampos Mitrodimas , Daniel Sedlak , Tamir Duberstein , Matt Gilbride , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Fri, Nov 07, 2025 at 02:47:16AM +0000, Hang Shu wrote: > From: Hang Shu > > The peek_next method's doc comment incorrectly stated it accesses the > "previous" node when it actually accesses the next node. This commit > fixes the documentation to accurately reflect the method's behavior. > > Fixes: 98c14e40e07a ("rust: rbtree: add cursor") > Signed-off-by: Hang Shu I shared a Reviewed-by tag for the first version, so please include it in the commit message when sending a new version. That way, I don't have to review the same code twice. Also, this should say [PATCH v2] in the subject since it's version 2 of this patch. Alice