From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux.dev>,
Jonathan Corbet <corbet@lwn.net>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Samiullah Khawaja <skhawaja@google.com>,
Kevin Tian <kevin.tian@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH 2/2] iommupt: Describe @bitnr parameter
Date: Fri, 7 Nov 2025 12:14:29 +0700 [thread overview]
Message-ID: <aQ2ANX6V3F1qfKdE@archie.me> (raw)
In-Reply-To: <20251107003541.GA1792527@ziepe.ca>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Thu, Nov 06, 2025 at 08:35:41PM -0400, Jason Gunthorpe wrote:
> On Thu, Nov 06, 2025 at 03:48:10PM -0800, Randy Dunlap wrote:
> > > diff --git a/drivers/iommu/generic_pt/pt_common.h b/drivers/iommu/generic_pt/pt_common.h
> > > index b5628f47e0db40..54c16355be2842 100644
> > > --- a/drivers/iommu/generic_pt/pt_common.h
> > > +++ b/drivers/iommu/generic_pt/pt_common.h
> > > @@ -354,6 +354,7 @@ static inline unsigned int pt_max_sw_bit(struct pt_common *common);
> > > /**
> > > * pt_test_sw_bit_acquire() - Read a software bit in an item
> > > * @pts: Entry to set
> > > + * @bitnr: Bit to set
> >
> > Shouldn't both of these (above) to "to read" instead of "to set"?
>
> Yes, that's right, Bagas could you fold that into a v2?
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-11-07 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 7:38 [PATCH 0/2] genpt documentation fixes Bagas Sanjaya
2025-11-06 7:38 ` [PATCH 1/2] Documentation: genpt: Don't use code block marker before iommu_amdv1.c include listing Bagas Sanjaya
2025-11-06 23:49 ` Randy Dunlap
2025-11-06 7:38 ` [PATCH 2/2] iommupt: Describe @bitnr parameter Bagas Sanjaya
2025-11-06 23:48 ` Randy Dunlap
2025-11-07 0:35 ` Jason Gunthorpe
2025-11-07 5:14 ` Bagas Sanjaya [this message]
2025-11-06 13:12 ` [PATCH 0/2] genpt documentation fixes Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ2ANX6V3F1qfKdE@archie.me \
--to=bagasdotme@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=corbet@lwn.net \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox