Re: [PATCH net v9 4/4] selftest: netcons: add test for netconsole over bonded interfaces

Breno Leitao
2025-11-07T13:55:40Z

Hello Simon,

On Fri, Nov 07, 2025 at 10:07:01AM +0000, Simon Horman wrote:
> On Thu, Nov 06, 2025 at 07:56:50AM -0800, Breno Leitao wrote:
> > function create_dynamic_target() {
> > local FORMAT=${1:-"extended"}
> > local NCPATH=${2:-"$NETCONS_PATH"}
> > - _create_dynamic_target "${FORMAT}" "${NCPATH}"
> > + create_and_enable_dynamic_target "${FORMAT}" "${NCPATH}"
>
> Sorry for not noticing this when I looked over v8.
> It's not that important and I don't think it should block progress.
>
> create_and_enable_dynamic_target() seems to only be used here.
> If so, perhaps the 'enabled' line could simply be added to
> create_dynamic_target() instead of creating adding
> create_and_enable_dynamic_target().

This is a good catch. I _think_ it is worth fixing, in fact.

I will send a v10 with this additional change.

diff --git a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
index 09553ecd50e39..3f891bd68d03c 100644
--- a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
+++ b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
@@ -147,15 +147,12 @@ function _create_dynamic_target() {
fi
}

-function create_and_enable_dynamic_target() {
- _create_dynamic_target "${FORMAT}" "${NCPATH}"
- echo 1 > "${NCPATH}"/enabled
-}
-
function create_dynamic_target() {
local FORMAT=${1:-"extended"}
local NCPATH=${2:-"$NETCONS_PATH"}
- create_and_enable_dynamic_target "${FORMAT}" "${NCPATH}"
+
+ _create_dynamic_target "${FORMAT}" "${NCPATH}"
+ echo 1 > "${NCPATH}"/enabled

# This will make sure that the kernel was able to
# load the netconsole driver configuration. The console message

Thanks for the review!
--breno