Re: [PATCH v2] vfs: remove the excl argument from the ->create() inode_operation

Bagas Sanjaya
2025-11-08T09:19:37Z

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

On Sat, Nov 08, 2025 at 03:12:10PM +0900, Dominique Martinet wrote:
> Jeff Layton wrote on Fri, Nov 07, 2025 at 10:05:03AM -0500:
> > diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> > index 4f13b01e42eb5e2ad9d60cbbce7e47d09ad831e6..7a55e491e0c87a0d18909bd181754d6d68318059 100644
> > --- a/Documentation/filesystems/vfs.rst
> > +++ b/Documentation/filesystems/vfs.rst
> > @@ -505,7 +505,10 @@ otherwise noted.
> > if you want to support regular files. The dentry you get should
> > not have an inode (i.e. it should be a negative dentry). Here
> > you will probably call d_instantiate() with the dentry and the
> > - newly created inode
> > + newly created inode. This operation should always provide O_EXCL
>
> This and the block below change halfway from tab (old text) to spaces
> (your patch)
>
> Looks like the file has a few space-indented sections though so it won't
> be the first if that goes in as is, the html-rendering doesn't seem to
> care :)

FYI: I'm using Vim. My important settings (in ~/.vimrc) are:

```
set nojoinspaces
set textwidth=0
set backspace=2
```

However, ftplugin override these for each file type, so you have to essentially
"fork" the relevant ftplugin file for each type if you want for your settings
to take precedence. For example, in case of reST, copy
/usr/share/vim/vim91/ftplugin/rst.vim to ~/.vim/ftplugin/rst and override the
already defined options there:

```
...
" keep tabs as-is
setlocal comments=fb:.. commentstring=..\ %s noexpandtab
...
if exists("g:rst_style") && g:rst_style != 0
setlocal noexpandtab shiftwidth=8 softtabstop=0 tabstop=8
endif
...
```

Thanks.

--
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]