From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: KRIISHSHARMA <kriish.sharma2006@gmail.com>,
nuno.sa@analog.com, olivier.moysan@foss.st.com, jic23@kernel.org,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] iio: fix kernel-doc warnings in industrialio-backend.c
Date: Tue, 28 Oct 2025 11:09:34 +0200 [thread overview]
Message-ID: <aQCITnF4kft6g64z@smile.fi.intel.com> (raw)
In-Reply-To: <23069e05-82d3-422f-9af7-fc100d4d1466@baylibre.com>
On Mon, Oct 27, 2025 at 10:35:02AM -0500, David Lechner wrote:
> On 10/27/25 4:21 AM, KRIISHSHARMA wrote:
...
> > * iio_backend_oversampling_ratio_set - set the oversampling ratio
> > * @back: Backend device
> > + * @chan: Channel number
> > * @ratio: The oversampling ratio - value 1 corresponds to no oversampling.
> > *
> > * Return:
>
> I guess it would not hurt to change this to RETURNS: to match the
> rest of the file either.
Good catch! KRIISHSHARMA, please check the whole file for this as it's not a
direct mistake from kernel-doc perspective, there is a mistake from consistency
point of view and hence needs to be addressed.
...
> > + * RETURNS:
> > + * Pointer to the driver private data associated with the backend.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-28 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 9:21 [PATCH v2] iio: fix kernel-doc warnings in industrialio-backend.c KRIISHSHARMA
2025-10-27 9:46 ` Andy Shevchenko
2025-10-27 15:35 ` David Lechner
2025-10-28 9:09 ` Andy Shevchenko [this message]
2025-10-28 9:36 ` Kriish Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQCITnF4kft6g64z@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kriish.sharma2006@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox