From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antony Kurniawan Soemardi <linux@smankusors.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels
Date: Tue, 28 Oct 2025 11:55:16 +0200 [thread overview]
Message-ID: <aQCTBHZ2pQ1pTAnA@smile.fi.intel.com> (raw)
In-Reply-To: <20251028-pm8xxx-xoadc-fix-v1-1-b000e1036e41@smankusors.com>
On Mon, Oct 27, 2025 at 05:29:16PM +0000, Antony Kurniawan Soemardi wrote:
> This allows user-space tools to identify ADC channels by name through
> the IIO sysfs interface.
...
> +static int pm8xxx_read_label(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *chan, char *label)
> +{
> + return sysfs_emit(label, "%s\n", chan->datasheet_name);
> +}
Hmm... In another thread there is a discussion on label vs. datasheet_name.
So, why datasheet name and not something that it's more reliable as a platform
description? As far as I understand there many mysterious ways of HW
engineering and how to connect available pins to something interesting. Even
datasheet names may be quite mislead on a certain platform (due to above).
I would expect this to come from DT or another platform description and user
space should rely on the information from _there_.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-28 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 17:29 [PATCH 0/2] iio: adc: qcom-pm8xxx-xoadc improvements Antony Kurniawan Soemardi
2025-10-27 17:29 ` [PATCH 1/2] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels Antony Kurniawan Soemardi
2025-10-28 9:55 ` Andy Shevchenko [this message]
2025-10-27 17:29 ` [PATCH 2/2] iio: adc: qcom-pm8xxx-xoadc: fix incorrect calibration values Antony Kurniawan Soemardi
2025-10-27 18:35 ` David Lechner
2025-10-27 19:53 ` Antony Kurniawan Soemardi
2025-10-27 20:36 ` David Lechner
2025-10-28 9:44 ` Konrad Dybcio
2025-10-30 16:57 ` Antony Kurniawan Soemardi
2025-10-31 9:00 ` Konrad Dybcio
2025-11-01 9:25 ` Dmitry Baryshkov
2026-01-11 17:31 ` Antony Kurniawan Soemardi
2026-01-15 7:32 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQCTBHZ2pQ1pTAnA@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@smankusors.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox