From: Johan Hovold <johan@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roger Quadros <rogerq@ti.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] phy: ti: omap-usb2: Fix device node reference leak in omap_usb2_probe
Date: Tue, 28 Oct 2025 11:17:39 +0100 [thread overview]
Message-ID: <aQCYQ8NY3iaC4G_E@hovoldconsulting.com> (raw)
In-Reply-To: <20251028062508.69382-1-linmq006@gmail.com>
On Tue, Oct 28, 2025 at 02:25:06PM +0800, Miaoqian Lin wrote:
> In omap_usb2_probe(), of_parse_phandle() returns a device node with its
> reference count incremented. The caller is responsible for releasing this
> reference when the node is no longer needed.
>
> Add of_node_put(control_node) after usage to fix the
> reference leak.
>
> Found via static analysis.
>
> Fixes: 478b6c7436c2 ("usb: phy: omap-usb2: Don't use omap_get_control_dev()")
> Cc: stable@vger.kernel.org
There should not be any need to backport this one.
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Other than that, looks good:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
prev parent reply other threads:[~2025-10-28 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 6:25 [PATCH] phy: ti: omap-usb2: Fix device node reference leak in omap_usb2_probe Miaoqian Lin
2025-10-28 10:17 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQCYQ8NY3iaC4G_E@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox