From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CD532F772 for ; Tue, 28 Oct 2025 13:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761656949; cv=none; b=pUf/FqxYb1X9fEAwG4kCeDtp2OZx4IsIz0YBs2poku8IBlGw8EmTgc4GhWx/EZYQHRqtudIC9obrWbdRkzAZzyDYRdJSoCAQZYeiGZaNfKz19X/ULFkzjwy86iqYdGF3iJ4YscATK8x1cdlCVPphzSGxyjOOL+sisbromMcU6Qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761656949; c=relaxed/simple; bh=GYhA9Iy3/9/Ee+jnl+wXccAoqjQ72aXNdQ/Z7T9pA1E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VTBLBFYkLjx0dkJrkAMZ6/OcFhNckQT3irmTG4K+aMUulm0h11c/4STn1j4iEU9h6vuKkS1Za60O9Qw8EuZQIoEkHEq4ZeYWyBJLVxmOBHjELq/utq5x8yav7Eo/UxEJvimdKhEwy9uxVMm1FXJjz+0lIqkj2T8AUrKfnGlDYyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=iti0ydl9; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="iti0ydl9" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4e89ac45e61so56894751cf.2 for ; Tue, 28 Oct 2025 06:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1761656946; x=1762261746; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YCGJuNdSiDHSbgE1dTHIFDy3cujeZVBX/ZxNKRqqViA=; b=iti0ydl9RPgT1+rOMGa7fKebSxzZ81u7N14kwlJzu5uRUDmZbPW+tGbASCk+XXvRwU 3DkxfpY9BRxdfJ67wcRt1kiNB9jxq9QtSFb272lGIQ7kWPWRvUs9PMmImYnfy4r3+yTN KsXR8cfl7FqQKXXEA+O1e0FjU/FZ73eJiEZBIvrerCSuFTu2IutUaosQeQ9TTgivg+ay n8Q8jKL8KKjOGEJHfPcAPfe/uiYjyGlNfmzGu/agS/soO6Q6ZUU+TgmPDQZxicUU9F76 HZAcaugdfQ1xnGONKzQmuOZtXRIULbBI7QzSFBY/1/Ke7dpJF2F3DYwINFlLU2aGy7D/ aVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761656946; x=1762261746; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YCGJuNdSiDHSbgE1dTHIFDy3cujeZVBX/ZxNKRqqViA=; b=hXPyGcms4IbMSOGwrC/NBoIBSjGDs6Mf4v2PfO02njZYp6wqc/sgemWi6vhjr3R5Tg q2V39qOMH007iBW02dmLCdZsN6Q8sDI5ilLJ31iKICLtoTBa3aHrS+nbC7gwOYgd+8L8 dycpGFRzjkGroKSo4GnO64DwGxtgMJ757MVNOriN5LlWKUhjRmMGQBA9nwO9oMm7MKa5 6fRB8RTj8gKwOgSV6eHuGnXbZgEg/7QuyP6bYHAP/jPk3hQmsN4Tw2emT9KbPf6vrxxz g5gsqx/xifERf8yqwD1BHuItVmdTQOO7NozGiT3rLrICThp95jVuBkNig1rqCA/g7f6Y yVvw== X-Forwarded-Encrypted: i=1; AJvYcCXm3uMmSYVfNzyKeB3N/EGShWcqULwU75kZjMtsUOof4HMKDLw1QbLtP9V6d4xBPKJXGBj8aQy75+rG0K8=@vger.kernel.org X-Gm-Message-State: AOJu0YwoR6DY4A78VsDRtbAEIjIEeYNWoV1tTt/q7nsXJSdNLYWsW0us CBArGvjVsDog9vqYUHKR3kEpcrIBVRDwLJyL88z9NNuRc350qfE3FxEGqdqhCQwKBWc= X-Gm-Gg: ASbGnctCeXtfDF0GjZYo91kL+HBz+OZQzW9uxIVvtH1gvIyIbXQcHHKWUrdfC900Cld MIgbw66fZKagdYVS4FXe8MW1khJsb6vWJWEnxafrU+IaH5KK1mRsaNY65C/TzRd4PiLNvvtpfA1 YYUD7t3lN4k/CrC+N9yG/K8ZLZypEgZkgXQJITquxpr9nXZ9LuEPYEeH0+Q8kVBcP4DjwNHOoU/ LNp602I9rjKgNz3yoGa/GT3iab2YlVElPtLEfdmKmDD3sJlPSMCIhQySJcZaO0S3hfgSFEhPBeO tZ8pq7883K24zAO9I5TVZt8OTSlO+nG/J5BZ01EmV2hTJhCxnUJj+RxqZzQf05W0TllMK3u/ak6 XRp5HZBHISD3M68CzJ1T4IoDZYJfNRJFZbRenCfPPqB74OJhqjRuvyb/lHKBjINaUvXtxQBbSvq yvKmxxesxax5aq6bzPbl3/jjm116hWUBYSrobXuPT/YD8Bfn6PQvncKfI466E= X-Google-Smtp-Source: AGHT+IH98kqIm4OLBZ9BxTzNh4SoN+f3UCMEHEUjHueEIBmZ3ZFACR4imRWFssU1iLJ7HaKse0MxjQ== X-Received: by 2002:a05:622a:261b:b0:4db:db96:15d3 with SMTP id d75a77b69052e-4ed074df11dmr43296561cf.31.1761656944848; Tue, 28 Oct 2025 06:09:04 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4eba386b6b9sm71298341cf.33.2025.10.28.06.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Oct 2025 06:09:04 -0700 (PDT) Date: Tue, 28 Oct 2025 09:09:01 -0400 From: Gregory Price To: Jason Gunthorpe Cc: Lorenzo Stoakes , David Hildenbrand , Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Peter Xu , Matthew Wilcox , Leon Romanovsky , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 05/12] fs/proc/task_mmu: refactor pagemap_pmd_range() Message-ID: References: <76348b1f-2626-4010-8269-edd74a936982@lucifer.local> <3f3e5582-d707-41d0-99a7-4e9c25f1224d@lucifer.local> <20251027161146.GG760669@ziepe.ca> <27a5ea4e-155c-40d1-87d7-e27e98b4871d@lucifer.local> <20251028125244.GI760669@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251028125244.GI760669@ziepe.ca> On Tue, Oct 28, 2025 at 09:52:44AM -0300, Jason Gunthorpe wrote: > On Mon, Oct 27, 2025 at 04:38:05PM +0000, Lorenzo Stoakes wrote: > > The union helps encode in the type system what code is operating on > what type of the leaf entry. > > It seems pretty simple. > My recommendation of a union was a joke and is anything but simple. Switching to a union now means every current toucher of a swp_entry_t needs functions to do conversions to/from that thing as it gets passed around to various subsystems. It increases overall complexity for no value, i.e. "for negative value". Please do not do this, I regret making the joke. Regards, Gregory