Re: [PATCH v2 3/7] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms

Jingyi Wang
2025-10-30T07:50:56Z

On 10/30/2025 2:27 PM, Krzysztof Kozlowski wrote:
> On Wed, Oct 29, 2025 at 01:05:41AM -0700, Jingyi Wang wrote:
>> Document the component used to boot SoCCP on Kaanapali SoC and add
>> compatible for Glymur SoCCP which could fallback to Kaanapali. Extend
>> the "qcom,smem-states" and "qcom,smem-state-names" properties and
>> add conditions for the "interrupts" and "interrupt-names" properties
>> in the pas-common.
>
> "extend" and "add conditions" but your patch:
>
>
>> - interrupts:
>> - minItems: 5
>> - items:
>> - - description: Watchdog interrupt
>> - - description: Fatal interrupt
>> - - description: Ready interrupt
>> - - description: Handover interrupt
>> - - description: Stop acknowledge interrupt
>> - - description: Shutdown acknowledge interrupt
>> -
>> - interrupt-names:
>> - minItems: 5
>> - items:
>> - - const: wdog
>> - - const: fatal
>> - - const: ready
>> - - const: handover
>> - - const: stop-ack
>> - - const: shutdown-ack
>
> ...removes them. So no interrupts anymore :/
>
> That looks surprising if not wrong. You cannot remove properties when
> you want to add grow them. See writing schema as well.
>
> Best regards,
> Krzysztof
>

There might be some misunderstanding on your comments for v1, so I removed
it to allOf part and add "if-else".

If it is changed here, we need to release the constraints like:

interrupts:
minItems: 5
items:
- description: Watchdog interrupt
- description: Fatal interrupt
- description: Ready interrupt
- description: Handover interrupt
- description: Stop acknowledge interrupt
- description: Shutdown acknowledge interrupt
- description: Pong interrupt
- description: Wake acknowledge interrupt

interrupt-names:
minItems: 5
maxItems: 7
items:
enum:
- wdog
- fatal
- ready
- handover
- stop-ack
- shutdown-ack
- pong
- wake-ack

Thanks,
Jingyi