Re: [PATCH v2 6/7] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP

Rob Herring
2025-10-29T13:29:02Z

On Wed, Oct 29, 2025 at 8:23 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Oct 29, 2025 at 01:05:44AM -0700, Jingyi Wang wrote:
> > From: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> >
> > Document compatible for Qualcomm Glymur SoC ADSP which is fully compatible
> > with SM8750 ADSP. Also with the Linux Host running on EL2, the remoteprocs
> > need to be hypervisor independent, the iommu property is mandatory to
> > ensure proper functionality.
> >
> > Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> > Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> > ---
> > .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > index 3b66bd106737..8cb839ba1058 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > @@ -29,6 +29,7 @@ properties:
> > - qcom,x1e80100-cdsp-pas
> > - items:
> > - enum:
> > + - qcom,glymur-adsp-pas
> > - qcom,kaanapali-adsp-pas
> > - qcom,sm8750-adsp-pas
> > - const: qcom,sm8550-adsp-pas
> > @@ -101,6 +102,7 @@ allOf:
> > compatible:
> > contains:
> > enum:
> > + - qcom,glymur-adsp-pas
> > - qcom,kaanapali-adsp-pas
> > - qcom,kaanapali-cdsp-pas
> > - qcom,sm8750-adsp-pas
> > @@ -247,6 +249,17 @@ allOf:
> > - const: mxc
> > - const: nsp
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,glymur-adsp-pas
> > + then:
> > + properties:
> > + iommus:
> > + maxItems: 1
>
> This doesn't make 'iommus' mandatory as the commit msg says.

Also, 'iommus' needs to be defined at the top-level of the schema.

Rob