From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE81340DB8 for ; Thu, 30 Oct 2025 11:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761824610; cv=none; b=M++Uvb/AEv2S1z3KcxsFs7Ad+n0KmXTEnwKGfT8Av6KuqFNk587c87jxny8JL1/RmIpnUXrtmUGbcB87GVH0/Bz7BOw31fm10ZCrgzSsoC2wxOC7jboUBXkKyUIPtW9XL+Y/rt6A4X1cZcshuOr6cAOTfVgb4Rraq/u+S5X9YVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761824610; c=relaxed/simple; bh=8K202zcT/5Asm+XAnj+oZfeb7i++8K1HRzH59kLoZlc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=E+1InJlZ+YhYRxM8mTZk8PitocPTBWFd8I8HSBIGGnfDORuz/x68/rDjKIT12CVpiTARAz57iIq6TeyJXyMq3h1ESAhKIA0pnfc5btardHWHzwVM5Tbdq0J6UWOBZgSeo5Ud4E3LTh6YWlU8Qid9JEbMEJ0MA5w7L5IzIeD/nmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=e6eub5k+; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="e6eub5k+" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-427a125c925so460645f8f.2 for ; Thu, 30 Oct 2025 04:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761824607; x=1762429407; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nDSI58A/HQKOUf6eeXjJJOZLO/JqDx1ROCyXyTZAY7w=; b=e6eub5k+S99WJGRdh3tMlYUvQRHbfhXapbdzJLS42qfE5/7K7jEApuqdBsz5RD+aG6 KsVtxKTip2zxubSN7O7gGykzcshX9Jba+DCbkxmt3h2UeoH9GUV6Rjk8yp0CYLLPRAz+ 3ryGYmpRZLOnXJlb3r44zO7glDOUp5ziTMDX3KHo5xm1WEh8Daboaq1al6GeL4b3nKKR z7JrDM96WlVI0/NvzmwBw9c5/t6YK8pV3tFPZT7ucSkB9es4eXNmzI+5GhmN8mvLCOZk wIiN0aZ4IGLj26y9lX9pZ8p/O5DrL9wFIAgN5ikhYnYq8PjyOPffgWjEukr1W7py3d7z R1uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761824607; x=1762429407; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nDSI58A/HQKOUf6eeXjJJOZLO/JqDx1ROCyXyTZAY7w=; b=HsTUUoGMa7uIgM9L8mmxJIZDjjJV9gLZSSrECgo7X+7Eh6T1Fn5SzuahC2CjwmHpWV LD3Ss+T29wWzmHW6uCdBGhY+mNfI/PPdpcKfdyE+GkacvTE00GWu260JNbQH3KQNwLBm L5QQqyuRNtfC82uoxTBJ/kAXVPKafq4vvKhjSvaM72R8Fw60tUM91u5ZBcrNTTYQvycg 9zOi7uDyKP6iDycsJbi8jqXFauqjeIubWDOw4Vtno8zxccQdTxxWjjKKUoStoJPiVr2R VSY3oi7yjWDKU4JpNUTTbkQZ7y5EU5PXQxYw1GbBXXOO07973tbZtboy7JAm/TJC6Cx3 kong== X-Forwarded-Encrypted: i=1; AJvYcCXk9yxnScNA4PDnfkwQMDlfR0ms5inU+Z9OmlTO/Gzh286ZoPXtb93+thwYiJXVmgcNjPp/+H/mxl07KGE=@vger.kernel.org X-Gm-Message-State: AOJu0YxYA9tpm12qOa1kbU2bnTwbsgE2aU3b/Xe4HchXf5XELKR4PZuM fZoKPGiSFpIJ3Qed3OjpcqsOHpCHZwU0mHy7MtRxuwEm92fqbFNVT6uKwmTOqYn0Mn9VIz6BfAz 9WcWiJ+DbhV2YTji1UA== X-Google-Smtp-Source: AGHT+IHzjpoD898gBgMNPMdZP5uEYogpZiJA8uErDROog5MEOI5DpnJbAzYLVH3kmqrIf4gyzUsqqY51Um1rkCk= X-Received: from wrme11.prod.google.com ([2002:adf:e38b:0:b0:3ec:e23c:988f]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:290f:b0:429:58f:325 with SMTP id ffacd0b85a97d-429aef830c6mr5166773f8f.24.1761824606490; Thu, 30 Oct 2025 04:43:26 -0700 (PDT) Date: Thu, 30 Oct 2025 11:43:25 +0000 In-Reply-To: <4e6d3f7b-551f-4cbf-8c00-2b9bb1f54d68@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <4e6d3f7b-551f-4cbf-8c00-2b9bb1f54d68@lucifer.local> Message-ID: Subject: Re: [PATCH 0/4] initial work on making VMA flags a bitmap From: Alice Ryhl To: Lorenzo Stoakes Cc: Nico Pache , Andrew Morton , Muchun Song , Oscar Salvador , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Peter Xu , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Kees Cook , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Leon Romanovsky , Zi Yan , Baolin Wang , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Xu Xin , Chengming Zhou , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Shakeel Butt , David Rientjes , Rik van Riel , Harry Yoo , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Johannes Weiner , Qi Zheng , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="utf-8" On Thu, Oct 30, 2025 at 08:33:10AM +0000, Lorenzo Stoakes wrote: > +cc Alice - could you help look at this? It seems I have broken the rust > bindings here :) > > Thanks! > > On Wed, Oct 29, 2025 at 09:07:07PM -0600, Nico Pache wrote: > > Hey Lorenzo, > > > > I put your patchset into the Fedora Koji system to run some CI on it for you. > > > > It failed to build due to what looks like some Rust bindings. > > > > Heres the build: https://koji.fedoraproject.org/koji/taskinfo?taskID=138547842 > > > > And x86 build logs: > > https://kojipkgs.fedoraproject.org//work/tasks/7966/138547966/build.log > > > > The error is pretty large but here's a snippet if you want an idea > > > > error[E0425]: cannot find value `VM_READ` in crate `bindings` > > --> rust/kernel/mm/virt.rs:399:44 > > | > > 399 | pub const READ: vm_flags_t = bindings::VM_READ as vm_flags_t; > > | ^^^^^^^ not found in `bindings` > > error[E0425]: cannot find value `VM_WRITE` in crate `bindings` > > --> rust/kernel/mm/virt.rs:402:45 > > | > > 402 | pub const WRITE: vm_flags_t = bindings::VM_WRITE as vm_flags_t; > > | ^^^^^^^^ not found > > in `bindings` > > error[E0425]: cannot find value `VM_EXEC` in crate `bindings` > > --> rust/kernel/mm/virt.rs:405:44 > > | > > 405 | pub const EXEC: vm_flags_t = bindings::VM_EXEC as vm_flags_t; > > | ^^^^^^^ help: a > > constant with a similar name exists: `ET_EXEC` > > | > > ::: /builddir/build/BUILD/kernel-6.18.0-build/kernel-6.18-rc3-16-ge53642b87a4f/linux-6.18.0-0.rc3.e53642b87a4f.31.bitvma.fc44.x86_64/rust/bindings/bindings_generated.rs:13881:1 > > | > > 13881 | pub const ET_EXEC: u32 = 2; > > | ---------------------- similarly named constant `ET_EXEC` defined here > > error[E0425]: cannot find value `VM_SHARED` in crate `bindings` > > --> rust/kernel/mm/virt.rs:408:46 > > | > > 408 | pub const SHARED: vm_flags_t = bindings::VM_SHARED as vm_flags_t; > > | ^^^^^^^^^ not found > > in `bindings` > > > > In the next version Ill do the same and continue with the CI testing for you! > > Thanks much appreciated :) > > It seems I broke the rust bindings (clearly), have pinged Alice to have a > look! > > May try and repro my side to see if there's something trivial that I could > take a look at. > > I ran this through mm self tests, allmodconfig + a bunch of other checks > but ofc enabling rust was not one, I should probably update my scripts [0] > to do that too :) > > Cheers, Lorenzo > > [0]:https://github.com/lorenzo-stoakes/review-scripts I can help convert the Rust bindings to work with this approach. I see there is a nice and simple vma_test() method for checking a flag, but I don't see any equivalent method for setting or unsetting a given bit. What would be the best function for Rust to call to set or unset a given bit in the vma flags? Alice