From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0D6637A3A6; Thu, 30 Oct 2025 17:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761846601; cv=none; b=bGgVhBHgDlUhLNrKl4pDVQ4Ji9i1g8VWb76ZMLtiI07u+Nq2LCeezwzkUrME2ipCFO1jq6SPgBazWSwf0OPiBTrRRpC7n34T65xHBwM4uO4OwhH3/lEIZPhTFVhSR53p2KjcI9khWTwIHJLRiKspYy0MntrJqm9OM6z9kDTmylI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761846601; c=relaxed/simple; bh=PmlVtuLRMUGlPaXNotA+Y+vL38gowXndZOXkWJxEguk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fAtf4+lSip0ZFmIDHwCUUpUECDZ10HUaZ1MHsG7XW6SjWx4b6NbfzN+CfiW8ejvSE2pr2GYDMMkYbtHj5L7eARnlPG4qTBu2ogYOKTwdW93xzneaUUK8rMjMfQgyt7B3NR8+EOL6ShWkTCmJrBLZNiWy7p6HWVlvQOdV6VIU85k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37EDC2C40; Thu, 30 Oct 2025 10:49:51 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 01E493F673; Thu, 30 Oct 2025 10:49:56 -0700 (PDT) Date: Thu, 30 Oct 2025 17:49:51 +0000 From: Mark Rutland To: Markus Elfring Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Catalin Marinas , David Brazdil , Joey Gouly , Marc Zyngier , Oliver Upton , Suzuki Poulouse , Will Deacon , Zenghui Yu , LKML , kernel-janitors@vger.kernel.org, Miaoqian Lin Subject: Re: [PATCH] KVM: arm64: Use pointer from memcpy() call for assignment in init_hyp_mode() Message-ID: References: <6e962260-5069-490a-89fb-908a4342ccd9@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e962260-5069-490a-89fb-908a4342ccd9@web.de> On Thu, Oct 30, 2025 at 06:11:03PM +0100, Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 30 Oct 2025 18:01:41 +0100 > > A pointer was assigned to a variable. The same pointer was used for > the destination parameter of a memcpy() call. > This function is documented in the way that the same value is returned. > Thus convert two separate statements into a direct variable assignment for > the return value from a memory copy action. > > The source code was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > arch/arm64/kvm/arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 870953b4a8a7..feab88c31703 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -2600,8 +2600,8 @@ static int __init init_hyp_mode(void) > goto out_err; > } > > - page_addr = page_address(page); > - memcpy(page_addr, CHOOSE_NVHE_SYM(__per_cpu_start), nvhe_percpu_size()); > + page_addr = memcpy(page_address(page), CHOOSE_NVHE_SYM(__per_cpu_start), > + nvhe_percpu_size()); This change makes the code harder to read, and harder to modify. It saves no space. As Dan said [1]: | No one will thank you for making these changes... :( Please don't do | it. [1] https://lore.kernel.org/lkml/aQNsecHJSO2U68Fc@stanley.mountain/ Mark.