From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A73F29AAE3 for ; Fri, 31 Oct 2025 08:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761899670; cv=none; b=RD21aPCuRp7c+Qelp7nfvSOKydlznchL7nbzJjSIh5L40DNLx14zbabcQRAd14UqWhXQnAJlkQB5KxaPSzyc+OGADkFR43OgG4nlbiGX4b0hHHwQOGrUMVrASCtoUbJH6aV2+8AuDZx9n1Nvs/cd1NjHH6o+CcXcDgFdYy5QeD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761899670; c=relaxed/simple; bh=JQVFkql8pWeK7mXHaJQC6Gx6KXjAssW26okHU8bcIA0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nNYAKc99ubrpFB9XzwyjaaXquO6UyqNM5OzUqXvtCFhg+1hM98xpMa6InUbklIfCmYOuc53KoA10Uxia95kmX5zlRw9NJxsDHzNdj6q85shpYXDDUeMct5pa0y4vuoLXrv5ANCVLR5sDenNBBu9taZg41C2FZLpnD48Z6BtaeF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CcNSXCN8; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CcNSXCN8" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47728f914a4so9564635e9.1 for ; Fri, 31 Oct 2025 01:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761899667; x=1762504467; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Brce2942SeTVJJTNYHk2AtyCkePvDy1yHUmXXiPEbXA=; b=CcNSXCN8WDDng70OdVvWRSucR6peMiB+orO6aX3K3eviSeNCIrRkQLHtz4RSn7OYQ9 rtjwdOAWKsx4/jkLbhh8f3Z1d8Rey9454hMhCsqKisgPtKn5YMBguXDtbcM3qr+8cuWw 4Gt+cwJi2dwb408jjCcuCHA5XDagHWbvfLNCXoHBu3dEtQB4bZRaF2GOP6HV1ozRysT2 zMhcxOcq534VG6DI4dNzP9jYEdRLTWkI39K5jwVLh2iVJKZRcVjXa2pMEEdRsFQDgtO9 jnT0pfY4655UvndmSOkz0H/aNTt4EOOqvp061i0dojQDcSw7DtUfEdd6+fMfJGJ5RqkR AAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761899667; x=1762504467; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Brce2942SeTVJJTNYHk2AtyCkePvDy1yHUmXXiPEbXA=; b=CbsiMMKC20oFXoEIhB/BFexqZjker70JW+4nF7JayWPH77+0oPeVcdBIPGDyJ1FlA/ ne/BmPzq93vMPOTlkyCe5eOIL2i+yqcOK0fU1idm43xv1WsEJUJV2wvBGzCsIRyqZErH zLrlE5kt+Wwr8vT4CXKm6kqIMajjO7lEDCAnLhnT4t6GoBER7R9Q+rjmH0FJT3nmyKyV GG9f9OfRNw/5truOdXBVf6DCFBxTs0PCa2Ifj7b7O/fxE49OdDUtv/5W/5PH6ZY49eb0 0ZPRIxGYNjqGLy9XgXAaH663iTydYHMM/TU0To2BuQ1cEDusqXhr2YR0Z28tF0Hvr5rp BA9g== X-Forwarded-Encrypted: i=1; AJvYcCUdghB65VT9JIx+V+8ZJeGxTybUIWKDZYEbzIgETwxssx0qzCZoA5BsazrYQo6zPYHQGK33f/V3O982GgM=@vger.kernel.org X-Gm-Message-State: AOJu0YwOtF0L1Hhw/sw3W235OkmJkJ3nU2m68yQcVTu/y4b/kZ5vQpH6 uHzlmHhVtu4IHHbSulMu00Mr0C9ND7Q7LSBnX3aXJvmFwHqDI/6oCkKrzlazFn8E6b8= X-Gm-Gg: ASbGncuM3K9kovKnIII0Fi1Ho6tcYfDmPrtw5WL/SPrcMqBH3AwSEYqG+hezjugWF2b piZcdgKaOIBk1gxxosWPhA3HqEcg78SJscuKKX5iVwCy3LSI4oqSA2yqXWrak52THEL3lgY2QGu o4mWmtXv0UKKxtslhtxL5gGqcvwNzvrrFmMEZteO9LGtYvOC7jDE7u0V8QfHx1Np4lD8Z1tM2Y1 2bXgs13OrcNCoWiP7ghz7ljKgiXcTfLn9ZvPDNfg3ob9RY3lid6bxQrdd0WM+grNWQWluD1K5d/ 1xQRINfYaldXcltxH7wMTEa5zET+ifzaRxDAte8OJvO1XG9wCnNH52pH7glLSggE1XvKM8clLuA auvQkDz2M3aXv4L57ST7xy4C0F+2kOBH/5UhHHOlqDoZ4X3EusiLd3OWa8fA0obhOqQlPq8KPMm sxALpPraF2+v8dqg== X-Google-Smtp-Source: AGHT+IEqeWzc1dYod8DDM80O+3DfRoIrCHAb+32/10VgcqcE8gyD3g3E2A+vxz5v6zZlDzTIz39ZaQ== X-Received: by 2002:a05:600c:34d0:b0:475:daa7:ec60 with SMTP id 5b1f17b1804b1-47730872dcamr20908505e9.21.1761899666777; Fri, 31 Oct 2025 01:34:26 -0700 (PDT) Received: from localhost (109-81-31-109.rct.o2.cz. [109.81.31.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4772fcf6c05sm17137655e9.4.2025.10.31.01.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 01:34:26 -0700 (PDT) Date: Fri, 31 Oct 2025 09:34:25 +0100 From: Michal Hocko To: Roman Gushchin Cc: Andrew Morton , linux-kernel@vger.kernel.org, Alexei Starovoitov , Suren Baghdasaryan , Shakeel Butt , Johannes Weiner , Andrii Nakryiko , JP Kobryn , linux-mm@kvack.org, cgroups@vger.kernel.org, bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Kumar Kartikeya Dwivedi , Tejun Heo Subject: Re: [PATCH v2 05/23] mm: declare memcg_page_state_output() in memcontrol.h Message-ID: References: <20251027231727.472628-1-roman.gushchin@linux.dev> <20251027231727.472628-6-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251027231727.472628-6-roman.gushchin@linux.dev> On Mon 27-10-25 16:17:08, Roman Gushchin wrote: > To use memcg_page_state_output() in bpf_memcontrol.c move the > declaration from v1-specific memcontrol-v1.h to memcontrol.h. > > Signed-off-by: Roman Gushchin Acked-by: Michal Hocko > --- > include/linux/memcontrol.h | 1 + > mm/memcontrol-v1.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 9af9ae28afe7..50d851ff3f27 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -949,6 +949,7 @@ static inline void mod_memcg_page_state(struct page *page, > } > > unsigned long memcg_page_state(struct mem_cgroup *memcg, int idx); > +unsigned long memcg_page_state_output(struct mem_cgroup *memcg, int item); > unsigned long lruvec_page_state(struct lruvec *lruvec, enum node_stat_item idx); > unsigned long lruvec_page_state_local(struct lruvec *lruvec, > enum node_stat_item idx); > diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h > index 6358464bb416..a304ad418cdf 100644 > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -27,7 +27,6 @@ unsigned long mem_cgroup_usage(struct mem_cgroup *memcg, bool swap); > void drain_all_stock(struct mem_cgroup *root_memcg); > > unsigned long memcg_events(struct mem_cgroup *memcg, int event); > -unsigned long memcg_page_state_output(struct mem_cgroup *memcg, int item); > int memory_stat_show(struct seq_file *m, void *v); > > void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n); > -- > 2.51.0 -- Michal Hocko SUSE Labs