From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Raag Jadav <raag.jadav@intel.com>,
kees@kernel.org, broonie@kernel.org, arnd@arndb.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mod_devicetable: Bump auxiliary_device_id name size
Date: Mon, 3 Nov 2025 10:16:58 +0200 [thread overview]
Message-ID: <aQhk-lQSDhzRmqHu@smile.fi.intel.com> (raw)
In-Reply-To: <2025110105-upright-dinginess-3b2c@gregkh>
On Sat, Nov 01, 2025 at 07:18:22AM +0100, Greg KH wrote:
> On Sat, Nov 01, 2025 at 12:32:34AM +0530, Raag Jadav wrote:
> > Since auxiliary device id string is formed using the combination of parent
> > and child device names, it may require more than 32 bytes if both the names
> > are long enough. Bump the size to 40 bytes to satisfy such cases.
>
> What in-kernel users need such a larger name? If we allow larger names,
> people will try to do crazy things and use memory addresses in them (has
> happened already...)
>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > ---
> > Triggered by [1].
> >
> > [1] https://lore.kernel.org/r/aQSwWLVKH_3TthTW@smile.fi.intel.com
>
> How long would this driver submission's name be? I couldn't figure it
> out, and really, any device with a huge name is going to be a pain...
Right, Raag, please describe a use case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-03 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 19:02 [PATCH v1] mod_devicetable: Bump auxiliary_device_id name size Raag Jadav
2025-11-01 6:18 ` Greg KH
2025-11-03 8:16 ` Andy Shevchenko [this message]
2025-11-03 12:50 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQhk-lQSDhzRmqHu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox