From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jyoti Bhayana" <jbhayana@google.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: common: scmi_sensors: Replace const_ilog2() with ilog2()
Date: Mon, 3 Nov 2025 10:30:22 +0200 [thread overview]
Message-ID: <aQhoHj0s_bjI1gNs@smile.fi.intel.com> (raw)
In-Reply-To: <20251031161331.0f0ef347@pumpkin>
On Fri, Oct 31, 2025 at 04:13:31PM +0000, David Laight wrote:
> On Fri, 31 Oct 2025 14:51:57 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Oct 31, 2025 at 12:45:30PM +0000, David Laight wrote:
...
> > Do you have an idea how to improve that?
>
> Not sure I'd want to get cpp to generate a high-precision log.
> It if definitely doable, but will be a mind-blowing mess.
> (and I'm not sure how many MB the expanded line would be).
> An ilog10() would be easier (probably looking like const_ilog2()).
>
> But for this code just use '+ 9' and add a suitable comment :-)
v2 is sent: 20251103082937.4081863-1-andriy.shevchenko@linux.intel.com
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-03 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 7:45 [PATCH v1 1/1] iio: common: scmi_sensors: Replace const_ilog2() with ilog2() Andy Shevchenko
2025-10-31 9:43 ` David Laight
2025-10-31 9:54 ` Andy Shevchenko
2025-10-31 12:45 ` David Laight
2025-10-31 12:51 ` Andy Shevchenko
2025-10-31 16:13 ` David Laight
2025-11-03 8:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQhoHj0s_bjI1gNs@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox