Re: [PATCH] KVM: x86: Add a helper to dedup reporting of unhandled VM-Exits

Yao Yuan
2025-11-01T01:49:37Z

On Fri, Oct 31, 2025 at 10:01:38AM +0800, Sean Christopherson wrote:
> On Fri, Oct 31, 2025, Yao Yuan wrote:
> > On Thu, Oct 30, 2025 at 11:50:03AM +0800, Sean Christopherson wrote:
> > I like the dedup, and this brings above for tdx which not
> > before. Just one small thing: Will it be better if keep the
> > "vmx"/"svm" hint as before and plus the "tdx" hint yet ?
>
> It'd be nice to have, but I honestly don't think it's worth going out of our
> way to capture that information. If someone can't disambiguate "kvm" to mean
> "vmx/tdx" vs. "svm" based on the host, they've got bigger problems.
>
> And as for "vmx" vs. "tdx", I really hope that's not meaningful information for
> users, e.g. the printks are ratelimited, and users should really be gleaning
> information from the VMM instance, not from dmesg.

thanks for your reply, Good point on printks are ratelimited!

Reviewed-by: yaoyuan@linux.alibaba.com