From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 02/10] pinctrl: alderlake: Switch to INTEL_GPP() macro
Date: Wed, 5 Nov 2025 13:40:06 +0200 [thread overview]
Message-ID: <aQs3ls1rKgMOufOn@smile.fi.intel.com> (raw)
In-Reply-To: <20251105103122.GL2912318@black.igk.intel.com>
On Wed, Nov 05, 2025 at 11:31:22AM +0100, Mika Westerberg wrote:
> On Tue, Nov 04, 2025 at 03:56:36PM +0100, Andy Shevchenko wrote:
> > Replace custom macro with the recently defined INTEL_GPP().
...
> > -#define ADL_GPP(r, s, e, g) \
> > - { \
> > - .reg_num = (r), \
> > - .base = (s), \
> > - .size = ((e) - (s) + 1), \
> > - .gpio_base = (g), \
> > - }
>
> I wonder if simply doing this:
>
> #define ADL_GPP(r, s, e, g) INTEL_GPP(r, s, e, g)
We can, but it will give a couple of lines in each driver still be left.
Do you think it's better?
> is better? Then the amount of changes are smaller.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-05 11:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 14:56 [PATCH v1 00/10] pinctrl: intel: Consolidate struct intel_padgroup initialisers Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 01/10] pinctrl: intel: Introduce INTEL_GPP() macro Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 02/10] pinctrl: alderlake: Switch to " Andy Shevchenko
2025-11-05 10:31 ` Mika Westerberg
2025-11-05 11:40 ` Andy Shevchenko [this message]
2025-11-05 11:50 ` Mika Westerberg
2025-11-05 11:51 ` Andy Shevchenko
2025-11-05 11:55 ` Mika Westerberg
2025-11-05 15:27 ` Andy Shevchenko
2025-11-05 15:41 ` Mika Westerberg
2025-11-05 17:11 ` Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 03/10] pinctrl: cannonlake: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 04/10] pinctrl: icelake: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 05/10] pinctrl: jasperlake: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 06/10] pinctrl: lakefield: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 07/10] pinctrl: meteorlake: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 08/10] pinctrl: meteorpoint: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 09/10] pinctrl: tigerlake: " Andy Shevchenko
2025-11-04 14:56 ` [PATCH v1 10/10] pinctrl: sunrisepoint: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQs3ls1rKgMOufOn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox