From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9514A1D5CC9; Wed, 5 Nov 2025 13:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.228.1.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762350349; cv=none; b=klvJrHsdIqDEgO7AeD2Pq2PJf4JdxTFDGsvFZjBpIsqnUQf2QoExwmXAy8fDv3Xlx6hRgK7mpoIl3k7/L6gk8HmnnwOps29LTKURigohaCLK5mYckI4solaGBkFTatGHIfGVWQLmaGRm+jzc6CkVoji68oMiPxuiurE6wjs18ic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762350349; c=relaxed/simple; bh=89xmLV1cc5APaC2SFgb02Pjd41W8Cu5yepL4zNtfdQc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oK8fhbDeBDI+ilL0gRs1uDHgruNqsZSHmUkll0hA81Re+ez2FNMRLumQRDmofHXjmxxUZd5pdhMSyXYHeKGGH2uRKvlVy15w7xraBX1dW1okwUdHk9XexiLumQDshcpuPRhmGKnXOVU98crRp3LPZ/UFQg+KldMz7ZvAcgTjQBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass smtp.mailfrom=kernel.crashing.org; arc=none smtp.client-ip=63.228.1.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost [127.0.0.1]) by gate.crashing.org (8.18.1/8.18.1/Debian-2) with ESMTP id 5A5DiSRa1593373; Wed, 5 Nov 2025 07:44:28 -0600 Received: (from segher@localhost) by gate.crashing.org (8.18.1/8.18.1/Submit) id 5A5DiQRd1593372; Wed, 5 Nov 2025 07:44:26 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 5 Nov 2025 07:44:26 -0600 From: Segher Boessenkool To: Nathan Chancellor Cc: Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ard Biesheuvel , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-efi@vger.kernel.org, llvm@lists.linux.dev, Christian Brauner Subject: Re: [PATCH] kbuild: Add '-fms-extensions' to areas with dedicated CFLAGS Message-ID: References: <20251101-kbuild-ms-extensions-dedicated-cflags-v1-1-38004aba524b@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251101-kbuild-ms-extensions-dedicated-cflags-v1-1-38004aba524b@kernel.org> Hi! On Sat, Nov 01, 2025 at 12:35:47PM -0400, Nathan Chancellor wrote: > There are many places within the kernel that use their own CFLAGS > instead of the main KBUILD_CFLAGS, meaning code written with the main > kernel's use of '-fms-extensions' in mind that may be tangentially > included in these areas will result in "error: declaration does not > declare anything" messages from the compiler. Please fix such non-standard code then, instead? The only (documented) thing -fms-extensions does for C code is give meaning to something that otherwise is a syntax error (and it is for a good reason!) Segher