From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoni Pokusinski <apokusinski01@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, marcelo.schmitt1@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] iio: mpl3115: use get_unaligned_be24 to retrieve pressure data
Date: Wed, 5 Nov 2025 17:20:52 +0200 [thread overview]
Message-ID: <aQtrVNktJcNrFOdx@smile.fi.intel.com> (raw)
In-Reply-To: <20251105095615.4310-2-apokusinski01@gmail.com>
On Wed, Nov 05, 2025 at 10:56:13AM +0100, Antoni Pokusinski wrote:
> The pressure measurement result is arranged as 20-bit unsigned value
> residing in three 8-bit registers. Hence, it can be retrieved using
> get_unaligned_be24 and by applying 4-bit shift.
get_unaligned_be24()
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
independently on the below.
...
> + u8 tmp[3];
While at it, you also may rename it to something better
${foo}_be24;
where ${foo} should be replaced to the meaningful name.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-05 15:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 9:56 [PATCH v3 0/3] iio: mpl3115: support for events Antoni Pokusinski
2025-11-05 9:56 ` [PATCH v3 1/3] iio: mpl3115: use get_unaligned_be24 to retrieve pressure data Antoni Pokusinski
2025-11-05 15:20 ` Andy Shevchenko [this message]
2025-11-07 1:33 ` Marcelo Schmitt
2025-11-09 16:38 ` Jonathan Cameron
2025-11-10 15:59 ` Antoni Pokusinski
2025-11-11 19:47 ` Jonathan Cameron
2025-11-05 9:56 ` [PATCH v3 2/3] iio: mpl3115: add threshold events support Antoni Pokusinski
2025-11-05 15:25 ` Andy Shevchenko
2025-11-06 20:28 ` Antoni Pokusinski
2025-11-07 1:55 ` Marcelo Schmitt
2025-11-07 22:01 ` Antoni Pokusinski
2025-11-08 19:05 ` Marcelo Schmitt
2025-11-09 16:02 ` Andy Shevchenko
2025-11-05 9:56 ` [PATCH v3 3/3] iio: ABI: document pressure event attributes Antoni Pokusinski
2025-11-07 2:32 ` Marcelo Schmitt
2025-11-07 9:26 ` Antoni Pokusinski
2025-11-09 16:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQtrVNktJcNrFOdx@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=apokusinski01@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox