From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71CF52367CE for ; Thu, 20 Nov 2025 21:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763672659; cv=none; b=MDatjBRK+jQoSda3FiyOBXdqIsSzDZWrIk8CorB1APRWvbHXpDNB3wX3ulrppjzgUfWIAELlmNEvCxvsCtSLV7vCXyykMfXbSj+D7slTF90dTp57maSlnH61SIU0o/vbhESIY10usqK40EzbD1ZQ39UyRAAfbr8SBXMpxScEkiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763672659; c=relaxed/simple; bh=D6UrdPQuPLa1mnOY4xB+Z4g11uxAOCrC9tuUkAZw2Tw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iRdx8VEBucmqDVr65tcErnAnMrwIltu9GRq/1wcG23Q6I2VnBzYrp3Mla1UQVfMCrXdf8v9wgoHyBrKFHJTEJ1v8Cu1qSPU1l47HKm9xOa9zXvfkBHBm0XedhXQB2OMklZmZSWZ81bDrcQje8ubVWfnz+YhwgoWb2Y7ssiDqtTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZA6BhQiT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZA6BhQiT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E534C4CEF1; Thu, 20 Nov 2025 21:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763672659; bh=D6UrdPQuPLa1mnOY4xB+Z4g11uxAOCrC9tuUkAZw2Tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZA6BhQiTL0+adEMBD5DPDx0J/6ODDMmzTfAVgUirHZp8qPOJm19aqk6ahj+u327ch kBQEu4nm0hPNqccOeQla9JFlt7WNYEFmoz+cjCl8n8y+abVF81nsK6YKI28MxNIFqc 3lG+g9065tJzAc+geqyCnQMdD68vp7HBKshTg2YPoGoVM9rNhyV123ecYjtg880f6C pvHLoCQ3rYKMyT+a0hYHfcayji+IsdwCpZzyot0S5NxpjS/M3Amqz/c19sgY05AOb9 oYqWMlSAR1ecCq6Km0/8iv+xD8jjbMZpeN5IrAzwj64+3B5IJhtjTWUUNFPv1ARaLw ZigO6j24fkkew== Date: Thu, 20 Nov 2025 14:04:17 -0700 From: Keith Busch To: Thomas ten Cate Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: "controller is down; will reset" on SK Hynix NVMe drive in Lenovo IdeaPad Pro 5 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Nov 20, 2025 at 02:52:22PM +0100, Thomas ten Cate wrote: > On Tue, Nov 18, 2025 at 9:49 PM Keith Busch wrote: > > > > The "report a bug" message was originally pointed at hardware vendors > > rather than kernel. Something is wrong with the SSD, the PCIe slot, or > > both if the power features cause the endpoint to drop off the bus. The > > only recourse we have in the nvme driver is a quirk to disable APST for > > the device. The driver doesn't control the PCIe ASPM settings though, so > > that would have to be a different quirk if it's really necessary. Do you > > need all three of those parameters, or is disabling the nvme driver's > > apst sufficient on its own? These parameters do have a negative impact > > on your machine's power consumption, so you'd usually want to hone in if > > it's just the deepest power state or if every power saving feature > > really needs to be disabled. > > Thanks for your reply! > > Just `nvme_core.default_ps_max_latency_us=0` appears to be sufficient, > so presumably it's the drive, not the bus. I wouldn't even know where > to begin reporting a bug to the manufacturer. I assume vendor 0x1c5c for SK Hynix, but we also need the device id to make a quirk. You can get that info from sysfs, for example if your device is enumerated as "nvme0": # cat /sys/class/nvme/nvme0/device/device There's two quirks we can try: NVME_QUIRK_NO_DEEPEST_PS first, then NVME_QUIRK_NO_APST if the first one wasn't successful.