From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB582C3244 for ; Thu, 20 Nov 2025 23:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763682038; cv=none; b=AQ+p8Mb5pKEGDfoeRQsCjPlV+xFQ5CbDdgd7wWFpJwcUHi7YVlGwHtyUjbRv9ASGgZvxGirUUefjO8jGKq7mSLYXziU5D+La1843vFStyIZNMEjIcqPJIMMuAv+UkpLqvkHKhfIe1Ej2w/PjWd3XSFrrcLQqOIO1w1EACFUiQEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763682038; c=relaxed/simple; bh=mYdfNS2P7JhMQ/kCLY5MBF1zL8mUzoPVYZB5PRLoDcc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GZTuvpCqAlIzFInj3f+jU6nqUhaNTIBQMZNADN0hq1LNN91ymX1+iEIUO8BqKuY+s0lJWMmMNPxHO0FTBEinP+9/I5tn7/3ptFORiYXWkIUp97nU6Muuxq/VmKw3hg2X82uSdQa5DzHriPcwdUtPs+pvB7xFoRoDtRniKFED6OA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Tj+S1K10; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Tj+S1K10" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-34188ba5990so4162858a91.0 for ; Thu, 20 Nov 2025 15:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763682037; x=1764286837; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Tz3mL4IK63e/6boEg0RIE/GfKvJh5AvynCJ73h5jjZE=; b=Tj+S1K10GWfBjlwecfXkffn9qeGRcaFmRC/kAV2mpez6FnDKAjGy7rgmG5bYQRt6ba 7dRyNBJ42VllUw9bvYCszS+S+HNWhdqnJr9RMtuEKFfsjrXHLLRLE9CKzYikgdDJBAV6 qvyDvsQbT6USgmWuhwYZ0joTMplFIGyBsunGAaq2UnY6l7qIPO5c1TqgydDkSpuYhn55 YObXHcgFuO89fBWT5F+/gDtp+3lFJwaChECCG2534mybBjG4nBwTerOcDZ1PrChcPA2n wQAW4ZhC/lc1sCUUjNc0gLt/o1YLMvfOak56CEMPpyVZZcP71r8KA5PPpj/2d6qLeXr6 Ioow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763682037; x=1764286837; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tz3mL4IK63e/6boEg0RIE/GfKvJh5AvynCJ73h5jjZE=; b=rXw+XqE2J+yAyDttUtZ1CiqtWU7njy6XeMuhHFm9iZYqPDMlA2/LwKjSAfFwdJ5l6j vBa7XEEvxjVQHbTFeSMgT1mjp2MHyhnDy78mZ/4vcqLq1moT7hQyLQy8YLW/QYLtaCwe NKCmltZuZjhD57WWlhRl8yAtq3c7+5fPSni7Y5aRMs3KF3h7h2fs/xkOlGK/8xcmdrxV Fc9cpHPy9hgPLOuOindNoKddlvuIhm2spQMe77ny5xGIWWsVPNV9/mvyzEvxGjekY9aZ fy9aN/4Ei6oMXMJMtXWv8kRDurpk+sVVVC7t/AtHP8zkpVO0hznbFe/Z482sl29clLiD C/MA== X-Forwarded-Encrypted: i=1; AJvYcCXkKooqPPck8a1rmFYclcPAZ4uFok19ymDjCsCSDuC8YIZj0cJNJTQ1cJpIVSOOx/PYSoifISCpUmHHALI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/3NrkybB5MhdW9q7b6NVMc7puyZTXSNSaNS7+vHHJ7c54D092 eIKgfChsI+Bz316CFk173qGsiylf8z/A6wd0FkAKH8SZAOVUmcgTFQPC1alBP8VyJrHHVyZDSjB Q4VEn1w== X-Google-Smtp-Source: AGHT+IEJlKEX1Lo5fr2/obWefb+N5dv3yrF5mObJRdr6qksM1jS9DLvrx305SHZ64+9RjVmAhu+7VAo8ZiQ= X-Received: from pjst15.prod.google.com ([2002:a17:90b:18f:b0:340:a575:55db]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:268d:b0:336:9dcf:ed14 with SMTP id 98e67ed59e1d1-34733f2a40bmr258634a91.23.1763682036619; Thu, 20 Nov 2025 15:40:36 -0800 (PST) Date: Thu, 20 Nov 2025 15:40:35 -0800 In-Reply-To: <20251021074736.1324328-2-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251021074736.1324328-1-yosry.ahmed@linux.dev> <20251021074736.1324328-2-yosry.ahmed@linux.dev> Message-ID: Subject: Re: [PATCH v2 01/23] KVM: selftests: Minor improvements to asserts in test_vmx_nested_state() From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , Jim Mattson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Oct 21, 2025, Yosry Ahmed wrote: > Display the address as hex if the asserts for the vmxon_pa and vmcs12_pa > fail, and assert that the flags are 0 as expected. > > Reviewed-by: Jim Mattson > Signed-off-by: Yosry Ahmed > --- > .../selftests/kvm/x86/vmx_set_nested_state_test.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/x86/vmx_set_nested_state_test.c b/tools/testing/selftests/kvm/x86/vmx_set_nested_state_test.c > index 67a62a5a88951..c4c400d2824c1 100644 > --- a/tools/testing/selftests/kvm/x86/vmx_set_nested_state_test.c > +++ b/tools/testing/selftests/kvm/x86/vmx_set_nested_state_test.c > @@ -241,8 +241,14 @@ void test_vmx_nested_state(struct kvm_vcpu *vcpu) > TEST_ASSERT(state->size >= sizeof(*state) && state->size <= state_sz, > "Size must be between %ld and %d. The size returned was %d.", > sizeof(*state), state_sz, state->size); > - TEST_ASSERT(state->hdr.vmx.vmxon_pa == -1ull, "vmxon_pa must be -1ull."); > - TEST_ASSERT(state->hdr.vmx.vmcs12_pa == -1ull, "vmcs_pa must be -1ull."); > + TEST_ASSERT(state->hdr.vmx.vmxon_pa == -1ull, > + "vmxon_pa must be 0x%llx, but was 0x%llx", > + -1ull, state->hdr.vmx.vmxon_pa); > + TEST_ASSERT(state->hdr.vmx.vmcs12_pa == -1ull, > + "vmcs12_pa must be 0x%llx, but was 0x%llx", > + -1llu, state->hdr.vmx.vmcs12_pa); > + TEST_ASSERT(state->flags == 0, > + "Flags must be equal to 0, but was 0x%hx", state->flags); The error messages aren't adding a whole lot, why not just use TEST_ASSERT_EQ()?