From: Dan Carpenter <dan.carpenter@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] unwind: Fix signedness bug in unwind_deferred_request()
Date: Wed, 19 Nov 2025 11:10:43 +0300 [thread overview]
Message-ID: <aR17gxtrzOJnVNFq@stanley.mountain> (raw)
The "bit" value comes from "work->bit". It is set to -1 if we cancel
the work in unwind_deferred_cancel(). It needs to be signed because
we check for negative values. Change the type from unsigned long to int.
Fixes: 357eda2d7450 ("unwind deferred: Use SRCU unwind_deferred_task_work()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
kernel/unwind/deferred.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/unwind/deferred.c b/kernel/unwind/deferred.c
index a88fb481c4a3..8dc11e0d9374 100644
--- a/kernel/unwind/deferred.c
+++ b/kernel/unwind/deferred.c
@@ -232,8 +232,7 @@ int unwind_deferred_request(struct unwind_work *work, u64 *cookie)
struct unwind_task_info *info = ¤t->unwind_info;
int twa_mode = TWA_RESUME;
unsigned long old, bits;
- unsigned long bit;
- int ret;
+ int bit, ret;
*cookie = 0;
--
2.51.0
next reply other threads:[~2025-11-19 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 8:10 Dan Carpenter [this message]
2025-11-19 14:24 ` [PATCH] unwind: Fix signedness bug in unwind_deferred_request() Steven Rostedt
2025-11-19 17:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR17gxtrzOJnVNFq@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=jpoimboe@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox