From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A19E931A57F for ; Wed, 19 Nov 2025 07:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763536393; cv=none; b=hNMKZfB/DNmcPWXEEzg+yQruz2KuL8QfOQETX5sgarZ8PLLZ2u/HiFFLCY0ZAIdlcB/Fe7pj+BNXwTMqjDDRl6L29wgUq1GzkRV1AJfZERLlKzUUxNPn4ni1y4y4OOmN+KpgmfL+eyQ4s5AmZY+zAlzfYqfo/f9fxeNLIs50dQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763536393; c=relaxed/simple; bh=1k3b91TeAw0rzeU6aDRybMO0nK66XkCSomfBz/2p4/c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BUfMhmEMvuR3+CIBhkzVqtS2w5GARrY22E+H6CgGA8RTj/S4h2SUZGUO9LRI1wCJLp4AuFL+QFpn3vjlPKliGdmgeU7mjC5AtW0O+ohZy5wecaE6poqVqeAbskrtOTnqCIz5hIs7OuOXuqR9Une0p+aywc+sBx+B/z4dTLEKoZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BPA2nBzs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BPA2nBzs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81A60C19422; Wed, 19 Nov 2025 07:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763536393; bh=1k3b91TeAw0rzeU6aDRybMO0nK66XkCSomfBz/2p4/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BPA2nBzs0EQuHRPga+czJDN2TOO9kpazfniyGqFJxmNxnxfJwR5SurOBwHdtQQ2FK 3Tks6jG1OTjIr6lfWvlEuLWHouOCFg9iNUHUZa/MtonM+vzFTQHXZNoIBByrExM78l c7SEeT7cR1y7KWxPyUkTtFDvVvidoqnV1msIC00pABA2sFbXyWXafa4UJtSsf/HETL /jOhHTqJwYRyjeCHILkKsFf0gdocpw+Yk8EVZVYU8Jd0AkAZ2vse757aGXnjmVnl+I pG3ErNtARklGA27Ecgy9jNDA804XkfgHGjKSZabTXxlGN+mapPEeMIC7bEkv8KOk7D 8NjBVLxskNdMg== Date: Wed, 19 Nov 2025 09:13:05 +0200 From: Mike Rapoport To: Pratyush Yadav Cc: Andrew Morton , Alexander Graf , Pasha Tatashin , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] test_kho: always print restore status Message-ID: References: <20251118181046.23321-1-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251118181046.23321-1-pratyush@kernel.org> On Tue, Nov 18, 2025 at 07:10:45PM +0100, Pratyush Yadav wrote: > Currently the KHO test only prints a message on success, and remains > silent on failure. This makes it difficult to notice a failing test. A > failing test is usually more interesting than a successful one. > > Always print the test status after attempting restore. > > Signed-off-by: Pratyush Yadav Reviewed-by: Mike Rapoport (Microsoft) > --- > lib/test_kho.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/lib/test_kho.c b/lib/test_kho.c > index 85b60d87a50ad..47de562807955 100644 > --- a/lib/test_kho.c > +++ b/lib/test_kho.c > @@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys) > if (err) > return err; > > - pr_info("KHO restore succeeded\n"); > return 0; > } > > @@ -319,8 +318,15 @@ static int __init kho_test_init(void) > return 0; > > err = kho_retrieve_subtree(KHO_TEST_FDT, &fdt_phys); > - if (!err) > - return kho_test_restore(fdt_phys); > + if (!err) { > + err = kho_test_restore(fdt_phys); > + if (err) > + pr_err("KHO restore failed\n"); > + else > + pr_info("KHO restore succeeded\n"); > + > + return err; > + } > > if (err != -ENOENT) { > pr_warn("failed to retrieve %s FDT: %d\n", KHO_TEST_FDT, err); > > base-commit: f0bfdc2b69f5c600b88ee484c01b213712c63d94 > -- > 2.47.3 > -- Sincerely yours, Mike.