From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49132319608 for ; Wed, 19 Nov 2025 07:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763536395; cv=none; b=ZOIhgWHI0FrBuE9VGL1PGWD+UdNhaMzAJhxDGU6TleaeASOVPkmizC3wbmEt+SgapuuEu6hBnGXy9K4gIBxOzFXJVt0GDPwInCiIWfa1HxTRNyuCbb+gEfzZ6YKNmENSV69aYLtk8BmEoD+2oD2hwuOu1ZxscZa0NUaAptKYRus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763536395; c=relaxed/simple; bh=3ftyJeNEROOQRmpQz9ADffJrhoo3yBZl2kX9QuLh3Po=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Blnw3f0pF3p6YSTA49n2fpz17IAdvIibR9sZdGHuRDuynrZZWmzdvA7lgbDCAEnY0cI6CL2tKzTzJxv5F2cn9+Bu712/DgV1ucpauSYkaAuBAmPaheSVG6+BOZerbDRde0lmkrFfX795u0Nedx4u41z4TBj7HlsuY9xxMJ4SuyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VNCQ1oOS; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VNCQ1oOS" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47774d3536dso4520645e9.0 for ; Tue, 18 Nov 2025 23:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763536391; x=1764141191; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fEeop7THHC2Z4mZ+uFXO7gKPD1aZpuBWKQn9Nyzeq9c=; b=VNCQ1oOSyfLagq1iuX2ZH9B1+PsuW8CA3+dSAD7QIrJoY7dTluNQwbePanLXs99hS2 DYBLiq0L3dWsuObl5Q4Q+HEFVa3CzEMLV8UcwYaRJcaSJPfXMeFf30O7k+P6YR0RYXvv Bdvk+X8r+SrqZUfBdeDAMx4a2BZlRE+GbBZsPTLdrXHEjEVSnQ/Ezo4Tn63bVWvp1/v/ M84YKpJ/9hwJW7/66eah1yxoG88/+YeVv8sEXYHopxJvCFP9RZknJxmgSSsLhxxRO4Wt hB08t+jP6KrN97ODDwO8CTu+jjDNBRhjTIyEkfiOivt1NVA0g90yjZSxFlB+kMTksesL SOnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763536391; x=1764141191; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fEeop7THHC2Z4mZ+uFXO7gKPD1aZpuBWKQn9Nyzeq9c=; b=GfLLohxu9sZfVv/cUGsmv/xLpbnoHbtkZEhA73EJSXmYNRMOfEU2URibVCbfuzLUig +c+sDS3MlddPOsuQh7Uc+A4mdEUfpAKcBzBeWKtdBijTSFBk9r6kOdgpegdNeWsc4hZV brH9ur6CVvasQNqdWUTeRbH8NTDtlA5u7860CmZ8VM/2Cj1VkPYN6OhsUZrg/Ou+OQ0k G5+PBf6YwCsTbxoBHYUt5XG4sGa8SCNCzH3HYEp1R85eJYIACoMbyFnivDIXPViLuC9c /B76wI+f2Iw1mTtbcA7NHCOFnffW23vIxydGzJHI977LbXJLMqsm6CTETGhup0wHLns9 hDeQ== X-Forwarded-Encrypted: i=1; AJvYcCXkZDaQnN83xpYSrmWlxUrfMNA5ZseFhVlAJf7KNUO5JRx3qGwv9mmpZuX/8oOkJ1n7+AqMn8yf7I3h/ic=@vger.kernel.org X-Gm-Message-State: AOJu0YwAFvkfbIuhLEmtwPXQIe51NRy37fTSylyAsUlJq7YguGL9m1Tp hQRounD/KsAzRDI7I6vxvIqwjewE0gHJNDu2ucL0ck+9U+8dpeskCYNu9v2LFzud+5g= X-Gm-Gg: ASbGnctCvDhsVvwfEIW2sO6DpT5cxd2lkLSxX2emdOycOQZS+Yyp7tJcGbKFICyeZ0l bz8ndMDF8mu5W05qXzK722XoLh3a8ycyXzJ5sI9f3pIJ/mHVK7AXSmTvLoM3HaKu5F9ECnaDpRi OXA8VqNLEcIeDT+g/j8ezSjaxm70c8Fnlqtoz9rv5rw9yU3NhRnQgCaAZnHqK1n6Sk6Ch6u9CBI rPotP5EBYBgAp1F2gOQfaN/X7PR3hsAVdU3/a7hQnETwApPfP7vsTolvMr6D0yRS4JrmKwq+e2Y JWpUWHKdfiwHsW5K18Jf978s2gNy0fhfAVXnNlgZNKxsQ1Xlsgj+ybZeSFHiGiqVKErL4juQ2TL uAOaDT7zoZ20+3aHLZrrJ9KKGY0w1YPEASJFIaUx7CB2+rKfdym8mEvWEa+lXsLi9Ku08ZEHw8/ hgb340OYRsYo0kfOzGjAqOvD0VMUk= X-Google-Smtp-Source: AGHT+IFXU+nC9ZIeAepoDKLNINnFSoupsWUwJ82hsu4iGdnTOqFrq4RmnDZ9NA5coiMKgryDL2/Yvw== X-Received: by 2002:a05:600c:8b68:b0:475:d7fd:5c59 with SMTP id 5b1f17b1804b1-477b183de88mr11222795e9.16.1763536391552; Tue, 18 Nov 2025 23:13:11 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477b1037d32sm30368275e9.12.2025.11.18.23.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 23:13:11 -0800 (PST) Date: Wed, 19 Nov 2025 10:13:06 +0300 From: Dan Carpenter To: CL Wang Cc: Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] rtc: atcrtc100: Fix signedness bug in probe() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 19, 2025 at 10:35:23AM +0800, CL Wang wrote: > On Tue, Nov 18, 2025 at 01:48:56PM +0300, Dan Carpenter wrote: > > Hi Dan, > > Thank you for pointing out the issue and for providing the fix. > > You're absolutely correct that using an unsigned type for alarm_irq > prevents proper error handling when platform_get_irq() returns a > negative value. I will apply your patch and also review other return > value checks to ensure there are no similar issues elsewhere. > > Thank you again for your detailed review and suggestions. > You're welcome. These are just Smatch warnings. Nothing super major. https://github.com/error27/smatch https://github.com/error27/smatch/blob/master/Documentation/smatch.rst regards, dan carpenter