From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6172F60A7 for ; Wed, 19 Nov 2025 11:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763552220; cv=none; b=Jd9FVIWESMmcc+uS+J6872mCrXOz0No9QiV9PN9MLW/WzEgIw66nSktghxuB8TsJ8LBihHw5nuXO4xJrqwWz04Isxi9fDWpAsjdZVGFby+4sir8CR14+ZHITli/DQf8EbtL3N3L33f4SnnO9hRVi+7M5aLQsCaqT/S1dhlxmDUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763552220; c=relaxed/simple; bh=HEe8AlKbyrbex+A6CsUcwqdLVOWP1x9iesEZBUZLz4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UKT/shbk9yKYCshKy3Ch1jyecazTxTxoGJBOLLSB9vu3JTp0PHz4pTjew3E/t9CUMRCf9L7xanyf3vDOatdolU3gZoGVWMBucFVxd3kd0+dsAIxb5d1100XTIJ3xjlffg7MRnnnSn4xQfbhSzbs2k8/OfgtHI92ToOg4HIeVAOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k01IGSux; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k01IGSux" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477a1c28778so41013105e9.3 for ; Wed, 19 Nov 2025 03:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763552217; x=1764157017; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RaL6Q6a1Oa4RMEkF3Mz+hsRQDK/y2Ul63G+BJ3IdFOc=; b=k01IGSuxENBSuFc3lxvho5LZKoZxnBlV1IvxfqvsxBqdFFFMthJLFd3Nuh6DAp//uo GmcAbPSxdx8i0XGQUvS9N4Cl7R1Uj2ZfSjRCwHto6fcU2RNOrPdSu6zoSxgAY12Z3QI3 MZcdSml/BfD+k/ZIHo3f1uDff6npJ9L7Kja0tv+4vGaxHw97EFNN1P63uk6Xf7qY51pL nNYRvtX2LhlejWeAvXrx6i2ZIIJLL5zNidX4LBzn6m19OyiQPMXZSE01KwCX0WgRMZEI AKoeQITMFUUuTKt+kbaOT6gbM59tF0O1Td9/RBJ4oEf2byg95GdfS0q4kxvOXhiG2Sby /euQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763552217; x=1764157017; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RaL6Q6a1Oa4RMEkF3Mz+hsRQDK/y2Ul63G+BJ3IdFOc=; b=sKX1MXnX5hWd6uNXe4xxXTZCa79Naqcd2skqlbi/15ldDkjrEdQTKsGXiiByVLs2uv 7mMcDq0QiLEB40YY/MSRf8vspjKzABl4oZxRoO8Gm3dzUQ2OXXc5caVDF9+SkiZFONZ1 lrlMUaZg/IobzhG2NZnTfXmHOnCYDeNwyGDnGiAwaoogj0CC+FbqrVozkW5jsRvvx1yx 88gL1RbdTlERWGYA4N59pBK0YizzVqAGV6pRQwPNqB/aSRwMJkPXNB1T4E0THOl/mEGB ab0ZJ6WkzPvjOxnVYawz+QNwbsnp2CgvaUo+b4Xo47i7ONyTCVHoxJD/7dnrJC8M7ISU 9rWA== X-Forwarded-Encrypted: i=1; AJvYcCUs6KALeBdKucee9VGw1CuxQu6IxholL/ypLLPgQ0G9cXGJD71FhkrZg+/xg6rCx+bKh7vN1H51UTUf9A8=@vger.kernel.org X-Gm-Message-State: AOJu0YxLNrCGWLtQSjk4VheP6l5POXv/mrox3S5CgLxvZWVctYSDkYq7 pK8Om8baD+FOP28IDKbCcBkFUI+V4QsjJiNjEO50m+EXLt5RdoPpZv46rnonypPqpzU= X-Gm-Gg: ASbGncvPVveYUCcCFFbRMS3RULGVVqrl+JrPW2O1Ik5xyVCRRILHH+/eObTkBGWE2Ki wig/dw8gmVfxmKKO+gPp96yTFFe42O81BIUxOvXI0110edec7npMLIdNBu5W8r2IlDZV23XI6J6 RTjC6tcFc5NUTdc7JIzJcIKds5jAx2JFNDyi6sWDaHsVNnM8mXjvc/8Ubu5f+eiKQtyobFOL+4g HyIs0SEmTL5uH8h/f9onTygg2J/wjBQQpwgc1yYc8zuKuq1WB+eUDyYuwfi5CCvRI3t1xu9uu2m PPY744qCEouF2FTCfmeyl+M8fZRTyMm8Q/yS+z2XgVkvHWeMwztNPpRctMID9TaK8ikRH996ace ineREiNhBf1BlgabJhPPZGgEDZlRuAa2r6hkqTyU/DCRYEaMS1Uaji0LFv8zkHT8kIwX6YduWpt +/JaKRT9t1LvHr1BV2q/vLnf+6pqlb4kY972qCuQ== X-Google-Smtp-Source: AGHT+IGKzxpIxTQ09/24XQQfgBbswtyCPN9yb0OnwrHcCKGoBYyE+rS4RFO+foxKQf6JrZbxPtEmyw== X-Received: by 2002:a05:600c:630d:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-4778fea1becmr219679975e9.31.1763552212408; Wed, 19 Nov 2025 03:36:52 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477a9df8db3sm37495865e9.11.2025.11.19.03.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 03:36:51 -0800 (PST) Date: Wed, 19 Nov 2025 14:36:48 +0300 From: Dan Carpenter To: Artur Stupa Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: core: fix block comment style issues Message-ID: References: <20251119062701.38279-1-arthur.stupa@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251119062701.38279-1-arthur.stupa@gmail.com> On Tue, Nov 18, 2025 at 10:26:40PM -0800, Artur Stupa wrote: > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > index 027b2dd0a4b9..a5234fdbf984 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > @@ -133,8 +133,8 @@ u8 *rtw_set_ie(u8 *pbuf, > } > > /*---------------------------------------------------------------------------- > -index: the information element id index, limit is the limit for search > ------------------------------------------------------------------------------*/ > + * index: the information element id index, limit is the limit for search > + *--------------------------------------------------------------------------*/ We generally don't like these "****************" or "-----------------" lines. [ snip ] > @@ -1691,12 +1691,11 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len) > /* pmlmeext->bcn_delay_ratio[delay_ms] = (pmlmeext->bcn_delay_cnt[delay_ms] * 100) /pmlmeext->bcn_cnt; */ > > /* > - > - for (i = 0; i<9; i++) > - { > - pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]); > - } > -*/ > + * for (i = 0; i<9; i++) > + * { > + * pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]); > + * } > + */ Delete dead code. Don't reformat it. regards, dan carpenter