From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EA802FD1CF for ; Wed, 19 Nov 2025 16:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763571592; cv=none; b=B8Fq/RNoTTUuqPYSyoUYhpCSrzPm2KBb03xW2QWh+WQYyby6yEDfYCowKCH4SZcsIicOF1bskK2pzGblGuhHdQ4iwUhlzIJX4QxEW4rSJaiuqNE/vE9uuE+mxVr4lTw5Et2WIe340HsmdLY5us58hl20JG3viy0YAfyyM01rZGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763571592; c=relaxed/simple; bh=xS5qxIEhQE/rcMcGrccXTFhKakZG2p02Am37L+/aips=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nCPrP+Z21F2Nwm5NqICH4lJl5l5tpTIurKxTLZ0NjHw09oXzk5ZEqaoDkQ4734P79mHrBhNQdS4YKZeqr1D/9Ukwfz7qV1vp02A/7YHHPFNQuNJTeTrKW5eLaehiNUkTRtnX7Hzqn8WA2GEHVyuHNDYh86vx5oamfNoAmcFSuDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WmMEE7Ph; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WmMEE7Ph" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763571590; x=1795107590; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xS5qxIEhQE/rcMcGrccXTFhKakZG2p02Am37L+/aips=; b=WmMEE7PhT+hIjzYvwNMX8kHJjRYZBrrHnBxMK5RYfrzKDHHe9OSwarpJ 0qfItvBwJb3Qkk1/PEy3sPG7G1nw/Ce1P4P4Xjqe+h/00yiKwIpeVHUhT OogDQlq9lQRVilXIJqFshwDevIiLH84/DGuYNzlLEdiWeaz/QD/lCbw5F rpXYCJ5oaBvwkwvbriONuD9IyQpxEFLrIJNF+NHzsR8dixSnMoa8otPU4 tPehaxUPA8KyTgIAqMQiAd4wpuNnCx70JB3lrjgDpqmxt8KAduWmxNUz9 +mLIhyLZqDIYfRRXGJO7oHF3EXndjr25/Cdj2nn+ADwnmct9nT9bFH3Ck w==; X-CSE-ConnectionGUID: JeDm4RyqRO2/dzC38yJ0Aw== X-CSE-MsgGUID: JAx9iuM2Ss+jsuVYMAZ3Ow== X-IronPort-AV: E=McAfee;i="6800,10657,11618"; a="77087552" X-IronPort-AV: E=Sophos;i="6.19,315,1754982000"; d="scan'208";a="77087552" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2025 08:59:48 -0800 X-CSE-ConnectionGUID: sM5IshC+QYq190PDSueL7w== X-CSE-MsgGUID: qEMlAuYVQ4G8fh4kK+umGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,315,1754982000"; d="scan'208";a="191143635" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.245]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2025 08:59:46 -0800 Date: Wed, 19 Nov 2025 18:59:44 +0200 From: Andy Shevchenko To: Lee Jones Cc: Binbin Zhou , linux-kernel@vger.kernel.org, Chong Qiao Subject: Re: [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed resources Message-ID: References: <20251113162713.3143777-1-andriy.shevchenko@linux.intel.com> <20251113162713.3143777-2-andriy.shevchenko@linux.intel.com> <20251119164703.GU1949330@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251119164703.GU1949330@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Nov 19, 2025 at 04:47:03PM +0000, Lee Jones wrote: > On Thu, 13 Nov 2025, Andy Shevchenko wrote: > > > The mixing of managed and non-managed resources may lead to possible > > use-after-free bugs. In this driver the problematic part is the device > > functionality that may just have gone behind the functions back, e.g., > > when interrupt is being served. Fix this by switching to managed resources > > for PCI. > > > > Fixes: 91a3e1f5453a ("mfd: ls2kbmc: Check for devm_mfd_add_devices() failure") > > Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support") > > Reviewed-by: Binbin Zhou > > Signed-off-by: Andy Shevchenko > > --- > > drivers/mfd/ls2k-bmc-core.c | 28 +++++++--------------------- > > 1 file changed, 7 insertions(+), 21 deletions(-) > > Still doesn't apply. I'm getting lots of conflicts. > > What base are you on? Linux Next which includes your -fixes branch. You probably need to merge either it or v6.18-rc6 to the -next. Then the v1 will be okay to apply. The bottom line is that without doing that we will have conflicts either in Linux Next followed by merging by Linus or in your branches locally before going to the above mentioned. Another possibility is cherry-pick patches from -fixes to -next. And alternative is to wait for -rc1 and rebase this on top of and apply then. > % git --no-pager log --oneline drivers/mfd/ls2k-bmc-core.c > 3696ac1d0db2 mfd: ls2kbmc: Remove unneeded semicolon from ls2k_bmc_recover_pci_data() > d952bba3fbb5 mfd: ls2kbmc: Add Loongson-2K BMC reset function support > 0d64f6d1ffe9 mfd: ls2kbmc: Introduce Loongson-2K BMC core driver -- With Best Regards, Andy Shevchenko