public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Lee Jones <lee@kernel.org>, Mark Brown <broonie@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Maciej Strozek <mstrozek@opensource.cirrus.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH RFT/RFC] mfd: cs42l43: setup true links with software nodes
Date: Wed, 19 Nov 2025 13:26:53 +0000	[thread overview]
Message-ID: <aR3FnUNO4DyCdiLD@opensource.cirrus.com> (raw)
In-Reply-To: <CAMRc=MdXNXQhE9zi=i0x0yGCi0fKQNU8_tn2_Uy24TAhxG7BRA@mail.gmail.com>

On Wed, Nov 19, 2025 at 02:07:55PM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 19, 2025 at 1:53 PM Charles Keepax
> <ckeepax@opensource.cirrus.com> wrote:
> > On Wed, Nov 19, 2025 at 03:58:08AM -0800, Bartosz Golaszewski wrote:
> > > On Wed, 19 Nov 2025 12:24:09 +0100, Charles Keepax
> > > <ckeepax@opensource.cirrus.com> said:
> > > > On Wed, Nov 19, 2025 at 12:06:57PM +0100, Bartosz Golaszewski wrote:
> > > >> On Wed, Nov 19, 2025 at 11:58 AM Andy Shevchenko
> > Can we tackle this the other way around? Since there is only a
> > single fwnode for the device, can we find a way to get away with
> > a single software node for the device too?
> 
> I still don't understand what the software node that's already
> assigned to the SPI device is though? device_add_software_node()
> should work just fine if the only other firmware node the device has
> is the ACPI device node.

Its the software node we assigned to the first MFD cell, that one
succeeds but attaches itself to the ACPI node as a secondary.
When we get to the second cell we try to attach a new node but we
get the one from the first cell since they share an ACPI node.

I think as Andy pointed out though the first 4 patches in your
chain do loosely want we want. Previously, we used the name to
point to the actual pinctrl driver, your patches should let us
do that properly through the fwnode. So we can drop the pinctrl
swnode and just have the cs-gpios bit point at the actual fwnode
instead. I am trying to hack together a strawman but its failing
in a lightly odd way. Hopefully I can get that sorted fairly
soon and post, or I guess I could post a version earlier if you
wanted a look in the knowledge it still doesn't work?

Thanks,
Charles

  reply	other threads:[~2025-11-19 13:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19  9:10 [PATCH RFT/RFC] mfd: cs42l43: setup true links with software nodes Bartosz Golaszewski
2025-11-19  9:30 ` Charles Keepax
2025-11-19  9:35   ` Andy Shevchenko
2025-11-19  9:40   ` Bartosz Golaszewski
2025-11-19  9:57     ` Charles Keepax
2025-11-19 10:20       ` Bartosz Golaszewski
2025-11-19 10:38       ` Bartosz Golaszewski
2025-11-19 10:47         ` Charles Keepax
2025-11-19 10:50           ` Bartosz Golaszewski
2025-11-19 10:58             ` Andy Shevchenko
2025-11-19 11:06               ` Bartosz Golaszewski
2025-11-19 11:24                 ` Charles Keepax
2025-11-19 11:53                   ` Andy Shevchenko
2025-11-19 12:08                     ` Bartosz Golaszewski
2025-11-19 11:58                   ` Bartosz Golaszewski
2025-11-19 12:53                     ` Charles Keepax
2025-11-19 13:07                       ` Bartosz Golaszewski
2025-11-19 13:26                         ` Charles Keepax [this message]
2025-11-19 13:34                           ` Bartosz Golaszewski
2025-11-19 14:11                             ` Andy Shevchenko
2025-11-19 14:15                               ` Bartosz Golaszewski
2025-11-19 14:23                                 ` Andy Shevchenko
2025-11-19 14:30                                   ` Bartosz Golaszewski
2025-11-19 20:38                                     ` Andy Shevchenko
2025-11-20  9:12                                       ` Bartosz Golaszewski
2025-11-20  9:56                                         ` Andy Shevchenko
2025-11-20 12:33                                           ` Bartosz Golaszewski
2025-11-19 14:09                           ` Bartosz Golaszewski
2025-11-19 14:45                             ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR3FnUNO4DyCdiLD@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=p.zabel@pengutronix.de \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox