From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A40E19DF4D for ; Wed, 19 Nov 2025 18:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763578534; cv=none; b=pLwSvvi0LxkiaRisB8KUuWqCUH0vYBkxShS9dfG2mFqPYrAwo7g7k7s5VRKgOWpK2712UXOTtLS6nW0VdoF7aPvZhhMvJqeYl6yLfRCJRWVEnoxgUujiXAz61JmVN4L2kUA/mPSxDYrCLibkmY9XIY5xekicnosBfy1ilxQ5RKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763578534; c=relaxed/simple; bh=9v0djC3j4UdC0t5of+7eTF62EBu112vbh4SXSgoEENs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GxB3EiRRqL4Zo/aD/fKQ63fLvnitXlKJ5NAMMl7lRxB9zUWh3i79iBYvV4QnKOyHdZeAAE5lBhzVeHWp+xd/0cdnAiaJYcHOOeedFlN89/afphit3rpxXBsaEPrgIyrRa1ihLEFJxgKa8hp6HTIxUixyF21/H81IyVYGrPEnquY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f2y5Z6L+; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f2y5Z6L+" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-bc274b8b15bso13227a12.1 for ; Wed, 19 Nov 2025 10:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763578525; x=1764183325; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=edQ3lAhPLjZZSk1oSVWuvnsvYz+DEp4d1vNMqDu5ED0=; b=f2y5Z6L+kLyXRojnbWggFSxJmrU6qFh1ngJsga7teH3sIzPOFpaUXpg6my3r1GrT+h QYedur5evNIqg2Q9FC+BucBax8qGGC+tHKqaePdntEt5rJICcdXWHGhIrdrw0Vxinfib UsZHYviIGIR/jalPnc6lFmmDRfn4Yw7RtANSccMlOUE/0p1zcjft94WLO3gasEFpcdKz spVFOXGglIrBITjPBrnX9qvOy2nNRcj3CYc8O8TZIt0uRAKuyzkKif2w0pCadaLeotbp DkWZ2V6FjT75381Hw4nTQ4KBgbE/C74XdsZLiziZ3oW5p6GxO6Hi55X4tvcwpkq+vTd9 h/HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763578525; x=1764183325; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=edQ3lAhPLjZZSk1oSVWuvnsvYz+DEp4d1vNMqDu5ED0=; b=ChxXeUa/P5LxKOGBoCcwZ3m6riv2Lk43GEHdaBzdGDbMts0jdGOcwY9QUPqHSr2Y/p iMOTw7jaY9wMMzpjnUJM2L8ztmOjWHTmUwRrcuwZGCPt7R21Eia1R5g9g6EGAvCARf+t Dj5sIyHyd6gWLx0PVMuYUYoZnzOH1UCqkluogsnTyEW6qQxmQtI2tIchPb1jrhwtwNja 8ib8CX3WSmL9zhFZG8VlAMyezFpE685Uf1CPsyQ4l6G2sXUJT2bGKdiQTTKR2/mBQ+HJ Avfv2SUhtE3geGYttl2YSuC7UATS0iz8/SqbY5BicZIORcSqZ7B+k7IXLhc36AAjsOwh eBkg== X-Forwarded-Encrypted: i=1; AJvYcCXAzXFsuEBsQvLsgTEcb2xdmisFNT8dBpEZxflql8wula5vLWaPReohIQhSXc4j6SB/VoLRsm9RYZx3H/g=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5SZ56wur9BTGL06ZSf1yHllbK5A9WbDaT5RxnHOZNAsnwgpBa WUGuPMmXNjXK5scnIbZ4mJ5T12BWWCGFeW2+J5LX4Cjp+E4HBxFQD6K2 X-Gm-Gg: ASbGncsoALaSUd3Hv9fQNfRCPuPQjBwk/aUYK2QZnedBT+ZnRs/KNpe2H1AilIGKWra dIZBOVQEd2rtNmpeWDuouBPDUM9tTtuZnREVp86fWPygxAEKjgatUGbCeDDGXKjbJl7LLyHN7Do vNw5cUdDeRt1sOpoa0XztucSUN5rTPCr/v7GEWLS6zl6tfV/ShhnV8qFvc9/cv6hO8caGAu1zQu 1QptzZi79HqFdaAapndeUFrYNqyO3zZskMGOGn8GuRanmqpAFzPw7UUvgQfCYYtsa8asbnf6eQB 2yN1dpTO07AYVJhnOOo36BxNWzGo7kqyDZ44Fsoj1gb26Yn8sJn0DD/SqR3oEfmzlQ7yO/Un8H2 UxWr3Jvbda5pWYGQlIVcFrYsS3V6yjD1TZ8PsKBweAhO80aYYmzz6loZgPpLiyVXj0Kk0wJH4E2 T7KW/K1Gz7ueZvm4vbPWr4ZKqdHQThlqo94vjGw4AJZ+8= X-Google-Smtp-Source: AGHT+IGBQeqSMvGoivhKypewRSEuuSGzQM6EQybj3ad+ID5hnktZP2Z/3EF+i6z/IdXkB6hPA0OLmA== X-Received: by 2002:a05:7022:1e11:b0:119:e56b:c754 with SMTP id a92af1059eb24-11c9387cf19mr128055c88.25.1763578524596; Wed, 19 Nov 2025 10:55:24 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11c93e3e945sm323775c88.6.2025.11.19.10.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 10:55:23 -0800 (PST) Date: Wed, 19 Nov 2025 10:55:21 -0800 From: "Vishal Moola (Oracle)" To: Matthew Wilcox , Christoph Hellwig , linux-xfs@vger.kernel.org Cc: Biju Das , "akpm@linux-foundation.org" , "bpf@vger.kernel.org" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "urezki@gmail.com" Subject: Re: [PATCH v3 0/4] make vmalloc gfp flags usage more apparent Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 18, 2025 at 07:57:29PM +0000, Matthew Wilcox wrote: > On Tue, Nov 18, 2025 at 09:07:56AM -0800, Vishal Moola (Oracle) wrote: > > On Tue, Nov 18, 2025 at 04:14:01PM +0000, Biju Das wrote: > > > Hi All, > > > > > > I get below warning with today's next. Can you please suggest how to fix this warning? > > > > Thanks Biju. This has been fixed and will be in whenever Andrews tree > > gets merged again. > > I see: > > Unexpected gfp: 0x1000000 (__GFP_NOLOCKDEP). Fixing up to gfp: 0x2dc0 (GFP_KERNEL|__GFP_ZERO|__GFP_NOWARN). Fix your code! > > I suspect __GFP_NOLOCKDEP should also be permitted by vmalloc. As far as I can tell, theres only 1 caller of this. Christoph started using vmalloc for this xfs call in commit e2874632a621 ("xfs: use vmalloc instead of vm_map_area for buffer backing memory"). Looks like xfs uses the flag to prevent false positives. Do we want to continue this? If so, I'll send a patch adding the flag to the whitelist.