Re: [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code

Jason A. Donenfeld
2025-11-18T16:57:51Z

On Tue, Nov 18, 2025 at 04:15:20PM +0100, Jason A. Donenfeld wrote:
> On Wed, Nov 05, 2025 at 06:32:20PM +0000, Asbjørn Sloth Tønnesen wrote:
> > drivers/net/wireguard/netlink_gen.c | 77 +++++++++++++++++++++++++++++
> > drivers/net/wireguard/netlink_gen.h | 29 +++++++++++
> > create mode 100644 drivers/net/wireguard/netlink_gen.c
> > create mode 100644 drivers/net/wireguard/netlink_gen.h
> > +#include "netlink_gen.h"
> > +// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
> > +/* Do not edit directly, auto-generated from: */
> > +/* Documentation/netlink/specs/wireguard.yaml */
> > +/* YNL-GEN kernel source */
>
> Similar to what's happening in the tools/ynl/samples build system,
> instead of statically generating this, can you have this be generated at
> build time, and placed into a generated/ folder that doesn't get checked
> into git? I don't see the purpose of having to manually keep this in
> check?

Grep, for example, for PERLASM in the lib/crypto code. There's certainly
precedent for doing this.