Re: [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code

Asbjørn Sloth Tønnesen
2025-11-18T22:24:23Z

On 11/18/25 3:15 PM, Jason A. Donenfeld wrote:
> On Wed, Nov 05, 2025 at 06:32:20PM +0000, Asbjørn Sloth Tønnesen wrote:
>> drivers/net/wireguard/netlink_gen.c | 77 +++++++++++++++++++++++++++++
>> drivers/net/wireguard/netlink_gen.h | 29 +++++++++++
>> create mode 100644 drivers/net/wireguard/netlink_gen.c
>> create mode 100644 drivers/net/wireguard/netlink_gen.h
>> +#include "netlink_gen.h"
>> +// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
>> +/* Do not edit directly, auto-generated from: */
>> +/* Documentation/netlink/specs/wireguard.yaml */
>> +/* YNL-GEN kernel source */
>
> Similar to what's happening in the tools/ynl/samples build system,
> instead of statically generating this, can you have this be generated at
> build time, and placed into a generated/ folder that doesn't get checked
> into git? I don't see the purpose of having to manually keep this in
> check?
>
> (And if for some reason, you refuse to do that, it'd be very nice if the
> DO NOT EDIT header of the file also had the command that generated it,
> in case I need to regenerate it later and can't remember how it was
> done, because I didn't do it the first time, etc. Go's generated files
> usually follow this pattern.
>
> But anyway, I think I'd prefer, if it's possible, to just have this
> generated at compile time.)

The main value in having the generated kernel code in git, is that it can't
change accidentally, which makes it easy for patchwork to catch if output
changes without being a part of the commit.

I will leave it up to Donald and Jakub, if they want to allow these files to
be generated on-the-fly.

Alternatively, the generated files could be put under YNL in MAINTAINERS, so you
only maintain the spec, but not the generated output files.

I agree that there could be a note in the header about how to re-generate
the files, or just a link to the doc:

https://docs.kernel.org/userspace-api/netlink/intro-specs.html#generating-kernel-code

The easy to use regeneration tool is ynl-regen:
./tools/net/ynl/ynl-regen.sh # skip if output is newer than yaml
./tools/net/ynl/ynl-regen.sh -f # force, when working on ynl
./tools/net/ynl/ynl-regen.sh -p drivers/net/wireguard # run on a subdir