Re: [PATCH net-next v3 11/11] wireguard: netlink: generate netlink code

Jason A. Donenfeld
2025-11-18T15:15:25Z

On Wed, Nov 05, 2025 at 06:32:20PM +0000, Asbjørn Sloth Tønnesen wrote:
> drivers/net/wireguard/netlink_gen.c | 77 +++++++++++++++++++++++++++++
> drivers/net/wireguard/netlink_gen.h | 29 +++++++++++
> create mode 100644 drivers/net/wireguard/netlink_gen.c
> create mode 100644 drivers/net/wireguard/netlink_gen.h
> +#include "netlink_gen.h"
> +// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
> +/* Do not edit directly, auto-generated from: */
> +/* Documentation/netlink/specs/wireguard.yaml */
> +/* YNL-GEN kernel source */

Similar to what's happening in the tools/ynl/samples build system,
instead of statically generating this, can you have this be generated at
build time, and placed into a generated/ folder that doesn't get checked
into git? I don't see the purpose of having to manually keep this in
check?

(And if for some reason, you refuse to do that, it'd be very nice if the
DO NOT EDIT header of the file also had the command that generated it,
in case I need to regenerate it later and can't remember how it was
done, because I didn't do it the first time, etc. Go's generated files
usually follow this pattern.

But anyway, I think I'd prefer, if it's possible, to just have this
generated at compile time.)

Jason