From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D49782F6924 for ; Thu, 20 Nov 2025 10:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763635249; cv=none; b=ioGeevTUZB90+DOiVO0TDOhJ4jaMQr6VCd/PQP/EnoldnfErJZCCkpxv1LB5I1QkZ30v1VJNGxvqjRUOonQMQdf9acBjebyCiJb+OmHq4fehIP6h0Q/dwaE6tpzb53zvHbixAKSDfWP6hOBdeM98oNsbNBVgSBlfIdrkjN62pjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763635249; c=relaxed/simple; bh=GMGaMl35cl3gruJ8HZbaPkx02fFLqNZps5aRxMSFSqs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dce8XlltJ+01rEd4RtHJZ4hdx+gkUElv7kddr79Xwjp/3W5OUbJMHzP9benCMmjM394qg1LBzGVLK4Dw2Xh3pd6C2mSBcd21g8Sd6HU68A8pQvS4jAoc/k3ig4wrsCaRRKj7II1bgukwZYs+0a4VjR/2gvfyzi0+tEYmNiRyH1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ho4cmKZE; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ho4cmKZE" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4775895d69cso3177955e9.0 for ; Thu, 20 Nov 2025 02:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763635245; x=1764240045; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v3BqOZoEimTRi3GpSzrBhmLEUccNnU0BKieAJ20s1/s=; b=Ho4cmKZEYEs5qEJ7hqgyLnn5i5zGgeZk8tgnypak4Fx6jHmtwPqJNEDW9/5AhJuYpU UCQgcZ1EDdqeWOKFP53Mq8ip1ihftPxl1qgWiBbbL3hf/1ZUkTxefyuPXmRgvDIK97z8 zRno+PzDz33aMAgSd5dXRdr3G8fNU8lgHv9GjdkzzcuecClQ54KVQ09ZK7zd9+PXNnZv pxuWhJRQlE5yVEmvRaIamJSooBorUV3Jc5AEbgy9yFJ8/mdAC111J0C2L2bAyRcc1kz4 hT1z9imtyhMp3f/h7WQ80qwtI3C911ruaznWlIFWuSgRasIaPDFG1QWiUDhtJGZWgfjE NooA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763635245; x=1764240045; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v3BqOZoEimTRi3GpSzrBhmLEUccNnU0BKieAJ20s1/s=; b=lKNJPggY5HdYL47N/ptE2wTQLbN/NABeeDiaVdjhbtVu+9/9OMSJDvkZ6uNYOpD8vS GpKCSvvEFEtr+0M42nrGQH9z7PrMIxl1BwNKJtWcdVXfARzHtRObe468yYILpiR5/k2n hfVAZpnI7UBOJrzVFLQhHCArsDddjbcJzKpUK4CXjM/lEGhFuitLuZPkymwfY4lbFflR wwDsE+KkxkwsnbkaLj3cyLzTH+DmzipomuWJAUW+D8DUrDPOQISmozfuu55AVMDPZeMX WWziHL1JCF/WOZdnUXS41hFEwX5QcXQI/X7gr3EznPuI+wSXZDtq0ZNapBpSclX+r2Um 8vlw== X-Forwarded-Encrypted: i=1; AJvYcCWHGGJvQD3/nzSM5lbNdWVA3hZOU9hvEl6Tj0QZFIeKZpYaf0MGCsR1NcKY/cU6BnXgihSFE9newcoReMw=@vger.kernel.org X-Gm-Message-State: AOJu0YzfMFDFLZPUdA/YfHN2b6VGPkk07h3KxbVxLDrL9QtosUPAlqXt NA7XdkvbjqtKDUUjvjJKcBx901v2FYvNDyulhGGJWazWeulVC96HaWMFoIAQ0HxK1xU= X-Gm-Gg: ASbGnct65zQJ+DOTGkUbnUJCc7fOUnMBG6zJHVvn4qgIuhsYWKD0DTgLyeKYYU64lvP pVlSk3NJJCRV/gJVA9tPIMFxbksXpBYRx+sNdWwdsmP05jisqJXUMhtuyvse1u035KNwMO+bcwd 85iRqfq3nE6QC3EHC2q0/NnsH5Uff/8F3N7au/GuunKyBPCnl5Rmu1m+fcbupJmQ/C3FDOlXV+q kSHXWmEjkxZ5fqKos+0C5QNrkBYNTkwZS4F6PUTn4/AYm1WwyiPP5Koy+ezjC3kaBpjSh5WHSO+ janRTHV9Ij3Tsx6SImeMXJ2Ds1A7pV5nDbpXVko8MdHJ1t4Ec2YNlmJjhzo3xRsyzpS0h9apTjJ rghut9zPrmoCXOevBVKW7cIU63lEvJSl7JIlZxhUawDFPqYRJrltl9/MW5VHu8oJGd4I9s55Okk 5YIFS9Kok008JMmpMc1z98QAhS7ss= X-Google-Smtp-Source: AGHT+IHty/HuzjLu9/WiPra12LT7uQxImJV4/vZ/HDU+/SS0ZeHyPK3dtYV4plPez1Cm946YXnrlfQ== X-Received: by 2002:a05:600c:1d20:b0:477:7b30:a6fc with SMTP id 5b1f17b1804b1-477b8aa06f6mr34821545e9.30.1763635244976; Thu, 20 Nov 2025 02:40:44 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477b8314279sm41631245e9.11.2025.11.20.02.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 02:40:44 -0800 (PST) Date: Thu, 20 Nov 2025 10:22:35 +0300 From: Dan Carpenter To: Artur Stupa Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: core: fix block comment style issues Message-ID: References: <20251119062701.38279-1-arthur.stupa@gmail.com> <20251120002948.23153-1-arthur.stupa@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251120002948.23153-1-arthur.stupa@gmail.com> On Wed, Nov 19, 2025 at 04:29:21PM -0800, Artur Stupa wrote: > +/* > + ********************************************************************** I was going to ignore this ************** line, but > + * Routine: Phase 1 -- generate P1K, given TA, TK, IV32 > + * > + * Inputs: > + * tk[] = temporal key [128 bits] > + * ta[] = transmitter's MAC address [ 48 bits] > + * iv32 = upper 32 bits of IV [ 32 bits] > + * Output: > + * p1k[] = Phase 1 key [ 80 bits] > + * > + * Note: > + * This function only needs to be called every 2**16 packets, > + * although in theory it could be called every packet. > + * > + ********************************************************************** > + */ > static void phase1(u16 *p1k, const u8 *tk, const u8 *ta, u32 iv32) > { > signed int i; [ snip ] > diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c > index d1f6030799cb..2014998245db 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c > +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c > @@ -385,10 +385,10 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta) > rtw_release_macid(pstapriv->padapter, psta); > > /* > - spin_lock_bh(&pstapriv->asoc_list_lock); > - list_del_init(&psta->asoc_list); > - spin_unlock_bh(&pstapriv->asoc_list_lock); > -*/ > + * spin_lock_bh(&pstapriv->asoc_list_lock); > + * list_del_init(&psta->asoc_list); > + * spin_unlock_bh(&pstapriv->asoc_list_lock); > + */ I had to complain about this. Please, delete commented out code. To be honest, it would be better to break this up into two patches, one which deletes dead code and the other which changes the comment formats. I wouldn't have said anything about that if it hadn't been for this dead code. regards, dan carpenter