Re: [PATCH v3] mm/memory hotplug/unplug: Optimize zone->contiguous update when move pfn range

Li, Tianyou
2025-12-01T12:28:26Z

Thanks David for your time to review.

On 11/29/2025 12:04 AM, David Hildenbrand (Red Hat) wrote:
>>
>> Instead of a bool value, could the clear_zone_contiguous_for_growing
>> and clear_zone_contiguous_for_shrinking return a enum value to indicate
>> one of the three states: 1. DEFINITELY_CONTIGUOUS;
>> 2. DEFINITELY_NOT_CONTIGUOUS; 3. UNDETERMINED_CONTIGUOUS? The
>> set_zone_contiguous took the state and skip the contiguous check if
>> DEFINITELY_CONTIGUOUS or DEFINITELY_NOT_CONTIGUOUS.
>
> I had the exact same thought while writing my rely, so it's worth
> investigating.
>
> If that helps to come up with even better+descriptive
> variable/function names, even better :)
>

I've created a patch v4 for review in a new thread as previously
suggested, Yuan Liu added the test result for memory plug and unplug.
Welcome for any comments or suggestions. Appreciated.

Regards,

Tianyou