From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stuart Yoder <stuart.yoder@arm.com>
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
sudeep.holla@arm.com, Prachotan.Bathi@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_crb: add missing loc parameter to kerneldoc
Date: Sun, 9 Nov 2025 06:41:41 +0200 [thread overview]
Message-ID: <aRAbhXdsupKGtDIP@kernel.org> (raw)
In-Reply-To: <20251028020921.214189-1-stuart.yoder@arm.com>
On Mon, Oct 27, 2025 at 09:09:21PM -0500, Stuart Yoder wrote:
> Update the kerneldoc parameter definitions for __crb_go_idle
> and __crb_cmd_ready to include the loc parameter.
>
> Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
> ---
> drivers/char/tpm/tpm_crb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
> index c75a531cfb98..0eb48429f73d 100644
> --- a/drivers/char/tpm/tpm_crb.c
> +++ b/drivers/char/tpm/tpm_crb.c
> @@ -179,6 +179,7 @@ static int crb_try_pluton_doorbell(struct crb_priv *priv, bool wait_for_complete
> *
> * @dev: crb device
> * @priv: crb private data
> + * @loc: locality
> *
> * Write CRB_CTRL_REQ_GO_IDLE to TPM_CRB_CTRL_REQ
> * The device should respond within TIMEOUT_C by clearing the bit.
> @@ -233,6 +234,7 @@ static int crb_go_idle(struct tpm_chip *chip)
> *
> * @dev: crb device
> * @priv: crb private data
> + * @loc: locality
> *
> * Write CRB_CTRL_REQ_CMD_READY to TPM_CRB_CTRL_REQ
> * and poll till the device acknowledge it by clearing the bit.
> --
> 2.34.1
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
prev parent reply other threads:[~2025-11-09 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 2:09 [PATCH] tpm_crb: add missing loc parameter to kerneldoc Stuart Yoder
2025-11-09 4:41 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRAbhXdsupKGtDIP@kernel.org \
--to=jarkko@kernel.org \
--cc=Prachotan.Bathi@arm.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stuart.yoder@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox