Re: [PATCH] lib/test_kho: Check if KHO is enabled

Pratyush Yadav
2025-11-07T10:24:58Z

On Thu, Nov 06 2025, Pasha Tatashin wrote:

> We must check whether KHO is enabled prior to issuing KHO commands,
> otherwise KHO internal data structures are not initialized.

Should we have this check in the KHO APIs instead? This check is easy
enough to miss.

>
> Fixes: b753522bed0b ("kho: add test for kexec handover")
>

Nit: these blank lines would probably mess up trailer parsing for
tooling.

> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202511061629.e242724-lkp@intel.com
>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> ---
> lib/test_kho.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/test_kho.c b/lib/test_kho.c
> index 025ea251a186..85b60d87a50a 100644
> --- a/lib/test_kho.c
> +++ b/lib/test_kho.c
> @@ -315,6 +315,9 @@ static int __init kho_test_init(void)
> phys_addr_t fdt_phys;
> int err;
>
> + if (!kho_is_enabled())
> + return 0;
> +
> err = kho_retrieve_subtree(KHO_TEST_FDT, &fdt_phys);
> if (!err)
> return kho_test_restore(fdt_phys);

--
Regards,
Pratyush Yadav