From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Duoming Zhou <duoming@zju.edu.cn>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com, kuba@kernel.org,
alexander.deucher@amd.com, pali@kernel.org,
hverkuil+cisco@kernel.org, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@kernel.org,
Jonathan.Cameron@huawei.com
Subject: Re: [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve workqueue synchronization
Date: Sun, 9 Nov 2025 18:13:38 +0200 [thread overview]
Message-ID: <aRC9spWVq43qJWRj@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1762604516.git.duoming@zju.edu.cn>
On Sat, Nov 08, 2025 at 08:40:03PM +0800, Duoming Zhou wrote:
> This patch series addresses use-after-free bugs in the ALPS
> touchpad driver and enhances workqueue handling efficiency
> in the psmouse subsystem.
>
> The first patch fixes a critical use-after-free race condition
> in the ALPS driver where dev3_register_work could be scheduled
> after the alps_data structure was already freed. This was caused
> by insufficient synchronization during device disconnection,
> where flush_workqueue() couldn't prevent subsequent work item
> submissions.
>
> The second patch optimizes the psmouse disconnect path by replacing
> flush_workqueue() with disable_delayed_work_sync() for better
> efficiency and robustness.
You forgot two things:
1) make it v2 (run `git format-patch -v<X> ...` where <X> is the version);
2) changelog.
No need to resend (unless requested by the maintainer), just reply with the
missed changelog for now.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-09 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 12:40 [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve workqueue synchronization Duoming Zhou
2025-11-08 12:40 ` [PATCH 1/2] Input: alps - fix use-after-free bugs caused by dev3_register_work Duoming Zhou
2025-11-08 12:40 ` [PATCH 2/2] Input: psmouse - Replace flush_workqueue() with disable_delayed_work_sync() Duoming Zhou
2025-11-09 16:13 ` Andy Shevchenko [this message]
2025-11-10 1:39 ` [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve workqueue synchronization duoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRC9spWVq43qJWRj@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=dmitry.torokhov@gmail.com \
--cc=duoming@zju.edu.cn \
--cc=hverkuil+cisco@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pali@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox