From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ma Ke <make24@iscas.ac.cn>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v4 1/2] iio: trigger: add missing mutex_destroy in iio_trig_release
Date: Mon, 10 Nov 2025 07:26:22 +0200 [thread overview]
Message-ID: <aRF3fokq4u0-JYd9@smile.fi.intel.com> (raw)
In-Reply-To: <20251110035701.36691-1-make24@iscas.ac.cn>
On Mon, Nov 10, 2025 at 11:57:01AM +0800, Ma Ke wrote:
> Add missing mutex_destroy() call in iio_trig_release() to properly
> clean up the mutex initialized in viio_trigger_alloc(). Ensure proper
> resource cleanup and follows kernel practices.
>
> Found by code review.
First of all, the patches should form the series and include a cover letter,
usually it can be done by running
git format-patch -v<X> --cover-letter --base ...
against the branch where changes are located on top of.
Then, here makes sense to add
Suggested-by:: Andy Shevchenko <andriy.shevchenko@intel.com>
The change otherwise LGTM (no need to resend this time),
Reviewed-by:: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-10 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 3:57 [PATCH v4 1/2] iio: trigger: add missing mutex_destroy in iio_trig_release Ma Ke
2025-11-10 5:26 ` Andy Shevchenko [this message]
2025-11-10 14:50 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRF3fokq4u0-JYd9@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox