From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B2327280B for ; Mon, 10 Nov 2025 11:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762774450; cv=none; b=SbMwt0jiE3nB+6OGhHqO2rpI/oJbzpdwtyZB+eVPSygVlT3OC6fzAJf6m4DHVYcVsGt1qVu/O5FzHSocb/sUd0VkRyD6we6ftrRmv3nVgsqALaBIOocoV22oBpAWnmc156EYrTS9gj3ou+Bl9FuGC4ya5oQuvbt0O9soLUdFqUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762774450; c=relaxed/simple; bh=NfYoubvx1j/f7MW8Zs391OvlNHrm1NUlNfB/mJfNitw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KcLbahT+vj/TO5E5uXp77h6wdPrIB1KRv0uOR5D9zcGWwJ7oxyA1UcTs85gZy09TYwmMH6nDMkAQl+ukhODV6Z3h6fmLk4IxLbn5v/KmpZ52RNk08iTHTobGWrz1WyT8imUzo9FTRBYz8V58wJ3/91ChxgopaX6lYLtgmqJiBPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vIQ9g-00022r-64; Mon, 10 Nov 2025 12:33:52 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vIQ9f-0080xM-2I; Mon, 10 Nov 2025 12:33:51 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vIQ9f-00CYGP-1u; Mon, 10 Nov 2025 12:33:51 +0100 Date: Mon, 10 Nov 2025 12:33:51 +0100 From: Michael Tretter To: yassine.ouaissa@allegrodvt.com Cc: Mauro Carvalho Chehab , Pengutronix Kernel Team , Michal Simek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Dufresne , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v5 2/4] dt-bindings: media: allegro: Add al300 decoder IPs Message-ID: Mail-Followup-To: Michael Tretter , yassine.ouaissa@allegrodvt.com, Mauro Carvalho Chehab , Pengutronix Kernel Team , Michal Simek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Dufresne , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley References: <20250813-allegro_dvt_al300_dec_driver-v5-0-a312ddebc4d8@allegrodvt.com> <20250813-allegro_dvt_al300_dec_driver-v5-2-a312ddebc4d8@allegrodvt.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250813-allegro_dvt_al300_dec_driver-v5-2-a312ddebc4d8@allegrodvt.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Wed, 13 Aug 2025 09:54:54 +0000, Yassine Ouaissa via B4 Relay wrote: > From: Yassine Ouaissa > > Add a schema for the allegro gen3 video decoder. > > Acked-by: Conor Dooley > Signed-off-by: Yassine Ouaissa > --- > .../bindings/media/allegro,al300-vdec.yaml | 76 ++++++++++++++++++++++ > MAINTAINERS | 2 + > 2 files changed, 78 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml b/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..12e86c306d5578d298ad03a6d59593dd1ddcff9e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/allegro,al300-vdec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allegro DVT Video IP Decoder Gen 3 > + > +maintainers: > + - Yassine OUAISSA > + > +description: > + The al300-vdec represents the gen 3 of Allegro DVT IP video > + decoding technology, offering significant advancements over its > + predecessors. This new decoder features enhanced processing capabilities > + with improved throughput and reduced latency. This reads more like marketing than a technical description. Maybe just stick to the first sentence: The al300-vdec represents the gen 3 of Allegro DVT IP video decoding technology. > + > + Communication between the host driver software and the MCU is implemented > + through a specialized mailbox interface mechanism. This mailbox system > + provides a structured channel for exchanging commands, parameters, and > + status information between the host CPU and the MCU controlling the codec > + engines. I'd focus the description on the hardware/MCP and drop anything referring to the host driver software. > + > +properties: > + compatible: > + const: allegro,al300-vdec > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: top > + - const: apb > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: MCU core clock > + maxItems: 1 > + > + memory-region: > + maxItems: 1 Please add a description explaining the purpose of the memory-region. > + > + firmware-name: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - clocks > + > +additionalProperties: False > + > +examples: > + - | > + #include > + > + axi { > + #address-cells = <2>; > + #size-cells = <2>; > + > + video-decoder@a0120000 { > + compatible = "allegro,al300-vdec"; > + reg = <0x00 0xa0120000 0x00 0x10000>, /*VDEC_TOP*/ > + <0x01 0x80000000 0x00 0x8000>; /*MCU_APB*/ Drop these comments. If the register maps need documentation, these should be a description in the binding above. > + reg-names = "top", "apb"; > + interrupts = ; > + clocks = <&mcu_core_clk>; > + memory-region = <&vdec_mem>; > + firmware-name = "al300_vdec.fw"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 88a76452956eb3b91e7813cbdc16c361f26216a5..532d8a51df9f500767f468935d960b1634139c65 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -819,7 +819,9 @@ M: Michael Tretter > R: Pengutronix Kernel Team > L: linux-media@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml > F: Documentation/devicetree/bindings/media/allegro,al5e.yaml > +F: drivers/media/platform/allegro-dvt/al300 > F: drivers/media/platform/allegro-dvt/zynqmp This feels a bit weird. You first change the maintenance to the zynqmp subdirectory and then add the al300 to the same maintainers entry. Either add yourself as maintainer for the al300 directory or just leave the maintainership on the top directory. Also, the al300 directory should be added with the actual driver. Michael