From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com,
andy@kernel.org, Michael.Hennerich@analog.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net,
cosmin.tanislav@analog.com, marcelo.schmitt1@gmail.com
Subject: Re: [PATCH v1 0/3] iio: adc: Add AD4134 minimum I/O support
Date: Mon, 10 Nov 2025 14:54:01 +0200 [thread overview]
Message-ID: <aRHgaXxxnD5YsIQQ@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1762777931.git.marcelo.schmitt@analog.com>
On Mon, Nov 10, 2025 at 09:44:56AM -0300, Marcelo Schmitt wrote:
> This patch series adds basic support for ad4134. AD4134 is a very flexible
> device that can be configured in many different ways. This series aims to
> support the simplest way of interfacing with AD4134 which is called minimum I/O
> mode in data sheet. This is essentially usual SPI with the addition of an ODR
> (Output Data Rate) GPIO which functions as conversion start signal in minimum
> I/O mode. The CS pin may be connected to a host controller CS pin or grounded.
>
> This set provides just one feature:
> - Single-shot ADC sample read.
>
> [PATCH 1] Device tree documentation for AD4134.
> [PATCH 2] IIO Linux driver for AD4134.
> [PATCH 3] Initial IIO documentation.
>
> There is a driver by Cosmin on ADI Linux tree that supports AD4134 in wiring
> configurations suited for high speed data transfers. Even though the minimum I/O
> support was initialy based on that high speed transfer driver, the result ended
> up becoming entirely different. Also, because the different wiring
> configurations are likely going to use different resources and software
> interfaces, the code for AD4134 support was split into ad4134-spi.c,
> ad4134-common.h, and ad4134-common.c.
The cover letter misses the answer to: "Why do we need a brand new driver?
Don't we have anything similar already in IIO that can be expanded to cover
this one?"
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-10 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 12:44 [PATCH v1 0/3] iio: adc: Add AD4134 minimum I/O support Marcelo Schmitt
2025-11-10 12:45 ` [PATCH v1 1/3] dt-bindings: iio: adc: Add AD4134 Marcelo Schmitt
2025-11-10 19:07 ` Conor Dooley
2025-11-13 21:56 ` Marcelo Schmitt
2025-11-14 1:43 ` Conor Dooley
2025-11-10 12:45 ` [PATCH v1 2/3] iio: adc: Initial support for AD4134 Marcelo Schmitt
2025-11-10 13:13 ` Andy Shevchenko
2025-11-11 21:11 ` Jonathan Cameron
2025-11-14 6:47 ` kernel test robot
2025-11-14 9:26 ` kernel test robot
2025-11-10 12:45 ` [PATCH v1 3/3] Docs: iio: Add AD4134 Marcelo Schmitt
2025-11-10 19:24 ` Randy Dunlap
2025-11-10 12:54 ` Andy Shevchenko [this message]
2025-11-10 15:43 ` [PATCH v1 0/3] iio: adc: Add AD4134 minimum I/O support Marcelo Schmitt
2025-11-10 14:48 ` Nuno Sá
2025-11-10 16:46 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRHgaXxxnD5YsIQQ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=cosmin.tanislav@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox