From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F705347BC4 for ; Tue, 11 Nov 2025 01:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762824318; cv=none; b=YaoSv0mzoBvU88i33ZWx42zzd90z1vBLzO5A3TjRU+ZdUwn/MUbxUNYDUW/+YehTWbYnXwgUruhFWEwrvAb/S+2Pq5wkO88CXJ1zc/QqwIQnFLcw35mWlDY64YCVy8pNuqeIW4MsX4fNIL/8lDftbbVxpXfOWueTT2OtjqegbGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762824318; c=relaxed/simple; bh=VG7yr5KtTWb6ZDQWVOimL1t5IglsNmLB3eZ+0cKlMec=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jq1byqeo1EyNQmfsOnfRc0iudtG6uQeOxRyRg34UPAy5GpCoClwgxcou7QjkBCwn8i+HwtBUjkcIfgauhDUDzKQbm6y3j/5V0dIydFTo+1B1k9sqYyVOCTCtgZzC2DcBCAp+oS0bflVoQzSuMlJH//KGKohSsO/mBE+EOD2Xn8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net; spf=none smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b=AhAlgsxo; arc=none smtp.client-ip=209.85.167.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b="AhAlgsxo" Received: by mail-oi1-f193.google.com with SMTP id 5614622812f47-44f9815f385so677345b6e.3 for ; Mon, 10 Nov 2025 17:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1762824316; x=1763429116; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=su1UwbZ4Pt+1NiFLASvdJqDu/6MFhpiYOP6WJzJr3rs=; b=AhAlgsxoCCzGlp4XNFihxJ+PrLMWNxhT57XNbvUKhytbZ9N1L6dHdDQNvX1b5NUAwz nNgDYBzBbk/JXudt++cH7gUR+7dlQSNilx9IezCjbRzwL2CUWwHj54cnZUYznB3BaPpZ k0eK+9zSqojhCtnwKj2SCvF1gY9ZdElB0kyxfR5lsueL3z04SxNgjbPGjEFwMSHmnTt5 onbI0CQN5Wp/payRFye+nY5Hv9SQtiBhiqeUE+2AGrQNEpKEqaGSdo8z1ZNmTh3I2oWv 08DsW434IMwrVhdj5pp093CH93HZQmKAGit0G0TKgMSs4Zuq+cpAJl+k4+VERYs2PqKz 49Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762824316; x=1763429116; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=su1UwbZ4Pt+1NiFLASvdJqDu/6MFhpiYOP6WJzJr3rs=; b=ZC2qd+jU43IgNOc6w9XslhFS2gisMO25cYSFWo1kOXXY6avhDmK+7xuFpYktFu/A0B /1uagFy8GhYo4fCPhh+ZUbs31Dn2VeD/EPnV/hMWVQ2p6/ZJX2/OpcQm5xTe1+4t9vsQ +FwJlpbeSWurJn0YVw/71TcnDGYOTJRhKZhGjEXBFou11uCTFKMdZ51B49eM6SV/0e3h QWWaa6t1pa4sGV7iywibMoUCCSUI3Msw8MmZWsfH/JfpaCHX5zS4UWugmarE/gaG51Lx D8K4FUrAoPud47OVT+DrUPEOX45HHlefT/wCjkSCeB0JXdEjQz1a+qylrN/pNT4FXMUT 4m/w== X-Gm-Message-State: AOJu0YySfO3+NP7K4WJefJ2nVzoAEJKOD+B/R5VCvglCjXgKQI3+OL4m fZRet/AcTbHccD2ryTZgmzcljODFBiloVfB2tc+27RI9p/3xiFqcQzu8trFfJSZUKlU= X-Gm-Gg: ASbGncth8te9JS78/DxiCSonig4RdXjGlgs8LUxLjXEf62Lh9EYEG+LOLdbq7k8n9fT KkmrUHrDWcnLbTeiErInHSv8o9vsWmjt25YaJ3kkBFRBtMRs/YQHiwGu6dDcOVAgAwgIRdXxumb 2aR6vCtoIZ29fBX99K6j05moHUU1he876BfE69oLrvu1wPrksgfVVRwzSmNdUdu+NlOZfIicn3Z J7HEO4aqi+4Ja2TdUYmScJe48pm/3bkI6Gpp5Ts8kx8eZeWqaG25PtUKJ+Fi15BeRSCggrXsxAv rrgl0vHIqOMKB78P1ePv58gV8x+XCpg6cjTg4DMU/EtsadhsDMjV+1iWx29y+rivwFxKOqKRkaP ltCQUm/0KHbmOGU1lgd42DtxRvD6UOL7ioO0dy0ldcQDPy3vkIiryWKpIlLDDjZQM3vmHgqHUD7 D5ZPhsVyHHDKWVgw== X-Google-Smtp-Source: AGHT+IE/jcIXzBpJuV8eEIsm7iQuqvWqvxk9u55a2Tz3m20gqxvO+0WNmYzTYKtJLoO18byZ0z0hSw== X-Received: by 2002:a05:6808:4497:b0:450:10b:a533 with SMTP id 5614622812f47-4502a36c9edmr4842796b6e.61.1762824316148; Mon, 10 Nov 2025 17:25:16 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:b4e9:19a3:cdaf:7174]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45002752ca9sm6359729b6e.14.2025.11.10.17.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 17:25:15 -0800 (PST) Date: Mon, 10 Nov 2025 19:25:10 -0600 From: Corey Minyard To: Bagas Sanjaya Cc: Linux Kernel Mailing List , Linux Documentation , openipmi-developer@lists.sourceforge.net, Jonathan Corbet , Mauro Carvalho Chehab Subject: Re: [PATCH] Documentation: ipmb: Indent boot time loading steps Message-ID: Reply-To: corey@minyard.net References: <20251105125449.45643-1-bagasdotme@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251105125449.45643-1-bagasdotme@gmail.com> On Wed, Nov 05, 2025 at 07:54:49PM +0700, Bagas Sanjaya wrote: > Steps for loading IPMB driver at boot time, written as enumerated > sublist, is indented instead on the same level as its parent list. > Indent them as appropriate. I'd like to get the review of the original author, now on the CC list. -corey > > Signed-off-by: Bagas Sanjaya > --- > Documentation/driver-api/ipmb.rst | 48 +++++++++++++++---------------- > 1 file changed, 24 insertions(+), 24 deletions(-) > > diff --git a/Documentation/driver-api/ipmb.rst b/Documentation/driver-api/ipmb.rst > index 209c49e051163f..dd99d034272b7e 100644 > --- a/Documentation/driver-api/ipmb.rst > +++ b/Documentation/driver-api/ipmb.rst > @@ -48,35 +48,35 @@ CONFIG_IPMB_DEVICE_INTERFACE=y > > 1) If you want the driver to be loaded at boot time: > > -a) Add this entry to your ACPI table, under the appropriate SMBus:: > + a) Add this entry to your ACPI table, under the appropriate SMBus:: > > - Device (SMB0) // Example SMBus host controller > - { > - Name (_HID, "") // Vendor-Specific HID > - Name (_UID, 0) // Unique ID of particular host controller > - : > - : > - Device (IPMB) > - { > - Name (_HID, "IPMB0001") // IPMB device interface > - Name (_UID, 0) // Unique device identifier > - } > - } > + Device (SMB0) // Example SMBus host controller > + { > + Name (_HID, "") // Vendor-Specific HID > + Name (_UID, 0) // Unique ID of particular host controller > + : > + : > + Device (IPMB) > + { > + Name (_HID, "IPMB0001") // IPMB device interface > + Name (_UID, 0) // Unique device identifier > + } > + } > > -b) Example for device tree:: > + b) Example for device tree:: > > - &i2c2 { > - status = "okay"; > + &i2c2 { > + status = "okay"; > > - ipmb@10 { > - compatible = "ipmb-dev"; > - reg = <0x10>; > - i2c-protocol; > - }; > - }; > + ipmb@10 { > + compatible = "ipmb-dev"; > + reg = <0x10>; > + i2c-protocol; > + }; > + }; > > -If xmit of data to be done using raw i2c block vs smbus > -then "i2c-protocol" needs to be defined as above. > + If xmit of data to be done using raw i2c block vs smbus > + then "i2c-protocol" needs to be defined as above. > > 2) Manually from Linux:: > > > base-commit: 27600b51fbc8b9a4eba18c8d88d7edb146605f3f > -- > An old man doll... just what I always wanted! - Clara >