From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279FE212F98 for ; Wed, 12 Nov 2025 19:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762975977; cv=none; b=G7wYneM5gqIizThTdg2lfPnUUcjKGqlULF21JQeLlT8sogsUyGYMS/6jPW2csy3+5R8ssxFlZEQceFLz6SioxLeYHjaKsRBsHwWiTCcvpselMxVERJRE6WJfQF0q63LCAMrAY5kP/fOkrcK5DjnM0sA8bxDPy1NAJbtJ3AYhQy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762975977; c=relaxed/simple; bh=SUUhDfoBmuPhmMw0GL7Ir4bt1svau2Ajo0eTYsuBFqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D5+ogWgNxYrLriIhcXbXl8bHZ4lRX3id5dh1G+WKp8BCLp0JHQ9JawaOefUNonYvcNs9bnjVA7A6F13wyrepnqxUUFVm4SFm7ys0m1gBPN36JJ8dobkGb2FLa+D8yVT3WdA4c5uf4WmmD2DrFZmOD4PSgiTjoaZOLKfEUgiovNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GDniVANR; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GDniVANR" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-63f95dc176fso1186390d50.1 for ; Wed, 12 Nov 2025 11:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762975974; x=1763580774; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lxubWASL3+7oeSYOF8cRfS3IaF1lf07GjfI/BFusVlo=; b=GDniVANRw7/JIpN8NxtyzRFIGwATa9A2zCRzT3AyV9bYUYVYwu524FQVWDldPls9Sy BpN03Dl612FtbGpNolRLv7VQcy21mEAgyRgKaz8iRgqv93oEknieZ6Y0/RngcZrd9SSC GZNx04VANDM2Cuu0mcyR6voyECGLmNbytUFhlpwNU2hwygi9A3MsbOmnK+GLqGblJC70 Y3ZU/AOVaaXFGaQcTxJx45VWlQd1jjjEUDnf2OPYE2bbqLo78IVe58YmFOwQytbkPRWF pfwpadEZKWx9TK1NMR2djxLbPfw4cn5kdJg3xSMPquTNqj/Yxa3mK++zs3NWcntr0n2w ageA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762975974; x=1763580774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lxubWASL3+7oeSYOF8cRfS3IaF1lf07GjfI/BFusVlo=; b=UVptX/qMBRHtVFqpI5DsJNQR7GOEkiJmMJi7EFCbTOmJl35r9+qXgPHEwQtbrnnIiV IVTfpIkPfpZ1/pqERJG7CeMR3jEsmqk7uRQytE9EfnHa5c7DMk+enurfueAOujbTt9Fc 8FaedJkXItxdKKLviQ65msrl0umL4TAeTbH66fC7xs7Sg1k63W8BvBbXkQeg3GGDcXlk YtH4V5gDPpA0CXk24xmnyl6NHEPifrmyLyOXgjKWBY/UMMVxj9zddZMK72OCVomYc5c8 lUk0ohdbugc4HdEoxFDwJXPXZ6vHBi0sE619o+yqLl0KL/tJ+7zOZQt2Nj1M21aOLy7e F4yA== X-Forwarded-Encrypted: i=1; AJvYcCUOPax9rB2PK3t5evhdC+eIzvZCAWWqrcOfPhJPL9fhzOU3gZGXLut6kq0EFreURe4V/a5eBM8kON3ekU8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp6w/vrt8bGia6MS8FHEy5lzMgGvraQWjtZsuqJN/8ip/wPOlE l9yPRvpw5s4fSpGy9ZRqkJ6P5BrsDNHtFAZVPfKoq35kqjEsiOI88rCk X-Gm-Gg: ASbGnctKj4BTe18FVWc6+5UZqn5geOvhT79xYoqi2H2i3OgIbWBFuBJ3gYa3GiavLGR ha8lOQseJbVaBYEPz55DuqMQFfK6UscyrYOTUrp3kiXLq5JTQA6eRkuL4nvYY01Wdc6AxUqrnsU Gzxp6fJdh/BAtrs2twC3mG145cxDCTGVyo+ZpE/0gc/WHv2J1ICQlmX20FPbd+6tXATjFmia5CZ z27+heQiZEBbsFSIHWwQDRmSVK5xUZyZDzUZhdNhLqzK9u41R6NSTgVBR86DLwBotRXjSRhF6hm IUji4nAlsGi82acNrxzSBeAa53wC18sQxE/LpC1HvYmk8DffD2Z2/o1MvgD6GsPntZuS5rS2YXD I3tQLkmUACGKOHPiGvNcr3C9ixOp5MKQMxGeeS3zk+XiL4tXQuSf/jbirFJzPKOmlec+KYoQXAB 4AyztHArsIRuenASc/Iz8oLhD2rJxx071r90mM X-Google-Smtp-Source: AGHT+IG4MyRZebV1Szufgtc9uf8er54fQt94boVEX+HeLHRTnsDHzaHu6bkb0vk12BKBHmbmHT/a7Q== X-Received: by 2002:a53:b10f:0:b0:63f:a818:6d34 with SMTP id 956f58d0204a3-64101b29733mr3157363d50.32.1762975973985; Wed, 12 Nov 2025 11:32:53 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:43::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-641015aece9sm1236185d50.3.2025.11.12.11.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 11:32:53 -0800 (PST) Date: Wed, 12 Nov 2025 11:32:51 -0800 From: Bobby Eshleman To: Stefano Garzarella Cc: Shuah Khan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, Sargun Dhillon , berrange@redhat.com, Bobby Eshleman Subject: Re: [PATCH net-next v9 03/14] vsock/virtio: add netns support to virtio transport and virtio common Message-ID: References: <20251111-vsock-vmtest-v9-0-852787a37bed@meta.com> <20251111-vsock-vmtest-v9-3-852787a37bed@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 12, 2025 at 06:39:22PM +0100, Stefano Garzarella wrote: > On Wed, Nov 12, 2025 at 08:13:50AM -0800, Bobby Eshleman wrote: > > On Wed, Nov 12, 2025 at 03:18:42PM +0100, Stefano Garzarella wrote: > > > On Tue, Nov 11, 2025 at 10:54:45PM -0800, Bobby Eshleman wrote: > > > > From: Bobby Eshleman [...] > > > If it simplifies, I think we can eventually merge all changes to transports > > > that depends on virtio_transport_common in a single commit. > > > IMO is better to have working commits than better split. > > > > That would be so much easier. Much of this patch is just me trying to > > find a way to keep total patch size reasonably small for review... if > > having them all in one commit is preferred then that makes life easier. > > > > The answer to all of the above is that I was just trying to make the > > virtio_common changes in one place, but not break bisect/build by > > failing to update the transport-level call sites. So the placeholder > > values are primarily there to compile. > > In theory, they should compile, but they should also properly behave. > > BTW I strongly believe that having separate commits is a great thing, but we > shouldn't take things to extremes and complicate our lives when things are > too closely related, as in this case. > > There is a clear dependency between these patches, so IMO, if the patch > doesn't become huge, it's better to have everything together. (I mean > between dependencies with virtio_transport_common). Sounds good, let's give the combined commit a go, I think the transport-specific pieces are small enough for it to not balloon? > What we could perhaps do is have an initial commit where you make the > changes, but the behavior remains unchanged (continue to use global > everywhere, as for virtio_transport.c in this patch), and then specific > commits to just enable support for local/global. > > Not sure if it's doable, but I'd like to remove the placeholders if > possibile. Let's discuss more about it if there are issues. Sounds good, I'll come back to this thread if the combined commit approach above balloons. For the combined commit, should the change log start at "Changes in v10" with any new changes, mention combining + links to the v9 patches that were combined? Best, Bobby