From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64DAD26E6EB for ; Thu, 13 Nov 2025 14:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763042777; cv=none; b=s3Fm7q6PV4m76pPRjU2K80yz2QooVVtyG+QLCUfloo5rng4gLI5jWiw41wsUlhSn0VjsgJ4fh1TF5Ev8YD2YyM604wPcQRQTk4+Fu8c8Izc9N89661ZaYe0DS8UI7pApRhL4l623YVUuy0hO5+99Ry2rXpw10uALHtXaLEu5bsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763042777; c=relaxed/simple; bh=nK8MVAuFtnwjDTKej3Wwkox0y6Sz4b5Ew5nLHAtDTk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DkOGyo92GhS8A4i2Tx3EG5oJ4rfs20koFaWlro1HSuRDmQy7DK8CHjYV0mCsBKL0/h8KRHM/pXyEN4On2GuyEdw+qxaMd3TTEIWg1oACvLWLJJUluNzqVX7to6xyEIlRBLIXhtUQob76HYaKW8oNLd+08nogFuGENUt6xIzRIIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YGJS330C; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YGJS330C" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47118259fd8so6289155e9.3 for ; Thu, 13 Nov 2025 06:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763042774; x=1763647574; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+fBsOlwKGvCQ9PsGreXfd2z/e8NXAroPl/lCt9m4U78=; b=YGJS330C1hnIzun0+YSph7MwVKDSqxwKzNoh4RwdpoDkpVJn953eu9HwZARWQFbPee Y4zlaBPSgsr4MU3u1q1aoMydjPZ5FY38KxeXt69mwUWKrCr4LGQiaoK4H4LcdthafSjA Nkt34sGuZWtmEPa63cQx+aLyEC5VAAWBz8RPtneLJA/hMrPYaZ6cGclSA3tauB+kWBxR wif9avmKBxNUaDTuTCK/1x1FSWjBpzWUPhC0a3qHB9MxZLmi5eV2wqske/HxkBxqQzcr nPUJwuVCz01uso0UU8mH8xY2ExKwXpe2d2os4Pk99Svct5QzdGH/Sqa/upbJF/t8MCDQ c9WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763042774; x=1763647574; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+fBsOlwKGvCQ9PsGreXfd2z/e8NXAroPl/lCt9m4U78=; b=ZpeXoroVMA/pucXJeQFFihHp34z4E4coR5p3ncSGTNTca1rfdUzYlgXSzTyIEsFWXJ JXdM/PhoCcGNTqrt5C5iMM8NkNSAEwaIC4bpCAU+xppOtceuqqJ2fQZjzzkekT/UM9l7 V9AyZFEA1cq8IJFWJttYPMd/2joL6TBlgPDxQKWIQH7r+bHEJqq4TMhbMPWBm8oj1AuD 0Q5tIVyrXiIRIuCl7fOQ2y6yIAk3DMhTO+KHM4HZPNNavj4K3jH+l8Bts4+0q/rJstWH 0Svi26R7M6dWdWdncwLPbKVk0BJPD0sBxGAqvtTaroHetkKXJIM5JCR/84Pn47UZUOxH qJPw== X-Forwarded-Encrypted: i=1; AJvYcCUItDq4d0Bc6E6a14pzgrAQbRKTxDk7NpccwTQpdidXJSi0KoEYady6JbD/tW7HWZPJiygz59V7cdTaUZc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2SQ66w7dlS/Unb53BLv++wv/p/Ncnd3bIRucsNoRMFiTJDea+ SSAU8/REa6EKkvCp05n3+RVRli5lg8Gdg8K54QUTLKPnI4DJ/Dy5sacH X-Gm-Gg: ASbGncuCTFsvLDevbXpomoVXH66L1goPEXJTlMSvq+qSs3Jl9KLisDKkV4+nEPg7e+8 TIptZOACB1cTFJ3JFgXayPN75fnJInO4XSIkAJfIItEGpfASVi8YfNacmPPbj7+iuKqffHR8dMk GaFxebxns+rcNLv3/hLGiaj7gf/s385L2bK4EQc60QfwnBlSIshK6DAMNEBa/FD0LAo2ZhlVDcF IV5C39BJ32hFSPpOHaVcVWasFQ9wTV4X6bHb34wLmFC0w55ALGwmKyxi/1jU+lxD4tgbIPSGxGN DdQm/unOx/YBqTmtFLnWdHDXpnF4VlnAEtPGAfJ6LuBhTSz6dzeUxvhOuEf5RYiEktDlc4eu467 IcPbyKUBV8tNL64/PmPVLIIw4M4VF3st4wKe1618txfTJBaNYL3R9hLGvJoXsi4Uc0GdekPHZcq +tXCG/Q/k0 X-Google-Smtp-Source: AGHT+IGUZx82/rO7Dbnk+No1GqhvJ0gfmQBea08lRQxmlKlDUu75KygUGkRVhWdZ43wtSDUahYjtnA== X-Received: by 2002:a05:600c:4f91:b0:477:54cd:202f with SMTP id 5b1f17b1804b1-4778707095emr70617955e9.3.1763042773366; Thu, 13 Nov 2025 06:06:13 -0800 (PST) Received: from fedora ([94.73.38.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778bcf051dsm21104525e9.3.2025.11.13.06.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 06:06:12 -0800 (PST) Date: Thu, 13 Nov 2025 15:06:10 +0100 From: =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= To: Louis Chauvet Cc: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jonathan Corbet , victoria@system76.com, sebastian.wick@redhat.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH RESEND v2 01/32] drm/drm_mode_config: Add helper to get plane type name Message-ID: References: <20251029-vkms-all-config-v2-0-a49a2d4cba26@bootlin.com> <20251029-vkms-all-config-v2-1-a49a2d4cba26@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251029-vkms-all-config-v2-1-a49a2d4cba26@bootlin.com> Hey Louis, On Wed, Oct 29, 2025 at 03:36:38PM +0100, Louis Chauvet wrote: > Create and export an helper to display plane type using the > property string. This could be used to display debug > information in VKMS. > > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/drm_mode_config.c | 13 +++++++++++++ > include/drm/drm_mode_config.h | 3 +++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > index 25f376869b3a..1a1a3f43db4d 100644 > --- a/drivers/gpu/drm/drm_mode_config.c > +++ b/drivers/gpu/drm/drm_mode_config.c > @@ -226,6 +226,19 @@ static const struct drm_prop_enum_list drm_plane_type_enum_list[] = { > { DRM_PLANE_TYPE_CURSOR, "Cursor" }, > }; > > +/** > + * drm_get_plane_type_name - return a string for plane name > + * @type: plane type to compute name of Maybe we could document here what happens when the plane type is not valid. Returns: The name of the plane type. "(unknown)" if type is not a known plane type. Other than that: Reviewed-by: José Expósito > + */ > +const char *drm_get_plane_type_name(enum drm_plane_type type) > +{ > + if (type < ARRAY_SIZE(drm_plane_type_enum_list)) > + return drm_plane_type_enum_list[type].name; > + else > + return "(unknown)"; > +} > +EXPORT_SYMBOL(drm_get_plane_type_name); > + > static int drm_mode_create_standard_properties(struct drm_device *dev) > { > struct drm_property *prop; > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index 2e848b816218..89f3dd46178d 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -30,6 +30,7 @@ > #include > > #include > +#include > > struct drm_file; > struct drm_device; > @@ -983,4 +984,6 @@ static inline int drm_mode_config_init(struct drm_device *dev) > void drm_mode_config_reset(struct drm_device *dev); > void drm_mode_config_cleanup(struct drm_device *dev); > > +const char *drm_get_plane_type_name(enum drm_plane_type type); > + > #endif > > -- > 2.51.0 >