From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D3E359708 for ; Thu, 13 Nov 2025 16:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763052862; cv=none; b=hQ466BWXOuiVSaeqY8c+WqMacn28tGzT/rb2rSk9kzG++cDskZGagW09000SLJ8NQHYhq+PvNarZpqwxO8cvZ/7glSoeFJL+zPT1eAcj+k+4DJh4Ukc9j2P7XGWbN8s+XGg4JZonInZDiQLE2Msw2m4X7c14vFl+VkJWpKKj5C4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763052862; c=relaxed/simple; bh=XQKSNRiFdFgqas04TlGNKyX+jgREILg+oYD/Bn1ut4U=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IFlvkwd6m17feyKp7UBWi6SRm/pQsoLQLqbPer1R/nWgp6x4Ce5hkV1ay0DN3cB+8DL70+fHFsaHB//Oj6FL5DhLeBvSJCYzsHppIW9ZClYuEVudASNv2zN0BRgLq6sibeUIZ7mhkrFM7wZ3oxy2L4XMDBXhvYEQhJAksCsA+Dg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tml3eyuq; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tml3eyuq" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-37b97e59520so8383641fa.2 for ; Thu, 13 Nov 2025 08:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763052859; x=1763657659; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=etMtDfwD+3QZuYUqVZKqjI6mrl2ackYWEvqoK5GuUAQ=; b=Tml3eyuqARHXMx1ms43GTMv6227HUrjlJhStI5PupcFKvWYJQpoc8NqUyQdXBR9cn9 pohSCVyddnZQFt9CuzWnrpAzJXJ/6WMaBWhteW0e/fWVzEYMVY18UZR2gE2KxOGTrEsy CZe1gzQaJ/vy+WUnqSiUc6rNK7c2VTWvZ+S2Qjqd8AzIUNsGJQz4gSdk9wi9G9ogDJgF KLBKjBkcD9Gsu9kQ6y1q0HUe5dj3ekDXIM2KFuc8sLYuFQeqoPb56CqedHSQqpLfrjpI JzkGvbXmclWmGHrM4ZQaetJ35jVSt4mDRywLuJA99C7+0wd0Y+SW8FIRLN0pbaqFpqtB 4hKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763052859; x=1763657659; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=etMtDfwD+3QZuYUqVZKqjI6mrl2ackYWEvqoK5GuUAQ=; b=GZ8247g4V8TNyyqVVs70TVmV/YiUdFFOdy61unGFtCWNUR7eqMT005K35Zex2wwbaF jDYKKOl/bnC802a5nLcHbI20UAND+xbC4Iks9mYoUCEG9cw71sbfABIk2wxtbCWpn9j7 bgsWGNcdrcJi6kTkoVFedb1596m/Bi8QWD+4PwSHdf6LnKc+J4e5adNWO7O+4KxCbT46 CBWGwl6oz44WiljYCUKplBIvru/h6MGsyjx4aJizXllVzlAHTBhlhivyKTV17ZcsKj1e FFERKFfAcsPlSJcP89PrmjrccZgh3PuApncCtjumH1jV4UHgSsBErIKVTXZ2GJU7ThQ8 1WAA== X-Forwarded-Encrypted: i=1; AJvYcCUsdK/CaSm0k5Q2+an/Zxvj45ruBOkjyTZgrPgKoLnOuSnZfM/zY1SL1vf77E0ZsWPBH8jlUMe+xb63GjI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1WJ3qF8Y0zkAOXBN1qQNDTKfs3oxyviACuiZsJdRZ1GRMffPP 0xMm6ck76Z6yLy+3PzT9HcCEaqmKBGShBNb6EJ6yBXufa4MzZ9K0J4I7i7R/1g5d X-Gm-Gg: ASbGncuT6cQNvuahx8TB0m3MMqkSVrb1NjLBnVMBCv4uMgMkVcY4dyI58Pv9DqfpiPz o9+Rtq4Gxi8vwuwjdipr0KmY0DvUq55pR9VikXF4SYlhWdOQCptYVvzTfkQNovbRWuB4uLZUPVf ENpqiErwaVI7KKi+ahd/8039keYcMx72xbW7fltYL5ocsz5IHcoedwIsCcgMWhecLsxXACJgmOd u2aHgqycmBb5LDO/1nbn22jC0DkfAbRB15n85Iw5MTG/4+RgoYnXjrk5zmSJWANWY5erjS/Mgl0 EyXxw96FN5/i65PGx836KKxqRvZGpwbTj+Cbf55c1+1Mp9fNiAjX6SJeE/UeFHL/nQe54TxNDjr 8g0VTWmR0RYsyPSNfdC2bGhYDlprjIjeYmzwgKFuDhoo= X-Google-Smtp-Source: AGHT+IEPT42mAJ6MUQqgjo5ZM8rlqgnxDoAaqQlhU3CiG0tihICqar5Ppn5XfbeoxErgayfhRkMTWw== X-Received: by 2002:a05:6512:b20:b0:594:35d5:9a1f with SMTP id 2adb3069b0e04-59584265411mr32340e87.50.1763052858346; Thu, 13 Nov 2025 08:54:18 -0800 (PST) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5958040576csm507458e87.88.2025.11.13.08.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 08:54:17 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 13 Nov 2025 17:54:16 +0100 To: "Vishal Moola (Oracle)" Cc: Uladzislau Rezki , akpm@linux-foundation.org, bpf@vger.kernel.org, hch@infradead.org, hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot@lists.linux.dev, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot ci] Re: make vmalloc gfp flags usage more apparent Message-ID: References: <20251112185834.32487-1-vishal.moola@gmail.com> <69158bb1.a70a0220.3124cb.001e.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 13, 2025 at 08:48:41AM -0800, Vishal Moola (Oracle) wrote: > On Thu, Nov 13, 2025 at 02:33:31PM +0100, Uladzislau Rezki wrote: > > On Wed, Nov 12, 2025 at 11:41:37PM -0800, syzbot ci wrote: > > > syzbot ci has tested the following series > > > > > > [v2] make vmalloc gfp flags usage more apparent > > > https://lore.kernel.org/all/20251112185834.32487-1-vishal.moola@gmail.com > > > * [PATCH v2 1/4] mm/vmalloc: warn on invalid vmalloc gfp flags > > > * [PATCH v2 2/4] mm/vmalloc: Add a helper to optimize vmalloc allocation gfps > > > * [PATCH v2 3/4] mm/vmalloc: cleanup large_gfp in vm_area_alloc_pages() > > > * [PATCH v2 4/4] mm/vmalloc: cleanup gfp flag use in new_vmap_block() > > > > > > and found the following issue: > > > WARNING: kmalloc bug in bpf_prog_alloc_no_stats > > > > > > Full report is available here: > > > https://ci.syzbot.org/series/46d6cb1a-188d-4ff5-8fab-9c58465d74d3 > > > > > > *** > > > > > > WARNING: kmalloc bug in bpf_prog_alloc_no_stats > > > > > > tree: linux-next > > > URL: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next > > > base: b179ce312bafcb8c68dc718e015aee79b7939ff0 > > > arch: amd64 > > > compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8 > > > config: https://ci.syzbot.org/builds/3449e2a5-35e0-4eac-86c6-97ca0ec741d7/config > > > > > > ------------[ cut here ]------------ > > > Unexpected gfp: 0x400000 (__GFP_ACCOUNT). Fixing up to gfp: 0xdc0 (GFP_KERNEL|__GFP_ZERO). Fix your code! > > > WARNING: mm/vmalloc.c:3938 at vmalloc_fix_flags+0x9c/0xe0, CPU#1: syz-executor/6079 > > > Modules linked in: > > > > > Again bpf :) > > > > GFP_KERNEL_ACCOUNT? I saw there have been __GFP_HARDWALL added already, > > IMO it is worth to replace it by "high level flag", which is GFP_USER. > > Yeah I'll replace __GFP_HARDWALL with GFP_USER, and add > GFP_KERNEL_ACCOUNT. At this point I'll just add GFP_NOFS and GFP_NOIO > as well so its easier to understand the mask. > Sounds good! -- Uladzislau Rezki