From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EC026E6E6 for ; Fri, 14 Nov 2025 09:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763113554; cv=none; b=WgqXyS27S3W82NWb4Xt/SlKzYs7JH0oUZiJaiWNHTB8q9QzzwtaG47DYUsM3ybaB9QRJ2IvUyVcrKJSWuEgm4mnUrIQg2Bl5ieuGqlVZYOfd+yS8YNztH83PxIBcgVa6IovQsYvWkBYT8oX/zlGR7Ff7aXa0qf6gh8AEd5UgBiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763113554; c=relaxed/simple; bh=/kl5VzyZECiIuXRcEWwFU4L2zs0VXuLrZzl76o6IuDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rru0RTCsFlAzTD7LWlR+Se6DEiwtpEZ76rbPSCF4RWJDj5Q1qrVv6x66GoduUleo256KetxV27rMe8KCQmobRdHZ0w7uTaFL00JTgwFTYrDMxtdi9Jk1lnwEsmSVrWkVCMSxu51VUAKioBMVZ1TwURFwvH2w6vqRZchYnhI1WOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=b6PTyYPH; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="b6PTyYPH" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-640a3317b89so2797673a12.0 for ; Fri, 14 Nov 2025 01:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763113550; x=1763718350; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iDVlfTVuqvoGEh3V26hRVb1+2UuAjPxNlr0fcPqAFq8=; b=b6PTyYPH/vqo7zChRrPXm7WZgvSvgCWPeHiu4VomA1lWCjUIHWOmyWAl3V3ZNfK8vI qgiMVK7mmxKRzGnpaqFcZie7jkHy5CfUgO6LuC//X7FG/oQC0UgH4XnANx21rQOFcAlM zIEzWDmCA05IV7FtGnGMxzblC0UjeMWgvPe0FwtEmcb6WT1bOjz1UtVwQemBp2upp1a5 8rSEamz0hC7I+LSG0+FtVH3SasPL5+DTq6BITXy60krPuVJaEFwrWPFOsKAOtk3deiWa zhVykjfCCkKPjdd1kpSrEuat1Gp7Xhilz3IGLhiNq+a1sHDGKpjhstjEWTaoxJZjEw38 UClA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763113550; x=1763718350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iDVlfTVuqvoGEh3V26hRVb1+2UuAjPxNlr0fcPqAFq8=; b=hd8zFn0LtC5iCNqx1y0TRc4XFPfaMBlkn6vqoVCW8grHqbPzvt15QlpvhttljpZHzZ xIlf2U0slqgJ0pvrUQSySsN1tSdi2KT4oQua7rp5mRnsarygjRAM95+me1gDA3s8tSL1 9kygisYHlylVRM1+70NhziVUbg9XnjF8o/+xHaQIYcb18Dlo7K/HHB2lhI1TRiPSYIY0 SVCW2JkDeRx20WiZ5e1l1M4cdtZ9aXb9glGu9oQhIl2QpHtzjCDrtqFUgEFAUV6V7GFP zRGUbaIDWshD22pP9T/Xq+3tFUP7UgFDs+zDFpCTJXYnBicm/mr9H3HbQuGb7NnLknSg RuQA== X-Gm-Message-State: AOJu0Yzp13x1f/aaCj+4OUiYCY9mIP3oC0vZEZMwUxGNkmjmE7wkRbS+ MYiRKFL9SKGLncRH0SZUOrWTiOTCdBZZOeRMzoKirc8MEes7TUxQina8b0OytB4tEtK6yrTEMwd /OT2V X-Gm-Gg: ASbGncvfJdYseZihW3AZremCMmCcBkptynDlp9T3XxcABEPJmNl576FEkC7WU6GN5z3 xWKfkr6d2PN3aUIZPYBb8RYdyt9yTxpnm8nOyuT9mRgKoLBUCFt3a1R9qSdqkR64w8grJp3BGtY 6hjLCkYZpQt2P29/6NF/iXoKlh3uY9jlgrwinWoIt7rAJmQsROThRq4h0bdEEeVCJlY3lcBtT4g Qo8hoQUFbfD7NIeB5VhCr3/xsxs768FrUjvhRtwAYS2fTGN/C+rzF2qR87oDQjI66QAk3W/EfrJ XjKdGjWWuq0Zj/FLDAgGf0vY/I0iS4rpavhLhtLWlMf1vr1ssc+TI7xmnt4TqWK4ZrB4lc/o6Z4 5uwrzVMQHlwSp8D57T2xG6EvdC/2fjt3uJG0UQ/HlmV/nCXpeaJAJyJU2T2snM1ExIkSDRjc3PX aNjE8= X-Google-Smtp-Source: AGHT+IHRhpXgkcIdH2WttdUqrIYoo5D4fvdLkKCNaZ0edjmdUclE3XAovGzQfCA/h1XsBG06jzZD5Q== X-Received: by 2002:a05:6402:40c6:b0:641:3d42:99b8 with SMTP id 4fb4d7f45d1cf-64350e1f1c7mr1964733a12.9.1763113549969; Fri, 14 Nov 2025 01:45:49 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a3d7335sm3321293a12.4.2025.11.14.01.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 01:45:49 -0800 (PST) Date: Fri, 14 Nov 2025 10:45:47 +0100 From: Petr Mladek To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton Subject: Re: [PATCH v2 1/1] lib/vsprintf: Deduplicate special hex number specifier data Message-ID: References: <20251113150313.3030700-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113150313.3030700-1-andriy.shevchenko@linux.intel.com> On Thu 2025-11-13 16:02:59, Andy Shevchenko wrote: > Two functions use the same specifier data for the special hex number. > Almost the same as the field width is calculated on the size of the > given type. Due to that, make a compound literal macro in order to > deduplicate the rest. > > Signed-off-by: Andy Shevchenko Looks good to me: Reviewed-by: Petr Mladek Tested-by: Petr Mladek I am going to wait few more days for potential feedback and push it next Wednesday or so if nobody complained. Best Regards, Petr