RE: [PATCH v3 20/21] scsi: snic: Switch to use %ptSp

Karan Tilak Kumar (kartilak)
2025-11-15T20:27:34Z

On Thursday, November 13, 2025 6:33 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/scsi/snic/snic_debugfs.c | 10 ++++------
> drivers/scsi/snic/snic_trc.c | 5 ++---
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/snic/snic_debugfs.c b/drivers/scsi/snic/snic_debugfs.c
> index 9dd975b36b5b..edf3e5ef28a6 100644
> --- a/drivers/scsi/snic/snic_debugfs.c
> +++ b/drivers/scsi/snic/snic_debugfs.c
> @@ -282,8 +282,8 @@ snic_stats_show(struct seq_file *sfp, void *data)
> jiffies_to_timespec64(stats->misc.last_ack_time, &last_ack_tms);
>
> seq_printf(sfp,
> - "Last ISR Time : %llu (%8llu.%09lu)\n"
> - "Last Ack Time : %llu (%8llu.%09lu)\n"
> + "Last ISR Time : %llu (%ptSp)\n"
> + "Last Ack Time : %llu (%ptSp)\n"
> "Ack ISRs : %llu\n"
> "IO Cmpl ISRs : %llu\n"
> "Err Notify ISRs : %llu\n"
> @@ -298,10 +298,8 @@ snic_stats_show(struct seq_file *sfp, void *data)
> "Queue Ramp Down : %lld\n"
> "Queue Last Queue Depth : %lld\n"
> "Target Not Ready : %lld\n",
> - (u64) stats->misc.last_isr_time,
> - last_isr_tms.tv_sec, last_isr_tms.tv_nsec,
> - (u64)stats->misc.last_ack_time,
> - last_ack_tms.tv_sec, last_ack_tms.tv_nsec,
> + (u64) stats->misc.last_isr_time, &last_isr_tms,
> + (u64) stats->misc.last_ack_time, &last_ack_tms,
> (u64) atomic64_read(&stats->misc.ack_isr_cnt),
> (u64) atomic64_read(&stats->misc.cmpl_isr_cnt),
> (u64) atomic64_read(&stats->misc.errnotify_isr_cnt),
> diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c
> index c2e5ab7e976c..6bad1ea9a6a7 100644
> --- a/drivers/scsi/snic/snic_trc.c
> +++ b/drivers/scsi/snic/snic_trc.c
> @@ -56,9 +56,8 @@ snic_fmt_trc_data(struct snic_trc_data *td, char *buf, int buf_sz)
> jiffies_to_timespec64(td->ts, &tmspec);
>
> len += snprintf(buf, buf_sz,
> - "%llu.%09lu %-25s %3d %4x %16llx %16llx %16llx %16llx %16llx\n",
> - tmspec.tv_sec,
> - tmspec.tv_nsec,
> + "%ptSp %-25s %3d %4x %16llx %16llx %16llx %16llx %16llx\n",
> + &tmspec,
> td->fn,
> td->hno,
> td->tag,
> --
> 2.50.1
>
>

Thanks for the change, Andy.

Acked-by: Karan Tilak Kumar <kartilak@cisco.com>

Regards,
Karan