Re: [PATCH v3 13/21] mmc: mmc_test: Switch to use %ptSp

Ulf Hansson
2025-11-17T11:01:15Z

On Thu, 13 Nov 2025 at 16:03, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
> drivers/mmc/core/mmc_test.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index a74089df4547..01d1e62c2ce7 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -586,14 +586,11 @@ static void mmc_test_print_avg_rate(struct mmc_test_card *test, uint64_t bytes,
> rate = mmc_test_rate(tot, &ts);
> iops = mmc_test_rate(count * 100, &ts); /* I/O ops per sec x 100 */
>
> - pr_info("%s: Transfer of %u x %u sectors (%u x %u%s KiB) took "
> - "%llu.%09u seconds (%u kB/s, %u KiB/s, "
> - "%u.%02u IOPS, sg_len %d)\n",
> - mmc_hostname(test->card->host), count, sectors, count,
> - sectors >> 1, (sectors & 1 ? ".5" : ""),
> - (u64)ts.tv_sec, (u32)ts.tv_nsec,
> - rate / 1000, rate / 1024, iops / 100, iops % 100,
> - test->area.sg_len);
> + pr_info("%s: Transfer of %u x %u sectors (%u x %u%s KiB) took %ptSp seconds (%u kB/s, %u KiB/s, %u.%02u IOPS, sg_len %d)\n",
> + mmc_hostname(test->card->host), count, sectors, count,
> + sectors >> 1, (sectors & 1 ? ".5" : ""), &ts,
> + rate / 1000, rate / 1024, iops / 100, iops % 100,
> + test->area.sg_len);
>
> mmc_test_save_transfer_result(test, count, sectors, ts, rate, iops);
> }
> @@ -3074,10 +3071,9 @@ static int mtf_test_show(struct seq_file *sf, void *data)
> seq_printf(sf, "Test %d: %d\n", gr->testcase + 1, gr->result);
>
> list_for_each_entry(tr, &gr->tr_lst, link) {
> - seq_printf(sf, "%u %d %llu.%09u %u %u.%02u\n",
> - tr->count, tr->sectors,
> - (u64)tr->ts.tv_sec, (u32)tr->ts.tv_nsec,
> - tr->rate, tr->iops / 100, tr->iops % 100);
> + seq_printf(sf, "%u %d %ptSp %u %u.%02u\n",
> + tr->count, tr->sectors, &tr->ts, tr->rate,
> + tr->iops / 100, tr->iops % 100);
> }
> }
>
> --
> 2.50.1
>