From: Johan Hovold <johan@kernel.org>
To: alejandroe1@geotab.com
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios" binding
Date: Fri, 14 Nov 2025 15:42:19 +0100 [thread overview]
Message-ID: <aRc_y_Sf8fhFm_K8@hovoldconsulting.com> (raw)
In-Reply-To: <20250911-ubx-safeboot-v3-1-32fe6b882a3c@geotab.com>
On Thu, Sep 11, 2025 at 02:58:28PM +0200, Alejandro Enrique via B4 Relay wrote:
> From: Alejandro Enrique <alejandroe1@geotab.com>
>
> U-Blox 8/M8/M9 chip have a pin to start it in safeboot mode, to be
> used to recover from situations where the flash content has become
> corrupted and needs to be restored. Introduce a binding to support
> this safeboot pin.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
> +allOf:
> + - $ref: gnss-common.yaml#
> + - $ref: /schemas/serial/serial-peripheral-props.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: u-blox,neo-6m
> + then:
> + properties:
> + safeboot-gpios: false
> +
I don't think it's worth adding conditionals like this for an optional
gpio as it just makes the binding harder to read for no good reason (cf.
a dt checker can't verify that you're not using the wrong host pin in
your identifier either).
So I used your v1 without this (and dropped Krzysztof's tag).
> unevaluatedProperties: false
>
> examples:
> @@ -65,5 +76,6 @@ examples:
> v-bckp-supply = <&gnss_v_bckp_reg>;
> vcc-supply = <&gnss_vcc_reg>;
> reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> + safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
> };
> };
Johan
next prev parent reply other threads:[~2025-11-14 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 12:58 [PATCH v3 0/2] Add support for safeboot pin to UBlox GNSS driver Alejandro Enrique via B4 Relay
2025-09-11 12:58 ` [PATCH v3 1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios" binding Alejandro Enrique via B4 Relay
2025-11-14 14:42 ` Johan Hovold [this message]
2025-09-11 12:58 ` [PATCH v3 2/2] gnss: ubx: add support for the safeboot gpio Alejandro Enrique via B4 Relay
2025-11-14 14:59 ` Johan Hovold
2025-11-17 16:33 ` Alejandro Enrique
2025-11-20 15:51 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRc_y_Sf8fhFm_K8@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alejandroe1@geotab.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox