From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4094119AD5C for ; Fri, 14 Nov 2025 13:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127770; cv=none; b=SG0wF8t0AQH1ICGkYgAXUh+O/vG+3vYP6SBWTgLAqhSVS0HATCMXo/h2JPShhcy5EqgOnywHGAsoj7T/P4G7Lj1i11r+AQt12jhwXlguURxQkN13vDe9uG9Y/w4fKPPwUlQtAhfvOdFHtamoZQfVtcgF1LIkmXpULiczfjyibVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127770; c=relaxed/simple; bh=X3mcG2vMwzimtVf21V3jtBMPOXzPKbZyCnkRy7OCEdM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DqshMSo4PK/LEye0shvgQKZomk/+wdW85FgfQds2aZx/gI7sI8yZTPdp9dFjQ/J44vnAEnV4k25b5sBUsGVXEhu7gl5at1dh5sQmc2IvbYIwVfefH5hExXMxT9zYTp1MMxsJp9Q2SGcp2ltOTZh9V2F0pyLziQImHlipPhij0bI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=G7ErAIfA; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="G7ErAIfA" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b725ead5800so248529066b.1 for ; Fri, 14 Nov 2025 05:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763127766; x=1763732566; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HuAu7Wso0jBRWrpiRglWcgUTTHMBIgLYwTxF+99E0AU=; b=G7ErAIfAgK0Isgkh9l3alG0R4GJaVNg0maoYtY9Z8F5fvpM5r12hNcvRVs5E3oktDV lyp9ilmMqwXA36zhP0JKF8Bd6eW4k1/WiiDbB7jNwRX5aat0l5B9+ngdw8B52j2QHjwO Dxc6Sy+64UIj6SOA3T/4/iWw8N1oeQBXdcD4CYsOtUYqObgaVAlt8ysLgc0yWk03NCuC FAJHPH+0rJG1M7GGIT02AxGCPsOmLImSJ4nGFa3zn/AIx0Pm+67YPtquhgMP4rBMbVhe +FX2CDawqLVPyFGzWX9d1mttUIawYW8O7hshyAqdme3+ctR/8BBsc9q/eszgq+Wtk4Pr 41vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127766; x=1763732566; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HuAu7Wso0jBRWrpiRglWcgUTTHMBIgLYwTxF+99E0AU=; b=fBjjbAinWKHdNTA17HCuwWTet0XxoMuftI0xCWH7MAZ57ThdO+TLSS/rYqTQRKnNYh 3S9AntMhFQriLQ4hJzsly5yOTEpR78/OY+H6W4OD2Nspv+o8cB0CvuKXTlN+dOjkS3UF D9VzTkYrWPlTP+fJG4afAnT80EczI3/V9DWCgxtAWyOUbnzqSi6DSTGGzKXt7SOXWG0S k6Jzb0oFMlFfR9F9x3noWPBek1Zv9DO7rsOoAsoQ5c9V0q/h0KJ3bAmvwHdpogKc0ohz mqLXyMd/xl/c2zSAuVJ5FKOtQBGJwqZAZK7MzZ706CWEvPqd3JKG1Z3pVa0nmeLoOpPp 3lrQ== X-Forwarded-Encrypted: i=1; AJvYcCV/rW3a1AtfuoBuH7TDRG5D14kk46L3GDnEnyKxqsLVD5oyNV8yyivWgZM17QciTyVsN/AIM5FcFY9hwdk=@vger.kernel.org X-Gm-Message-State: AOJu0YzXdmlvNVk/4QLOb0vxFo5fwiguzbXTv7OjzcxhDj7VvXLhJJG4 ZJmmS+tsS86u7anS+lpdqJYkvsPbnTS/ty2EwIUl7i0OThrXTPwOWYZ27u6Ho1ut7084jln92cp Tjr+k X-Gm-Gg: ASbGncug3+MY9GO1Cnl2YVFcJ2jOXCFJAInvctONgm4cCY8NGu7KV4qT7rn0eHF8ftd /HBKvawLwZrvXwc+XK0UMbyOsTJNeAhmhV0snVFLSJ6KpkB3X6Lx/YP54U9Zw2tHoz9jrow7O1/ 4I+UgxsV5eJ6PQZ01mNjpAbIsMYYMB+H9JvrMmLJH7yf5rzDycCh58QMYpwd0qg7nHhPZ2NcjF/ XwJvELGbgTCIbcgxJxZHLKT5K0tqFiuqXE4TM2waqC4a6eyp5lztu0l/1f1pxOPU/9uAg8DHLzW rXuISk/xLNDPamoD5RXWosjBMuHKO55NNAWLAHck7nCPyPrUJeYh1VhI8lRtv/Rjj1lZMhvMSOk S/r+/Yx2Ee3geWA35Vtr8ME1jZhA5fyVUA9rXKtF27THrGDed7EkqzNzOzl7nZ/12MztJ0nMFLh YiFjo= X-Google-Smtp-Source: AGHT+IH52iI5y4jXnMGTK2DYK4Ukz3c2m/wINIYF9V1Z4HGtLQlOTyNuyhHDzpzkKA9UKrLWBFbCyg== X-Received: by 2002:a17:907:787:b0:b73:5f48:6159 with SMTP id a640c23a62f3a-b73678088e2mr294471266b.5.1763127766444; Fri, 14 Nov 2025 05:42:46 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fa80cb6sm397095166b.7.2025.11.14.05.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:42:46 -0800 (PST) Date: Fri, 14 Nov 2025 14:42:44 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Sherry Sun , Jacky Bai , Jon Hunter , Thierry Reding , Derek Barbosa , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH printk v2 1/2] printk: Allow printk_trigger_flush() to flush all types Message-ID: References: <20251113160351.113031-1-john.ogness@linutronix.de> <20251113160351.113031-2-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113160351.113031-2-john.ogness@linutronix.de> On Thu 2025-11-13 17:09:47, John Ogness wrote: > Currently printk_trigger_flush() only triggers legacy offloaded > flushing, even if that may not be the appropriate method to flush > for currently registered consoles. (The function predates the > NBCON consoles.) > > Since commit 6690d6b52726 ("printk: Add helper for flush type > logic") there is printk_get_console_flush_type(), which also > considers NBCON consoles and reports all the methods of flushing > appropriate based on the system state and consoles available. > > Update printk_trigger_flush() to use > printk_get_console_flush_type() to appropriately flush registered > consoles. > > Suggested-by: Petr Mladek > Signed-off-by: John Ogness Looks good to me: Reviewed-by: Petr Mladek Best Regards, Petr