From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8761F32E737 for ; Fri, 14 Nov 2025 14:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763132226; cv=none; b=KXP0qMcsQvZIYUigbWnWI8Zcf3SRMYgZpkAJAjkjWw2WFyUTUNrUJEEG6Eiqb6D867HA+lUbFoZCVhuPVrH55VEMNG5V5xKmtooYfQeA+BroGIRiaEldP3NeE9QTGwBGGc8rt04BIvk16F+3ggbHbke5BZmzKhqZbxAU8I4NCds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763132226; c=relaxed/simple; bh=gciHlXxYLdlQzs+wz9fWszVt4GV+k4O7swYAQmw88xs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PiRwtqND9sUCEE8IQvD6fmCq03uKNHX080rkD2r8UtrvKJYGtedK36pQJmScJMPF1eNxgIr6K1mXY9d+MzVUOQ9I0RrSy48J4KohCCmf58lS9z33FfN9ofNXJRg7f7xXMO9h2Yn3pp1wt/f9/SLE580yi/IckS1e5lCvWlcU0ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DQd+0y+7; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DQd+0y+7" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-640b4a52950so3067773a12.1 for ; Fri, 14 Nov 2025 06:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763132223; x=1763737023; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x48AYDZ6c8REpkpum5TA6RkDPVy+wpYnc495RC66pG0=; b=DQd+0y+7+BUAEc0dk/W2CLqAeB/ccIvpLLH1OY9EqMS70RjqnIufkMq46A90oJoKBH ntccNGcE3dfFtMmFVcr2zzUzXbFrdu/Zpt+dRbXFR9sJhTSMHB/MfVq2vfGE1VvR+Nsm pAPTaA7gTZKNJ9pzIv4+toRysiuZ3Z1LXPmpxuv+2FoqO/txN3c2wCdwYncRL+7Jqy2H vuz5u5c9iiowzVmeQUQRi3iUCBlx0vK90eTjttKfMU9V3arxgKXR6PYKpVuhWtj+tYJz en1rx+JZZnTG7x7VdBH2Z/oUYEW7XsAaJVtPMNFarwZUqI2MDp6C6+IUlzZAwutgH6gb HDMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763132223; x=1763737023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x48AYDZ6c8REpkpum5TA6RkDPVy+wpYnc495RC66pG0=; b=mrHukIYW8NiNrCX50MBrCMz1SxX+rdKEBAaJrQPBbkMNTOmO60bo1mLt05RhrUe9Tp IqN+ltwxuLCm2qh58OCQgckwTWWWVcOPlxZassQKZ6ObDbnzQYVibX4UHCunH4+8J6HA 7PRV2av3Q/qhomyzi3bQQg7iKyfrOGrk9wA5qmuJZUjTrtWktjHPvZ3NMdyXxrV+mik/ C+F5xfJ+E7xb2rqwZBbdYFXFrOUs24t19NbfjFrl6mimkKhLMCu62imlnwImTROSxKyt PRr3gV4MwSFiDEYLgvlP9Lpj91sD9Oy5AqhVOGNTWzabMniXC+j4pWphnzYrmCtQcD9O 30ag== X-Forwarded-Encrypted: i=1; AJvYcCWzO/v7M3D5Krvm6prNnzVak9AXn/ZH2mNN1443o+XLKpeAR2D2ec+7zSPbVqDwyHdReqVNbBaGKjez6Zg=@vger.kernel.org X-Gm-Message-State: AOJu0YwfVaGn8RANT4rl++UrOza2M1PPLuraH6Gw+huKNA/hNS6/c/ME cCAlR7G3ke9zo14+TDJ8qtXlSYnKNXu2VSM0E+iVrePMXJ4/8/cknnHwKFS0y76dAVQ= X-Gm-Gg: ASbGncs8zMey57PPySOxW4f77iH2VeWFyeP7Ak/sQIDvpwCZzNFyjY4uAuxbu4PSPRZ drdl1TymAiKrok0ppwgloVWR5NTQltFALBPfJqSKikwACjhMpMnpi71JdBPqpH7dLlxUpdtgCR3 l4kqe/XHXK8+7Ht5jWmZ/GaKmxuUtnoOozEPeFOMpvC9OXe2n3QRDce2LdpW3ioNYoQ0AB6/Yov uecJBNTYb/NQPh3r94EGAUqns0rkvcJ0ov27xCm9v1ke/QpyOSSNWshXYQIUoTJCENYl0zBBLpj MhMRNlR3g3QRmbJxWbYtUvzsa5n+UKWJMAPB++iG01MCmL+EjxTK+Xl1ASQg31lOxJy8FGcXtaT 80Pm9y8ZrZJvKq4gZHoCVLAhrSz7aHxTFAd8sSY1DH2BsUoEXDm0rI3kot3Ud4LdSfpR9pJnZOx K93Kc= X-Google-Smtp-Source: AGHT+IGmgo/ueKtcknmnIWfzWxJ6fDWEdRR0mk9D2czttZy+48P6Hx0ftDkWhgjzFkqNL+MGjNP5jg== X-Received: by 2002:a17:906:9f89:b0:b73:42df:27a with SMTP id a640c23a62f3a-b7367808697mr315784566b.1.1763132222635; Fri, 14 Nov 2025 06:57:02 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fdaf6dasm400448466b.63.2025.11.14.06.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 06:57:02 -0800 (PST) Date: Fri, 14 Nov 2025 15:57:00 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Sherry Sun , Jacky Bai , Jon Hunter , Thierry Reding , Derek Barbosa , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH printk v2 0/2] Fix reported suspend failures Message-ID: References: <20251113160351.113031-1-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113160351.113031-1-john.ogness@linutronix.de> On Thu 2025-11-13 17:09:46, John Ogness wrote: > This is v2 of a series to address multiple reports [0][1] > (+ 2 offlist) of suspend failing when NBCON console drivers are > in use. With the help of NXP and NVIDIA we were able to isolate > the problem and verify the fix. > > v1 is here [2]. > > The first NBCON drivers appeared in 6.13, so currently there is > no LTS kernel that requires this series. But it should go into > 6.17.x and 6.18. > > The changes since v1: > > - For printk_trigger_flush() add support for all flush types > that are available. This will prevent printk_trigger_flush() > from trying to inappropriately queue irq_work after this > series is applied. > > - Add WARN_ON_ONCE() to the printk irq_work queueing functions > in case they are called when irq_work is blocked. There > should never be (and currently are no) such callers, but > these functions are externally available. > > John Ogness > > [0] https://lore.kernel.org/lkml/80b020fc-c18a-4da4-b222-16da1cab2f4c@nvidia.com > [1] https://lore.kernel.org/lkml/DB9PR04MB8429E7DDF2D93C2695DE401D92C4A@DB9PR04MB8429.eurprd04.prod.outlook.com > [2] https://lore.kernel.org/lkml/20251111144328.887159-1-john.ogness@linutronix.de > > John Ogness (2): > printk: Allow printk_trigger_flush() to flush all types > printk: Avoid scheduling irq_work on suspend > > kernel/printk/internal.h | 8 ++-- > kernel/printk/nbcon.c | 9 ++++- > kernel/printk/printk.c | 81 ++++++++++++++++++++++++++++++++-------- > 3 files changed, 78 insertions(+), 20 deletions(-) The patchset seems to be ready for linux-next from my POV. I am going to wait few more days for potential feedback. I'll push it later the following week unless anyone complains. Best Regards, Petr