From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C701DF24F for ; Fri, 14 Nov 2025 20:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763152462; cv=none; b=LtEU25HgkX3zjI7l2D6lOaEJzS/Th/iLWA+/FVxw3HoE8ZUqNR6LRyVBY3pXk34jIHiB++Ye/fgCg77njX+deAf4fbOVY8KzHmhEqbBQDHQjfuVOdskJaMxaJu7XRAZ92eVzWlwYCvN6FM2CYQLRYCYA4PhKo/RkPodQeIb45/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763152462; c=relaxed/simple; bh=74t65GlEcLLe61c+jn1X9deXuYNch6SLqwI2PPCxfxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d3DhyBI0YGdwkShezEeAyjDwkT7GQ1GuGUUKDH0CtpZO/bMa+krnlQsYMxniRD/afi7x9dF4BWlp40N6FTfSYAi0ElCfFHwZSvV3CY2MjZz46glZIPuN573w0uWykypqGi07KdtPEYA5qV1OiTTuaKRshsNx4CoQVi6X57p78Gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U2qkLRWU; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2qkLRWU" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3410c86070dso1844339a91.1 for ; Fri, 14 Nov 2025 12:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763152460; x=1763757260; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z2tUyhIah92QGKm3skN+GFPKLkbDp3lL7w3hkBKRK+M=; b=U2qkLRWUvNKBGlcbhz/ytqPaWTvOT+obvEtPAyLYCpD8en0AtlLclB5y5wInHnnmaF oiGzo9h5nfN8+e5uuh+RJX6x+TVul8+9atFtOecZ7Pux0W4z2GsCRE/qc57/MhGP1HWx 7gUb+XMl1C5UccfsXSbJVErNvvp8WoTjp7gn3FW2q1NI3QXq0ZWlj3rsfillsCcc0GqT xcKEBjYKyKw2FAYiQNcc6rren+yQPqx+0HfD3pqcBdjYLNzNotHT6tn5RuqbaQAnWzme lU1m0FPoR2aZf2wXSJE7v1vPtXn/lJltqmcYLwCS0RigDn7FgHit5nxqoPyUcn7aC1/l LD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763152460; x=1763757260; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z2tUyhIah92QGKm3skN+GFPKLkbDp3lL7w3hkBKRK+M=; b=wjth7QvJzJ5AHdVgbBgzpHera42kokYQ3PFL+GycO7W+EJv+2vZNKabVzu9O+G1Fyd UhYB5jgRCMF2HUvzdn4s6JsZWzUgPwFgIj+Z87prYKN4zE5Aet67S/TFHooz/77dV0vk KKTj2f4M+Y8ucDqVSg283YwKg3IN3njtmlqG2iigNyXi+dp+LxD+q8noEdDF/cgYaYeh EHvh8H5QNyM2j/5HqmEAY5tHaIjznA9xMyal1aEsATbOg2qCahwAclHjJCqSDYnA3Y8J zugIP57poW5VepelzFJ9m6vQkJcOjpvH5f0lUKkUyDH7l+zvYex5MatXUoCQ4Ru1t+Az PY6g== X-Forwarded-Encrypted: i=1; AJvYcCV7bRayH+EJpn71VqS1IARuZqzKowO5EMQ1IEiVS+ibwGmg8Cr9q4W+gfnMyYXhd8B2DgsPzrcfDnv/L7A=@vger.kernel.org X-Gm-Message-State: AOJu0YyGBJaDChyIoETlCmeB+Z1lP5rkptFme/xQLFq04tLqplb1a5ON lYXa+aXkqVkln3EMv2rg1TgraKhFMyHasSv1iFsS4njhxhk3eUgZ1mNw X-Gm-Gg: ASbGncs3Dzl0/424lmtnevsbk/YdZ92HDdpAYyknqj5VQvdIV5P3eQRzQzhgudBTAn1 /bUxYCflIQt8I8cz2V095PeL/DHYyWBwO4RfTSROMd/0ayJXv5KzA8Hz8Aw5oL6rlDdjl5sECH7 V6LLaaHGRYMEZp9XmB5SAuLXBzzTKAFyUzKhfly8YPVGUzbdD5VG1+hdYFrgWnKUsKrxquRPop4 oOpkdWfNkeHUkWI4ugyo3lM9fxNHCrQTrjvFF1xqz1Nwy/98DndoaGt7nIYWulmF/lXnxCnfIp6 XxLcVyb9mLhmAPaIj1uI+E9TGrctsjgVrP/Cy8C9Ho5YNFiUqobjbofZwi9+RqNcACLkFC4DqIz gGaqnFKSZeMm/2hFuWrSEZNi2cTmK2VcaIpzVjE43f27cggz/y0Q9JLMecWahbuO9KBIeHAQT4t Q1UbJMEVflxrlStPfpXaM= X-Google-Smtp-Source: AGHT+IEe7JuZ4t+UG3Ej2ub9oJMa/3y/sYYCQh/JHxxvjriyxwW0b8MtjVbBgwEpy0ihZpW+2/eVvw== X-Received: by 2002:a17:90b:37ce:b0:340:f05a:3ebd with SMTP id 98e67ed59e1d1-343fa7469ecmr4392519a91.28.1763152459570; Fri, 14 Nov 2025 12:34:19 -0800 (PST) Received: from geday ([2804:7f2:800b:9c95::dead:c001]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bc36db22439sm5747058a12.4.2025.11.14.12.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 12:34:18 -0800 (PST) Date: Fri, 14 Nov 2025 17:34:05 -0300 From: Geraldo Nascimento To: Shawn Lin Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci , linux-arm-kernel , linux-kernel , devicetree , krzk+dt , conor+dt , Johan Jonker , linux-rockchip , Simon Glass , Philipp Tomsich , Kever Yang , Tom Rini , u-boot@lists.denx.de, =?utf-8?B?5byg54Oo?= Subject: Re: [PATCH] arm64: dts: rockchip: align bindings to PCIe spec Message-ID: References: <67b605b0-7046-448a-bc9b-d3ac56333809@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 14, 2025 at 05:16:21PM +0800, Shawn Lin wrote: > Don't worry, it's helpful, so I think Ye could have a look. > May I ask if the failure only happened to one specific board? Hi Shawn, Yes, testing is restricted to my Radxa Rock Pi N10 board. > > Another thing I noticed is about one commit: > 114b06ee108c ("PCI: rockchip: Set Target Link Speed to 5.0 GT/s before > retraining") > > It said: "Rockchip controllers can support up to 5.0 GT/s link speed." > But we issued an errata long time ago to announced it doesn't, you could > also check the PCIe part of RK3399 datasheet: > https://opensource.rock-chips.com/images/d/d7/Rockchip_RK3399_Datasheet_V2.1-20200323.pdf OK, I'm partly responsible for that as author of the commit in question. First off let me say I do not intend to send any patches setting max-link-speed to TWO for this platform. I understand you issued an erratum, but are you absolutely sure about that erratum? Because my testing shows otherwise: --- With max-link-speed = <2> pci 0000:01:00.0: 16.000 Gb/s available PCIe bandwidth, limited by 5.0 GT/s PCIe x4 link at 0000:00:00.0 (capable of 31.504 Gb/s with 8.0 GT/s PCIe x4 link) /dev/nvme0n1: Timing cached reads: 3002 MB in 2.00 seconds = 1502.21 MB/sec Timing buffered disk reads: 2044 MB in 3.00 seconds = 680.79 MB/sec --- With max-link-speed = <1> pci 0000:01:00.0: 8.000 Gb/s available PCIe bandwidth, limited by 2.5 GT/s PCIe x4 link at 0000:00:00.0 (capable of 31.504 Gb/s with 8.0 GT/s PCIe x4 link) /dev/nvme0n1: Timing cached reads: 2730 MB in 2.00 seconds = 1366.15 MB/sec Timing buffered disk reads: 2028 MB in 3.00 seconds = 675.71 MB/sec --- As you can see, not only the kernel PCI driver recognizes 5.0 GT/s PCIe link but there's even a marginal increase in cached reads as measured by hdparm, the gains are of course limited by CPU performance. > Also we set max-link-speed to ONE in rk3399-base.dtsi but seems another > patch slip in: 755fff528b1b ("arm64: dts: rockchip: add variables for > pcie completion to helios64") I can't speak for patches I haven't authored, but I believe you're welcome to send a correction. Thank you, Geraldo Nascimento