From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CDB41FE451 for ; Sat, 15 Nov 2025 07:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763193534; cv=none; b=Ilq2hTIXFaox3/5P+3SQhIOBLwD7kBp+2OLgM7rX97806bjOtSOgnAsl3FFVU8itPdKr1ic96QbMU9IXMoW85xWitLJPFWTaPTn+Up01nSCijbyhN6cfYfy0EGGi3bRV6MywYUOoEvDaIkZe4G9+IPRmLXqzzXKkp8qttr8RYZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763193534; c=relaxed/simple; bh=7IA24hssfbm9kgS+7AETJvRObZ5S/rQnPGOyauw47VE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nGJWAn4Ijh3M3hh4ek1lN0kfUiiQx3wdccsX7hxLH762wL/wpqzuF9uDuKJ5QsraEWyJ+5+/3WxWSz0a6HzrhDzyFB/P/9TO2RjPt12+UQWwU1ncsc4SsX/eUO2rj/9ozz3XJMXRV6OQogR1WLs2UUpeDXb3pOFzP+HaMj7sC6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OzW0R3+e; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OzW0R3+e" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3436cbb723fso2169610a91.2 for ; Fri, 14 Nov 2025 23:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763193532; x=1763798332; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MF0CNlB09dDx8CZgE5eg3pyjdHElMh021rKPfz1W410=; b=OzW0R3+e0oa+av7r0wlfZt60wp2JakbpSIdq0xD8yB9cs0C8eh0ADZQQVUUl19nML/ QA6/IO06HsAlw76MJ5ZoNcF5HDrvxJkp8/mQ69UjCi70/pe8yRqw+j9QuqGzTVADtx/2 ua2iQMjBWYqMVwFqFWz7eHznHeIV9wJ22P+qIYCK5h+jJCX1GByz7JGtuFI/akqHqRTX nuDgNxz5KpTnhuQY8PujU/l1c1oGqDEIRJ2yK+aLC5AkWxX+t/E2gvOBC6W/XjP1lEE1 jMUEx7Vi7S/NaiSPRGUQspjZ/h2zTqt88htJmIDZctQTW5KJlgwBP8So83B6dGJz216K q3Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763193532; x=1763798332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MF0CNlB09dDx8CZgE5eg3pyjdHElMh021rKPfz1W410=; b=QI+4+xQrhpumFnN+qXratWkLWUPsxG1bJmN+1dhHQeBzMJftPEORL9zlAxmDBnMQlc VzV5JD9jeD8mi9YAETWqCJXEq5lTlvqHGtgmFEuhONT4WjT7iicbc5Mal7DlE8zakEcG VBzRZ5y8+eiqEKka5ChUy5N409LWN/+/cxj0TWcCN/7MM2EC8hKh4OauE6nFPVrfSfOd jVehB/9Z1JhWY4qqYjT9RcrMHEII7LRWAV9BfNSsEM+Grs555Xe41vCpXmwx++Fd76jz dhScnXG1emJ8n1PAOWszAjD1H07Tm5zPHGbCnX55OJUZWYJGG3l7Ud8GByyz5yVKjdgl +g/Q== X-Forwarded-Encrypted: i=1; AJvYcCUAcuYEVtn8H+W1pBRiWnpvbAFJgcYJ/8jQtAjeRIyhxdMjjX+52UPVfuAImETaJGMViq+D4JGIDY6PvAI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6X/MFqWKChMpX2Db7J63iXwlDAYBwjJekxe3F+cRSpyQt5o6Y zQnf+CElribZ9q+IByj8xJ/RlwjjWoaxg9HEoDFADr4HE+R8vv0kAARY X-Gm-Gg: ASbGnctyzpU4+hfu/EfJv5p/w3k7P1Ky/4kIKBSk9wgqTEJbEWZGCT2o/RD3wTo6Sey yZ2VYiihbnvCnM5JczDKhmaCyOWLWxjWb+c3qNt5e7RPjQXjcRdPKLi1kbh2SgFGYBdlMglghoJ Iae3AHGYBqhgFW8lnBZowbjzEADwOQvr1Ni3wx9XAUJ4UQ85BO4gu29yTqiZ9M/bZMNsoeqsiJZ +yA0bSzAcYrH1gALO+AIm4RJwHYMnyMK/6vLWg8+3EIzcWlQ3Fkw20mcCR/BYefs0U18B8JZJ6b I6EZEkSQq2yJXTnO0B6o8Wf44ztAxtEeeflTIilkHhw4Mw/fC50ULHWxyceCea0Ryqtbawso96U TU8nevDwaXaxrgd82yP/9po8A3G2fel21d/bf8JM7wVUdlCBhTYuJ/H4SbzOA7vs/+q6fM5Fk9X BihYW0BZRHxr+/hulb49Jq6fB7FZBiV71j8ECS0Q== X-Google-Smtp-Source: AGHT+IF5RfVfdoSR8epRBvO25wL7MVlPY9GHcuOfhGeoJp77hSo38v+4EuRhPqUWE1eLEn1PhRthJQ== X-Received: by 2002:a17:90b:1d0a:b0:32e:3552:8c79 with SMTP id 98e67ed59e1d1-343fa73faebmr6776084a91.29.1763193532599; Fri, 14 Nov 2025 23:58:52 -0800 (PST) Received: from lima-default ([103.246.102.164]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343e07156absm11518522a91.5.2025.11.14.23.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 23:58:51 -0800 (PST) Date: Sat, 15 Nov 2025 18:58:41 +1100 From: Alessandro Decina To: Maciej Fijalkowski Cc: netdev@vger.kernel.org, "David S. Miller" , Alexei Starovoitov , Andrew Lunn , Daniel Borkmann , Eric Dumazet , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Paolo Abeni , Przemek Kitszel , Stanislav Fomichev , Tirthendu Sarkar , Tony Nguyen , bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3 1/1] i40e: xsk: advance next_to_clean on status descriptors Message-ID: References: <20251113082438.54154-1-alessandro.d@gmail.com> <20251113082438.54154-2-alessandro.d@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 14, 2025 at 02:01:14PM +0100, Maciej Fijalkowski wrote: > Woah, that's not what I had on mind...I meant to pull whole block that > takes care of FDIR descriptors onto common function. That logic should be > shared between normal Rx and ZC Rx. The only different action we need to > take is how we release the buffer. > > Could you try pulling whole i40e_rx_is_programming_status() branch onto > function within i40e_txrx_common.h and see how much of a work would it > take to have this as a common function? Just before I send another rev, you mean something like this? https://github.com/alessandrod/linux/commit/a6fa91d5b5d1cc283a2f1faa378085c44bda8b4a My rationale for i40e_inc_ntp_ntc was that _that_ is where the bug lies: letting ntp and ntc get out of sync. By introducing a function that forces you to _have_ to think about ntc and explicitly pass NULL if you don't want to sync it, bugs like this become less easy to introduce. That said I don't mind either way! Let me know if you want me to send v4 with the i40e_clean_programming_status() change. Ciao, Alessandro