From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377C5238176 for ; Sat, 15 Nov 2025 09:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763199618; cv=none; b=JCoV4iuYkzd0ddm+Rj/qmbjhLIY6sI9km1g/AG/FwRHGw2lDODwad/kR1MRyI9dYXGbT0IQmQwc9XyeZH1PCw2gsrcx8Gy6GxJvdZ2Kq2c9CNljbZ1qM3zgjpvq+PsDqfbLVvtnpHTc5EItDtD1k82CnTo+Il79D4p5pp/srbV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763199618; c=relaxed/simple; bh=Ftwq9aXcMX9LHqwm1OwdhNRh26BPiUZtjHSBKYdzc7A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mvhdmz1bNx7rNl6Q+TFKBIqVXmKSWo6qTC2Ctt4J1HkbpZ0DdT9Cq3D7onWAfbBV4x6syXFWxrNHdvzizo+fjezL1Zu3UMgNu1wfUMEaSoP1VZtam/q6wNmHX6t/pCzTBR8NL/KDlRodR8ZuA04SxsHYTQ75mmJZmXv2LfOHaZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jnACPYRG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jnACPYRG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59544C19423; Sat, 15 Nov 2025 09:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763199617; bh=Ftwq9aXcMX9LHqwm1OwdhNRh26BPiUZtjHSBKYdzc7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jnACPYRGa0Ckp5lRrrDfhH+1W1avXDf7QG3tmJb6TLgF0IHMUoQub3f+z+duHfIlw b3gL1NefLvwN1CxaW6GeiptTvPo9pITddyzIcyre1y2CFr4GcAJmOefxYcb/zUT3tg kVQGBlQPZveH0FwA0jWK4VvlubuTgK2pR247Qzd8X8RW0TQLJwWsqFY0G09jrAjqCA xxhfGO91qX5kNCEkcPzb/pZiqnWDaZmCBSktt7qH7Uv67WM4xSL0FUal1b5JBMO98w 7S3RIA2pWrvzpC5HIR57S71tJf5pGjYLJ5MbgFnNzdru+jx7kYJxJu+mt8a7TlLnr+ 3W6qQcwJ5i53w== Date: Sat, 15 Nov 2025 11:40:09 +0200 From: Mike Rapoport To: Pasha Tatashin Cc: akpm@linux-foundation.org, bhe@redhat.com, jasonmiu@google.com, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2 10/13] kho: Update FDT dynamically for subtree addition/removal Message-ID: References: <20251114190002.3311679-1-pasha.tatashin@soleen.com> <20251114190002.3311679-11-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251114190002.3311679-11-pasha.tatashin@soleen.com> On Fri, Nov 14, 2025 at 01:59:59PM -0500, Pasha Tatashin wrote: > - struct kho_sub_fdt *sub_fdt; > + phys_addr_t phys = virt_to_phys(fdt); > + void *root_fdt = kho_out.fdt; > + int err = -ENOMEM; > + int off, fdt_err; > > - sub_fdt = kmalloc(sizeof(*sub_fdt), GFP_KERNEL); > - if (!sub_fdt) > - return -ENOMEM; > + guard(mutex)(&kho_out.lock); > + > + fdt_err = fdt_open_into(root_fdt, root_fdt, PAGE_SIZE); > + if (fdt_err < 0) > + return err; > > - INIT_LIST_HEAD(&sub_fdt->l); > - sub_fdt->name = name; > - sub_fdt->fdt = fdt; > + off = fdt_add_subnode(root_fdt, 0, name); Why not fdt_err = fdt_add_subnode() as I asked in v1 review? > + if (off < 0) { > + if (off == -FDT_ERR_EXISTS) > + err = -EEXIST; > + goto out_pack; > + } -- Sincerely yours, Mike.