From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDB6274B23 for ; Sat, 15 Nov 2025 10:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763201082; cv=none; b=SbYi7ndx2tMlADJXcMYcVLkbCap61IlaY/ApTh+yQqdelgafJf2tmb0AlGolbu/mDIkB5X8jLi4UdOFbyO2FiSukKH4mlXfsk6RdVYlvi80oqvH3MEc6zmGIjw8lGYhvgzwJlDJ7Uty0YDfdP1VrtzN3selddiI8DFU3GfTx1mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763201082; c=relaxed/simple; bh=zgjl9yCq9rPKjasEHPzdGjgJBDrAOD+3CpouL6oTMjY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K5BGRbJicmEHFeOGQtR6bjpRtqb1CJklBG5RQKC3w0doRBKlULB+rP9W5gIGAsCKwyG1IamJ7PbKOK90Yd97NgEfY8QMUj3USZbuK45r6tD5W0bMhuuv/QTPW9WOk3p4aRlS4ZtMiDNT97DMiHlYEDR/8Sz8ID4WSYhaYIXpTGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P8HPcQ0P; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P8HPcQ0P" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b55517e74e3so2253854a12.2 for ; Sat, 15 Nov 2025 02:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763201080; x=1763805880; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7ZhGFSTWU2Nki77TLqMBxYMwF/Hq7Nj2xup+lQAIdEs=; b=P8HPcQ0PRIOdgTyoXEu2GsIk1pmPsBbluE//rwRBzh4NTEYpsPrRy9TyybsnXH7yRD WDJS3A67tz0WHnrv+eiNvkqI2BrnCvtxmpea0SIvR/ZloXHydTn2gIsfmnK1UUWCsk32 js6Ze3ZsjV3yd9FFNg6FGdafFLYyare6Fz4U2/MXDhaVRhZOE/OCk2a5vxU/HFmRrcgz T7mhnA9niCi288XHdwKOORn1bj3zT8fkL6/CCsymlva3XSedv59Klrtg7FanTbetEuA1 /3FlVnqlq2HXwXob/jZ4DqjOzS4WKPzB93+R+GiNDQvXuMOxLo1QJDW5RgZ/4RU5HeVJ G5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763201080; x=1763805880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ZhGFSTWU2Nki77TLqMBxYMwF/Hq7Nj2xup+lQAIdEs=; b=XiuI4DMz9JBZFewo8wYHrWY9m59olIuit7gDoMtVxxjUkbcm+MJLChPuKEpxTzApq0 Ap2Q55px5WW6Y30FFLc3FcQ4LOIA1outy8KZKveM9V1VmAjg5gLjrtA2d72R5oFqO+aj sgy1N30UezkM2O83JeDiVR4qT8yOFCDCVHDsFy/tw5MjVJd81NIbeOpg8Opwza6FZbKl iXyt6+Wklv6ZUdShfnGPt/zt3VnibJMoX6Nx7nwcV2+20QO1uIpJRYEIAosDJIZyV5eX jpsEVk9XTQr0vr312hu2uTuRuWl4nFPjUGZnzIUwBP01PtOIK0JQ1GJJvhF2qVAZNqDT MnMQ== X-Forwarded-Encrypted: i=1; AJvYcCVp8EZlTIj1hmbNmNw+e1cQrXkBEBqXI7A+msuwMxwapppZpNrl2fw/E+DgwDj460OZ21BRdY/jKr3UKU8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6JrNtWLlM5ncBi0uirrnivHBa9/Eod0aeCcSSxdmzjn9pNe4D shLInMfyvETu/1pLEfpq5YfSou1pkxwtBfaSTu0vm5+uwsQW7XAXAfkS X-Gm-Gg: ASbGnctlbbksc0hw0gD9D0VBi7eCUQLARohsH29r1ofPyaUUVwtP9yQdky0OGpU7xlA 3RUeeRKeOjKooO/b3U2TkKDiAxk/KRag7oR16TbCJbQY8OKhZ+wBq4Q2V/skZ1W66+3CRCRZhyc bPQ5ICZu9d111a2GYogmoDVqHmVBcw1v9Uws91rCZdH97PFTpY/Nc0FJVVjrJzATF4IIJXMFGBd qa77JztNReAHzQgfxHyGlMWI7H4WcEgmziDJwxySNBu74gJ66NtqwiCrQqjg0V0dhUihQLuv1XU B9ewS/1dnokisv0W3WhEtJFvGk1DqI7yQVq4yFch6ZIzEZgCn+WwDR0YbbxU1G+4sURNFEwYRug BSmA7RwOWMBsjQeotnm/JgQsaVNdPlbb8moS5SwRohRfzfXwal3KfoWEOIHYXlG9I1shkGDyFPq g7g51Ia1O7 X-Google-Smtp-Source: AGHT+IEN9KE2hfp03GE7uhiO9j7fRJeATScAJLPGVWT9cgl5CZeCVAf71AB1h38u4dnqNvb+75Hfxg== X-Received: by 2002:a05:7300:c3a2:b0:2a4:3593:c7dd with SMTP id 5a478bee46e88-2a4abd4a140mr2291702eec.29.1763201079996; Sat, 15 Nov 2025 02:04:39 -0800 (PST) Received: from geday ([2804:7f2:800b:a121::dead:c001]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d695821sm23290090eec.0.2025.11.15.02.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 02:04:39 -0800 (PST) Date: Sat, 15 Nov 2025 07:04:33 -0300 From: Geraldo Nascimento To: Dragan Simic Cc: linux-rockchip@lists.infradead.org, Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker Subject: Re: [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed Message-ID: References: <85d1543b-ea91-5f0f-59d6-e00fcf720938@manjaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85d1543b-ea91-5f0f-59d6-e00fcf720938@manjaro.org> On Sat, Nov 15, 2025 at 11:01:21AM +0100, Dragan Simic wrote: > On Saturday, November 15, 2025 10:51 CET, Geraldo Nascimento wrote: > > On Sat, Nov 15, 2025 at 10:30:49AM +0100, Dragan Simic wrote: > > > Looking good to me, thanks for this patch! There's no need > > > to emit warnings here, because they'd be emitted already in > > > the rockchip_pcie_parse_dt() function. > > > > > > Please feel free to include > > > > > > Reviewed-by: Dragan Simic > > > > > > > I disagree, I think the comment stands. > > > > Even if we reduce to one line, ex: > > > > + May cause damage > > Ah, perhaps I wasn't clear enough, so let me clarify a bit. The > comment you added is fine, I just referred to no need for emitting > a warning at that point, because it would be emitted already. OK, I get it now so I think it's time to send v2 with all that in mind :) Thanks, Geraldo Nascimento